Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add current status of tinygo based on issue #2979 #2987

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

leongross
Copy link
Contributor

This PR records the status of the tinygo integration for u-root.
It will be updated regularly to reflect the latest changes to the project.

Signed-off-by: leongross <leon.gross@9elements.com>
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.26%. Comparing base (34473c2) to head (587da7f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
+ Coverage   57.07%   57.26%   +0.19%     
==========================================
  Files         528      528              
  Lines       32608    32608              
==========================================
+ Hits        18611    18673      +62     
+ Misses      13997    13935      -62     
Flag Coverage Δ
.-amd64 90.69% <ø> (ø)
cmds/...-amd64 46.34% <ø> (+0.03%) ⬆️
integration/generic-tests/...-amd64 19.80% <ø> (ø)
integration/generic-tests/...-arm 11.69% <ø> (ø)
integration/generic-tests/...-arm64 23.96% <ø> (ø)
integration/gotests/...-amd64 61.30% <ø> (+0.35%) ⬆️
integration/gotests/...-arm 61.93% <ø> (ø)
integration/gotests/...-arm64 62.27% <ø> (-0.14%) ⬇️
pkg/...-amd64 57.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
everything 63.23% <ø> (+0.23%) ⬆️
cmds/exp 30.54% <ø> (ø)

Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the matrix.

Also, it would be nice to see the tinygo binary size, compared to the regular binary size.

@leongross
Copy link
Contributor Author

leongross commented May 24, 2024

Also, it would be nice to see the tinygo binary size, compared to the regular binary size.

Yes that would be very helpful. Since this is quite some data we want to analyze, it would probably be a good idea to build some tooling around that to minimize the manual work

@rminnich
Copy link
Member

I think the tinygo size comparison could be part of the CI tasks.

@10000TB
Copy link
Member

10000TB commented Jun 3, 2024

+1 for matrix.

Once there is a matrix, with some data as an example to allow future iterations, I think this will then be good to go

@leongross
Copy link
Contributor Author

This idea is good, but I think we should keep the overview simple for now and extend it over time with a matrix build overview and a ci integration.

@leongross
Copy link
Contributor Author

CI fails due TLS handshake timeout ...

@10000TB
Copy link
Member

10000TB commented Jun 9, 2024

CI fails due TLS handshake timeout ...

likely an issue already at HEAD. I'd find it hard to believe this markdown change has anything to do with that.

did a rebase, let's see if it is a persistent issue.

@10000TB 10000TB merged commit 9db43d2 into u-root:main Jun 9, 2024
37 checks passed
@10000TB
Copy link
Member

10000TB commented Jun 9, 2024

it looks like we all agree there need a matrix, but there is no objection to allow this go in first.

Added a tracker / FR to add a compatibility matrix: https://github.com/orgs/u-root/projects/2/views/1?pane=issue&itemId=66662510.

I'll make sure the FR is completed before closing the tab on tinygo.

thanks,

@leongross leongross deleted the doc/tinygo branch June 10, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants