Require Node.js 14.17.0 (#513)

.eslintrc.js

@@ -7,16 +7,8 @@ module.exports = {
 
   plugins: ['node', '@typescript-eslint'],
 
-  // We don't use babel for transpiling, but we do use features
-  // supported by Node.js that the default eslint parser does not
-  // yet understand.
-  parser: '@babel/eslint-parser',
   parserOptions: {
     sourceType: 'script',
-    requireConfigFile: false,
-    babelOptions: {
-      plugins: ['@babel/plugin-syntax-class-properties'],
-    },
   },
 
   rules: {
@@ -68,6 +60,9 @@ module.exports = {
     },
     {
       files: ['*.mjs'],
+      parserOptions: {
+        sourceType: 'module',
+      },
       rules: {
         'import/extensions': ['error', 'ignorePackages'],
         'import/no-unresolved': ['error', {

.github/workflows/ci.yml

@@ -35,12 +35,12 @@ jobs:
     name: Tests
     strategy:
       matrix:
-        node-version: ['12.x', '14.x', '16.x', '18.x']
+        node-version: ['14.x', '16.x', '18.x']
         mongo-version: ['5.0']
         include:
-          - node-version: '12.x'
+          - node-version: 'lts/*'
             mongo-version: '4.2'
-          - node-version: '12.x'
+          - node-version: 'lts/*'
             mongo-version: '4.4'
     runs-on: ubuntu-latest
     services:

dev/u-wave-dev-server

@@ -32,7 +32,7 @@ const testTransport = {
  * üWave API development server.
  */
 async function start() {
-  const port = Number(argv.port || process.env.PORT || 6042);
+  const port = Number(argv.port ?? process.env.PORT ?? 6042);
 
   const uwave = require('..');
 

example/index.js

@@ -8,15 +8,15 @@ import dotenv from 'dotenv';
 
 dotenv.config();
 
-const port = process.env.PORT || 80;
+const port = process.env.PORT ?? 80;
 const secret = Buffer.from(process.env.SECRET, 'hex');
 
 const DEFAULT_MONGO_URL = 'mongodb://localhost:27017/uwave';
 const DEFAULT_REDIS_URL = 'redis://localhost:6379';
 
 const uw = uwave({
-  mongo: process.env.MONGO_CONNECTION_URL || DEFAULT_MONGO_URL,
-  redis: process.env.REDIS_CONNECTION_URL || DEFAULT_REDIS_URL,
+  mongo: process.env.MONGO_CONNECTION_URL ?? DEFAULT_MONGO_URL,
+  redis: process.env.REDIS_CONNECTION_URL ?? DEFAULT_REDIS_URL,
   port,
   secret,
   // This has to be disabled so the headers do not get added to the web client too.

package.json

@@ -23,7 +23,7 @@
     "u-wave-core": "bin/u-wave-core"
   },
   "engines": {
-    "node": ">= 12.20.0"
+    "node": ">= 14.17.0"
   },
   "dependencies": {
     "ajv": "^8.0.5",
@@ -34,7 +34,6 @@
     "cookie": "^0.5.0",
     "cookie-parser": "^1.4.4",
     "cors": "^2.8.5",
-    "crypto-randomuuid": "^1.0.0",
     "debug": "^4.1.1",
     "escape-string-regexp": "^4.0.0",
     "explain-error": "^1.0.4",
@@ -71,10 +70,7 @@
     "yaml": "^2.0.0"
   },
   "devDependencies": {
-    "@babel/core": "^7.13.13",
-    "@babel/eslint-parser": "^7.13.10",
-    "@babel/plugin-syntax-class-properties": "^7.12.13",
-    "@tsconfig/node12": "^1.0.7",
+    "@tsconfig/node14": "^1.0.1",
     "@types/bcryptjs": "^2.4.2",
     "@types/cookie": "^0.5.0",
     "@types/cookie-parser": "^1.4.2",
@@ -88,7 +84,7 @@
     "@types/jsonwebtoken": "^8.5.1",
     "@types/lodash": "^4.14.168",
     "@types/ms": "^0.7.31",
-    "@types/node": "12",
+    "@types/node": "14",
     "@types/node-fetch": "^2.5.8",
     "@types/nodemailer": "^6.4.1",
     "@types/passport": "^1.0.6",

src/HttpApi.js

@@ -113,7 +113,7 @@ async function httpApi(uw, options) {
       mailTransport: options.mailTransport,
       recaptcha: options.recaptcha,
       createPasswordResetEmail:
-        options.createPasswordResetEmail || defaultCreatePasswordResetEmail,
+        options.createPasswordResetEmail ?? defaultCreatePasswordResetEmail,
     }))
     .use('/bans', bans())
     .use('/import', imports())

src/Page.js

@@ -24,7 +24,7 @@ class Page {
   }
 
   get pageSize() {
-    return this.opts.pageSize || this.length;
+    return this.opts.pageSize ?? this.length;
   }
 
   get filteredSize() {

src/Source.js

@@ -94,7 +94,7 @@ class Source {
   }
 
   get apiVersion() {
-    return this.plugin.api || 1;
+    return this.plugin.api ?? 1;
   }
 
   /**

src/auth/JWTStrategy.js

@@ -77,8 +77,8 @@ class JWTStrategy extends Strategy {
     const { bans } = req.uwave;
 
     const token = getQueryToken(req.query)
-      || getHeaderToken(req.headers)
-      || getCookieToken(req.cookies);
+      ?? getHeaderToken(req.headers)
+      ?? getCookieToken(req.cookies);
     if (!token) {
       return this.pass();
     }

src/controllers/authenticate.js

@@ -46,7 +46,7 @@ function seconds(str) {
  * @type {import('../types').Controller}
  */
 async function getCurrentUser(req) {
-  return toItemResponse(req.user || null, {
+  return toItemResponse(req.user ?? null, {
     url: req.fullUrl,
   });
 }
@@ -84,7 +84,7 @@ async function refreshSession(res, api, user, options) {
     const serialized = cookie.serialize('uwsession', token, {
       httpOnly: true,
       secure: !!options.cookieSecure,
-      path: options.cookiePath || '/',
+      path: options.cookiePath ?? '/',
       maxAge: seconds('31 days'),
     });
     res.setHeader('Set-Cookie', serialized);
@@ -445,7 +445,7 @@ async function logout(req, res) {
     const serialized = cookie.serialize('uwsession', '', {
       httpOnly: true,
       secure: !!cookieSecure,
-      path: cookiePath || '/',
+      path: cookiePath ?? '/',
       maxAge: 0,
     });
     res.setHeader('Set-Cookie', serialized);

src/controllers/now.js

@@ -80,7 +80,7 @@ async function getState(req) {
   const booth = getBoothData(uw);
   const waitlist = uw.waitlist.getUserIDs();
   const waitlistLocked = uw.waitlist.isLocked();
-  let activePlaylist = user && user.activePlaylist
+  let activePlaylist = user?.activePlaylist
     ? uw.playlists.getUserPlaylist(user, user.activePlaylist)
     : null;
   const playlists = user ? uw.playlists.getUserPlaylists(user) : null;
@@ -91,7 +91,7 @@ async function getState(req) {
 
   if (activePlaylist != null) {
     activePlaylist = activePlaylist
-      .then((playlist) => (playlist ? playlist.id : null))
+      .then((playlist) => playlist?.id)
       .catch((err) => {
         // If the playlist was not found, our database is inconsistent. A deleted or nonexistent
         // playlist should never be listed as the active playlist. Most likely this is not the

src/controllers/playlists.js

@@ -222,7 +222,7 @@ async function getPlaylistItems(req) {
   const { user } = req;
   const { playlists } = req.uwave;
   const { id } = req.params;
-  const filter = req.query.filter || undefined;
+  const filter = req.query.filter ?? undefined;
   const pagination = getOffsetPagination(req.query);
 
   const playlist = await playlists.getUserPlaylist(user, new ObjectId(id));

src/controllers/server.js

@@ -37,7 +37,7 @@ async function getConfig(req) {
   const combinedSchema = config.getSchema();
   const schema = combinedSchema.properties[key];
 
-  return toItemResponse(values || {}, {
+  return toItemResponse(values ?? {}, {
     url: req.fullUrl,
     meta: includeSchema ? { schema } : {},
   });

src/email.js

@@ -19,7 +19,7 @@ async function sendEmail(emailAddress, options) {
     },
   };
 
-  const transporter = nodemailer.createTransport(options.mailTransport || smtpOptions);
+  const transporter = nodemailer.createTransport(options.mailTransport ?? smtpOptions);
 
   const mailOptions = { to: emailAddress, ...options.email };
 

src/middleware/errorHandler.js

@@ -41,8 +41,8 @@ function serializeError(err) {
 
   if (err instanceof APIError) {
     return [{
-      status: err.status || 500,
-      code: err.code || 'api-error',
+      status: err.status ?? 500,
+      code: err.code ?? 'api-error',
       title: err.message,
     }];
   }
@@ -63,7 +63,7 @@ function serializeError(err) {
   if (err.expose) {
     /** @type {SerializedError} */
     const apiError = {
-      status: err.status || 400,
+      status: err.status ?? 400,
       code: err.code,
       title: err.message,
     };

src/middleware/rateLimit.js

@@ -16,7 +16,7 @@ RateLimiter.prototype.getAsync = promisify(RateLimiter.prototype.get);
  * @returns {import('express').RequestHandler}
  */
 function rateLimit(prefix, opts) {
-  const RLError = opts.error || RateLimitError;
+  const RLError = opts.error ?? RateLimitError;
 
   return wrapMiddleware(async (req, res) => {
     const uw = req.uwave;

src/plugins/bans.js

@@ -58,7 +58,7 @@ class Bans {
   async getBans(filter, pagination = {}) {
     const { User } = this.#uw.models;
 
-    const offset = pagination.offset || 0;
+    const offset = pagination.offset ?? 0;
     const size = clamp(
       pagination.limit == null ? 50 : pagination.limit,
       0,

src/plugins/chat.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const randomUUID = require('crypto-randomuuid');
+const { randomUUID } = require('crypto');
 const routes = require('../routes/chat');
 
 /**

src/plugins/configStore.js

@@ -100,7 +100,7 @@ class ConfigStore {
     const validate = this.#registry.get(key);
     if (!validate) return undefined;
 
-    const config = (await this.load(key)) || {};
+    const config = (await this.load(key)) ?? {};
     // Allowed to fail--just fills in defaults
     validate(config);
 

src/plugins/history.js

@@ -36,7 +36,7 @@ class HistoryRepository {
   async getHistory(filter, pagination = {}) {
     const { HistoryEntry } = this.#uw.models;
 
-    const offset = pagination.offset || 0;
+    const offset = pagination.offset ?? 0;
     const limit = clamp(
       typeof pagination.limit === 'number' ? pagination.limit : DEFAULT_PAGE_SIZE,
       0,

src/plugins/playlists.js

@@ -75,8 +75,8 @@ function toPlaylistItem(itemProps, media) {
   const { start, end } = getStartEnd(itemProps, media);
   return {
     media,
-    artist: artist || media.artist,
-    title: title || media.title,
+    artist: artist ?? media.artist,
+    title: title ?? media.title,
     start,
     end,
   };

src/plugins/waitlist.js

@@ -215,7 +215,7 @@ class Waitlist {
     }
 
     const clampedPosition = clamp(position, 0, waitlist.length);
-    const beforeID = waitlist[clampedPosition] || null;
+    const beforeID = waitlist[clampedPosition] ?? null;
 
     if (beforeID === user.id) {
       // No change.

src/sockets/AuthedConnection.js

@@ -71,7 +71,7 @@ class AuthedConnection extends EventEmitter {
    * @private
    */
   onMessage(raw) {
-    const { command, data } = sjson.safeParse(raw) || {};
+    const { command, data } = sjson.safeParse(raw) ?? {};
     if (command) {
       this.emit('command', command, data);
     }

test/utils/createUwave.mjs

@@ -7,7 +7,7 @@ import uwave from 'u-wave-core';
 import deleteDatabase from './deleteDatabase.mjs';
 import testPlugin from './plugin.mjs';
 
-const DB_HOST = process.env.MONGODB_HOST || 'localhost';
+const DB_HOST = process.env.MONGODB_HOST ?? 'localhost';
 
 /**
  * Create a separate in-memory redis instance to run tests against.
@@ -46,7 +46,7 @@ async function createIsolatedRedis() {
  * This can be used to run tests on CI.
  */
 function createRedisConnection() {
-  const url = process.env.REDIS_URL || 'redis://localhost:6379';
+  const url = process.env.REDIS_URL ?? 'redis://localhost:6379';
 
   async function close() {
     const redis = new Redis(url);

tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "@tsconfig/node12/tsconfig.json",
+  "extends": "@tsconfig/node14/tsconfig.json",
   "compilerOptions": {
     "strict": true,
     "useUnknownInCatchVariables": false,