Actually support full URLs to videos, fixes #198

u-wave · Oct 17, 2022 · e7128b6 · e7128b6
1 parent 941b68b
commit e7128b6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -29,9 +29,11 @@ class Vimeo extends React.Component {
    * @private
    */
   getInitialOptions() {
+    const { video } = this.props;
+    const videoType = /^https?:/i.test(video) ? 'url' : 'id';
     /* eslint-disable react/destructuring-assignment */
     return {
-      id: this.props.video,
+      [videoType]: video,
       width: this.props.width,
       height: this.props.height,
       autopause: this.props.autopause,

diff --git a/test/test.js b/test/test.js
@@ -15,6 +15,12 @@ describe('Vimeo', () => {
     expect(onReady.calls[0].arguments[0]).toBe(playerMock);
   });
 
+  it('should use `url` prop for full vimeo URLs', async () => {
+    const { sdkMock } = render({ video: 'https://vimeo.com/179290396' });
+    expect(sdkMock).toHaveBeenCalled();
+    expect(sdkMock.calls[0].arguments[1]).toMatch({ url: 'https://vimeo.com/179290396' });
+  });
+
   it('should all onError when `ready()` fails', async () => {
     const onError = createSpy();
     const { sdkMock } = render({