Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more constructor options from props #178

Closed
wants to merge 3 commits into from
Closed

Allow more constructor options from props #178

wants to merge 3 commits into from

Conversation

thanhsonng
Copy link

This PR adds missing constructor options for Vimeo Player. The latest options are listed here: https://github.com/vimeo/player.js#embed-options

@goto-bus-stop goto-bus-stop self-requested a review April 6, 2022 09:20
goto-bus-stop added a commit that referenced this pull request Apr 6, 2022
@goto-bus-stop
Merge #178
30b48c3 
Squashed commit of the following:

commit 9562e50
Author: Renée Kooi <renee@kooi.me>
Date:   Wed Apr 6 11:24:57 2022 +0200

    update types

commit 977d20f
Author: Nguyễn Thanh Sơn <son@gotitapp.co>
Date:   Tue Jan 11 14:15:19 2022 +0700

    chore: Update README to reflect new props

commit 0a619d0
Author: Nguyễn Thanh Sơn <son@gotitapp.co>
Date:   Tue Jan 11 14:14:56 2022 +0700

    feat: Add default props

commit 326decf
Author: Nguyễn Thanh Sơn <son@gotitapp.co>
Date:   Tue Jan 11 11:56:42 2022 +0700

    feat: Add new constructor options from props
@goto-bus-stop
Copy link
Member

Merged in 30b48c3. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop Awaiting requested review from goto-bus-stop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thanhsonng @goto-bus-stop