Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time zone being reapplied to DTSTART_TZ and DTEND_TZ for recurrence events #125

Closed
doahn opened this issue Apr 14, 2017 · 4 comments
Closed

Time zone being reapplied to DTSTART_TZ and DTEND_TZ for recurrence events #125

doahn opened this issue Apr 14, 2017 · 4 comments
Labels
bug-normal

Comments

@doahn
Copy link

doahn commented Apr 14, 2017 •
edited by u01jmg3

  • PHP Version: 5.6.29

Description of the Issue:

Within ics file, there are two event on same time 12:00 KST. one is recurrence event. If i run index.php in example directory. different time is shown. pls check.

Steps to Reproduce:

ICal.ics
screenshot_2017-04-14-11-59-58
@u01jmg3 u01jmg3 self-assigned this Apr 14, 2017
@u01jmg3
Copy link
Owner

u01jmg3 commented Apr 14, 2017 •
edited

  • Thanks for logging this issue
  • There is indeed an issue whereby the timezone is being re-applied in recurrence events when DTSTART_TZ and DTEND_TZ are set.
    • A fix is coming and then you should use DTSTART_TZ and DTEND_TZ to retrieve 12:00 KST for both events
  • Relates to this commit: 668ea04

@u01jmg3 u01jmg3 added this to the v2.x.x milestone Apr 14, 2017
@u01jmg3 u01jmg3 changed the title time issue Timezone being reapplied to DTSTART_TZ and DTEND_TZ for recurrence events Apr 14, 2017
@u01jmg3 u01jmg3 changed the title Timezone being reapplied to DTSTART_TZ and DTEND_TZ for recurrence events Time zone being reapplied to DTSTART_TZ and DTEND_TZ for recurrence events Apr 15, 2017
u01jmg3 added a commit that referenced this issue Apr 15, 2017
@u01jmg3
RE: #125 - prevent time zone from being reapplied to DTSTART_TZ and…
a8b2066 
… `DTEND_TZ` for recurrence events

Simplify logic in `iCalDateToUnixTimestamp()` and `iCalDateWithTimeZone()`
@doahn
Copy link
Author

doahn commented Apr 15, 2017 •
edited by u01jmg3

Thanks.

First data of recurrence event (3_on) is corrected to 12:00 KST.

But other data is bad. 30 minute difference is happened.

@doahn doahn closed this as completed Apr 15, 2017
@doahn doahn reopened this Apr 15, 2017
@doahn
Copy link
Author

doahn commented Apr 15, 2017 •
edited by u01jmg3

Above comment is my mistake.

Issue is cleared.

I think eventFromInterval() and eventFromRange() functions should be modified also.

@u01jmg3
Copy link
Owner

u01jmg3 commented Apr 16, 2017

  • Thanks for getting back to me
  • I can confirm that eventsFromInterval() and eventsFromRange() are unaffected and require no changes

@u01jmg3 u01jmg3 closed this as completed Apr 16, 2017
@u01jmg3 u01jmg3 removed their assignment Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-normal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@u01jmg3 @doahn