Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate event for a single exception of a recurring event #154

Closed
vungyn opened this issue Aug 9, 2017 · 2 comments
Closed

Duplicate event for a single exception of a recurring event #154

vungyn opened this issue Aug 9, 2017 · 2 comments

Comments

@vungyn
Copy link

vungyn commented Aug 9, 2017

  • PHP Version: 5.6.23
  • PHP date.timezone: Europe/Berlin
  • ICS Parser Version: 2.0.6
  • Mac

Description of the Issue:

A duplicate event is showing for a single instance of a recurring event. Don't think it's related to #129. The only difference in the exception is added location detail. Time and date are the same.

Steps to Reproduce:

Example file from Google Calendar. On 13/08/2017 there should only be one event, however two events are returned.

test.ics

@u01jmg3 u01jmg3 self-assigned this Aug 9, 2017
@u01jmg3 u01jmg3 added this to the v2.x.x milestone Aug 10, 2017
@u01jmg3 u01jmg3 removed their assignment Aug 10, 2017
@vungyn
Copy link
Author

vungyn commented Aug 10, 2017

I don't think the fix is working correctly. Only the first (exception) instance should have the location, the next ones shouldn't as per the parent event.

That being said, the fix isn't working at all using my Google calendar link, it still shows the duplicate event.

Link removed.

@u01jmg3
Copy link
Owner

u01jmg3 commented Aug 10, 2017

I don't think the fix is working correctly. Only the first (exception) instance should have the location, the next ones shouldn't as per the parent event.

There is a limitation on the current implementation of the library whereby all recurrence events mirror the initial parent event. If you change that parent event then all subsequent (child) recurrence events will have those changes also. This is the scenario with your data. I agree it is not ideal nor entirely correct. I am pondering how to overcome this issue without having to make major changes to the parser (something which I do not currently have time to do.)

That being said, the fix isn't working at all using my Google calendar link, it still shows the duplicate event.

Mistake on my behalf now corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants