Clean-up parsing of timezone strings #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed timezone string This reduces repeated code and logic, as well as providing a way to easily parse timezone strings into something usable.
The validation function now only checks validity.
As Windows timezones are now handled without having to set the option.
To make it clear that it caches IANA timezone ids (and not CLDR or Windows)
u01jmg3
approved these changes
Jul 12, 2019
|
Great work - appreciate the clean-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably:
timezoneStringToDateTimeZone) that converts from any recognised timezone id string into a phpDateTimeZoneobject has been added.isValidCldrTimeZoneIdmethod now only checks for validity (like theisValidIanaTimeZoneIdmethod).isValidWindowsTimeZoneIdmethod has been added, checking against the list of known Windows timezones.isValidTimeZoneIdmethod has been adapted to use the above.