New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more YEARLY RRULE stanza options #271
Conversation
(Not to be confused with `getDaysOfMonthMatchingByDayRRule()`)
See the block comment for the reasons why it expands events as it does.
Not too sure about the method's name, however.
Thanks for this addition and I appreciate the rundown on how to interpret the spec. Happy for you to be named on the list of contributors if you want to be added :) |
@s0600204: can you comment on support for |
Sure.
The usage example in the README for |
The changes encapsulated within this PR add support for the
BYYEARDAY
,BYWEEKNO
andBYSETPOS
recurrence rule stanzas - and expands on the existingBYDAY
stanza support - when any of these are used with theYEARLY
frequency.Also included are relevant tests.
After this PR, only
BYMONTHDAY
[^1] and the time-based stanzas (BYHOUR
,BYMINUTE
,BYSECOND
) are not supported underYEARLY
.Refs. #11
[^1] - A future PR for this is in the works, but touches more than just
YEARLY
.