Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more YEARLY RRULE stanza options #271

Merged
merged 10 commits into from Nov 1, 2020
Merged

Conversation

s0600204
Copy link
Collaborator

@s0600204 s0600204 commented Nov 1, 2020

The changes encapsulated within this PR add support for the BYYEARDAY, BYWEEKNO and BYSETPOS recurrence rule stanzas - and expands on the existing BYDAY stanza support - when any of these are used with the YEARLY frequency.

Also included are relevant tests.

After this PR, only BYMONTHDAY[^1] and the time-based stanzas (BYHOUR, BYMINUTE, BYSECOND) are not supported under YEARLY.

Refs. #11


[^1] - A future PR for this is in the works, but touches more than just YEARLY.

@u01jmg3
Copy link
Owner

u01jmg3 commented Nov 1, 2020

Thanks for this addition and I appreciate the rundown on how to interpret the spec.

Happy for you to be named on the list of contributors if you want to be added :)

@u01jmg3 u01jmg3 merged commit 1f37490 into u01jmg3:master Nov 1, 2020
u01jmg3 referenced this pull request Nov 1, 2020
@u01jmg3
Copy link
Owner

u01jmg3 commented Nov 1, 2020

@s0600204: can you comment on support for BYWEEKDAY?

@s0600204
Copy link
Collaborator Author

s0600204 commented Nov 2, 2020

Happy for you to be named on the list of contributors if you want to be added :)

Sure.

Can you comment on support for BYWEEKDAY?

BYWEEKDAY isn't part of the RFC5545 spec, it appears to be an alias (of sorts) for BYDAY that jakubroztocil's rrule.js (and the python-dateutil python module it's based on) uses.

The usage example in the README for rrule.js shows a byweekday property being passed to the RRule constructor, and when the .toString() method is called on the created object, it has been translated to a BYDAY. Similarly, it appears that a BYDAY within the RRULE of an event is made available on the byweekday property when parsed by either of those parsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants