Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling methods made easy #12

Merged
merged 3 commits into from
May 21, 2020
Merged

Calling methods made easy #12

merged 3 commits into from
May 21, 2020

Conversation

prostomarkeloff
Copy link
Contributor

I have improved call_method method and generated functions that they accept generic parameter T in that response will be serialized. Also I have updated example.

awaitlink
awaitlink requested changes May 20, 2020
View reviewed changes
Copy link
Owner

@awaitlink awaitlink left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine serde_json is not needed at all in the examples then?

@prostomarkeloff
Copy link
Contributor Author

I imagine serde_json is not needed at all in the examples then?

Yes, it is. I have fixed it.

@awaitlink
Copy link
Owner

You'd probably want to remove it from README.md lines 31-36 and line 74 as well 😉

@prostomarkeloff
Copy link
Contributor Author

You'd probably want to remove it from README.md lines 31-36 and line 74 as well wink

Ok, it's done! :)

awaitlink
awaitlink approved these changes May 21, 2020
View reviewed changes
Copy link
Owner

@awaitlink awaitlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awaitlink awaitlink merged commit a002ec3 into awaitlink:master May 21, 2020
@awaitlink awaitlink added the api This applies to the `rvk` crate (or to the `api`/`error` modules before the crate split) label Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaitlink awaitlink awaitlink approved these changes

Assignees
No one assigned
Labels
api This applies to the `rvk` crate (or to the `api`/`error` modules before the crate split)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prostomarkeloff @awaitlink