Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Selected domains no longer appears in the popup #1096

Closed
ghost opened this issue Mar 26, 2015 · 17 comments
Closed

Selected domains no longer appears in the popup #1096

ghost opened this issue Mar 26, 2015 · 17 comments

Comments

@ghost
Copy link

ghost commented Mar 26, 2015

The domain I have selected (allow, block, noop) no longer appear in the popup after I refreshed the page.
For example, for github.com, here's the rules I have:

github.com avatars0.githubusercontent.com * noop
github.com avatars1.githubusercontent.com * noop
github.com avatars2.githubusercontent.com * noop
github.com avatars3.githubusercontent.com * noop
github.com camo.githubusercontent.com * noop
github.com raw.githubusercontent.com * noop

I can't see any of these rules in the popup, the only domains I see are github.com and google-analytics.com.

Version: 0.9.2.3-dev.1 (same with 0.9.2.0) (Default lists + Default deny)
Browser: Opera 30.0.1812.0 (dev)
OS: Windows 7 64-bit
Other extensions: BetterTTV, Download Chrome Extension, F.B. Purity for Facebook, Google Dictionary (by Google), Imagus, LastPass, Reddit Enhancement Suite

@gorhill
Copy link
Contributor

gorhill commented Mar 26, 2015

The popup will be populated only with domains/hostnames for which network requests occurred. For example, if no network requests occurred for avatars1.githubusercontent.com, it won't appear in the popup.

@ghost
Copy link
Author

ghost commented Mar 26, 2015

On this page, I'm supposed to see at least avatars*.githubusercontent.com and that's not the case.

Another example, same problem with Twitter, twitter need twimg.com for working properly, so I have added the rule twitter.com twimg.com * noop and I can't see the domain in the popup either.

@gorhill
Copy link
Contributor

gorhill commented Mar 26, 2015

On this page, I'm supposed to see at least avatars*.githubusercontent.com and that's not the case

I tried Twitter and twimg.com was in the popup -- but then there were images in the stream. Aside the expected behavior I mention above, I cannot reproduce what you mention.

I tried github.com and I could see very well all avatar*.githubusercontent.com.

You need to give me a case I can reproduce.

Check that network requests for images are not blocked before they reach the uBlock. Also, check whether these network requests are not made in the behind-the-scene scope. I see you are using Opera 30, which is a dev version I believe, so see if you have the same issue with Opera 28.

@ghost
Copy link
Author

ghost commented Mar 26, 2015

I have made a backup, restore from default settings then restore from my backup, nothing more, and now everything looks fine. No idea what happened..

Edit: Ok, so the problem is still here when I enable FRA: EasyList Liste FR, no problem without this list.

@gorhill
Copy link
Contributor

gorhill commented Mar 26, 2015

Look in the request log, on twitter.com, if there are images in the twitter stream, you should see requests to twimg.com. Blocked or not, all network requests are reported in the popup. If they are not reported it's because they didn't reach uBlock.

@ghost
Copy link
Author

ghost commented Mar 26, 2015

Without EasyList FR, I can see request to twimg.com, with this list enabled, no request from twimg.

@gorhill
Copy link
Contributor

gorhill commented Mar 26, 2015

With or without EasyList FR, I can't reproduce.

@gorhill
Copy link
Contributor

gorhill commented Mar 26, 2015

I will need a screenshot of the request log after forcing a refresh of twitter.com.:

  • Open request log for twitter.com.
  • Refresh twiiter.com.
  • I want to see the output of the request log.

@ghost
Copy link
Author

ghost commented Mar 26, 2015

The list need to be up-to-date, no problem with the outdated list. I will take screenshot ASAP.

@ghost
Copy link
Author

ghost commented Mar 26, 2015

Here's the screenshot with List FR enabled: https://i.imgur.com/JH2iZy0.jpg

@gorhill
Copy link
Contributor

gorhill commented Mar 26, 2015

Can I have the URL also? Transcribing from the image would be tedious.

@ghost
Copy link
Author

ghost commented Mar 26, 2015

@gorhill
Copy link
Contributor

gorhill commented Mar 26, 2015

Thanks. I can't exactly reproduce but I definitely found a problem.

@gorhill
Copy link
Contributor

gorhill commented Mar 26, 2015

There is a bad filter in EasyList FR, ||^$third-party: I can't even make sense of that filter. The || is to anchor to somewhere in the hostname. ^ is a separator. So this makes no sense. The end result is that all 3rd-party requests are blocked.

Now the reason why uBlock does not report twimg.com is because the above filter, unexpected, causes an exception to be thrown. So I fixed this, and I will push the fix asap, but still, I don't know why that filter exists, it makes no sense.

gorhill added a commit that referenced this issue Mar 26, 2015
@gorhill
Copy link
Contributor

gorhill commented Mar 26, 2015

Fixed with d83ade9.

@ghost
Copy link
Author

ghost commented Mar 26, 2015

Glad you fixed it, thanks for your time. ;)

gorhill added a commit that referenced this issue Mar 26, 2015
@gorhill gorhill closed this as completed Mar 26, 2015
@smed79
Copy link

smed79 commented Mar 31, 2015

Hi;
mistakenly added (maybe i am tired), really sorry for this false positive.
Fixed: https://hg.adblockplus.org/listefr/rev/db2fe3afe901#l1.12

Please report any issue on our forum: https://forums.lanik.us/viewforum.php?f=91 (not need registration ).

Med.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants