Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

CSS error (typo?) in dashboard.css #1320

Closed
AlexVallat opened this issue Apr 25, 2015 · 3 comments
Closed

CSS error (typo?) in dashboard.css #1320

AlexVallat opened this issue Apr 25, 2015 · 3 comments

Comments

@AlexVallat
Copy link
Contributor

Originally reported in #1315 (comment) but not related to that branch.

looks like dashboard.css ought to be color: inherit; not inherited?

Possibly something wrong with about.css too? My css-fu is not strong enough to be sure about that, though - I'm not sure exactly what's going on there.

@gorhill
Copy link
Contributor

gorhill commented Apr 25, 2015

Yes, inherited is wrong, it's supposed to be inherit.

gorhill added a commit to gorhill/uBlock that referenced this issue Apr 25, 2015
@chrisaljoudi
Copy link
Contributor

Yes, that was wrong. With about.css, that seemingly-odd "name" should get replaced with left/right/etc. at compile-time.

@AlexVallat
Copy link
Contributor Author

@chrisaljoudi Do you mean that this is something that should be added to the compile-time scripts, or that it is something they are supposed to be doing already but are not? Looking inside the released .xpi, it isn't happening at the moment. Not that the loss of a small amount of padding is a big deal, of course.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants