Power button should not be green

[gorhill]

Green may lead to confusion, especially when the dynamic filtering pane is opened.

In the dynamic filtering pane, green means "do not block network requests". So having the master switch colored green leads to confusion. Coloring the master switch black solves this: it's unambiguous.

[chrisaljoudi]

@gorhill I think you're absolutely right that green might be confusing, however, I'm worried black would be just as confusing in some cases.

Black, as a color, is typically "off" in all various contexts users are familiar with. It's almost never used to imply that something is activated. Then you have the translucent version of the button that's lighter (when the site is whitelisted):

In my own, humble opinion, that's not visually intuitive which one is which.

---

As an alternate idea, perhaps something along these lines would work? (Quite different):

[Mikey1993]

@chrisaljoudi - I am backing you. Black is OFF universally no matter which varient is used, so you can expect more issues like #746 popping.

I think adding a "Whitelisted Page" / "This Page Is Whitelisted" text in bold and bright green color below the power button can help a lot better than switching to the black color.

[chrisaljoudi]

@Mikey1993 👍

@gorhill on another note, black does look a bit... stark/dead. It doesn't feel like µBlock is "alive" if you know what I mean.

[gorhill]

I don't like uBlock's logo to the point of using it as a gigantic button. I am more fond of sober-looking UI, that get the job done instead of trying to be the center of attention.

[gorhill]

How about blue then? Green and red are no go. There are a lot of blue LED power buttons nowadays.

[Mikey1993]

I still don't think the color should be changed, because as you have stated many times before, people who use the Dynamic Filtering consider themselves as advanced users, who should read the wiki.
If the wiki says that clikcing the big green power button does X, it should do X.

This is why I think there is only need for an enchancement to alert the user about the state of the page by some text below the power button in the relative color to the state of the current page (no need to be aware of whole site whitelists? I think this is a benefit programmably, but I could be wrong in my assumptions), and not change the colors for the whole user base of uBlock, who can get confused a lot more than advanced users who previously enabled Dynamic Filtering and seeing red/green/gray a lot in their popup.

[chrisaljoudi]

@gorhill as a fallback, I think blue is fine — deepskyblue is a nice blue.

[gorhill]

I went with 450nm blue, the wavelength emitted by blue LED (see similarity with picture). An online wavelength to RGB converter was used. This remove subjectivity from the process of choosing a color.

[chrisaljoudi]

@gorhill that looks great — I hadn't seen the commit when I posted my previous comment. The blue you choose works well.

Sorry if it appeared like I was second-questioning the blue choice. :P

[tjharman]

Excellent choice of colour, the new button looks great.