Skip to content

Commit

Permalink
https://github.com/NanoMeow/QuickReports/issues/2788
Browse files Browse the repository at this point in the history
  • Loading branch information
@mapx-
mapx- committed Jan 21, 2020
1 parent 29d6109 commit 08958ca
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions filters/filters.txt
View file
Expand Up @@ -22301,9 +22301,6 @@ softdescargas.com##+js(aopr, scriptwz_url)
! https://github.com/NanoMeow/QuickReports/issues/2357
cracking-dz.com##+js(aeld, load, 0x)

! https://www.reddit.com/r/uBlockOrigin/comments/e0xiaj/i_cant_get_rid_of_the_popup_warning_me_about_ad/
||fundingchoicesmessages.google.com^$xhr,3p

! https://github.com/NanoMeow/QuickReports/issues/2363
voipreview.org##+js(set, adblockEnabled, false)

Expand Down Expand Up @@ -23457,3 +23454,6 @@ streamz.cc##+js(window.open-defuser)

! iptv-freelinksdz .com anti adb
*$script,redirect-rule=noopjs,domain=iptv-freelinksdz.com

! https://github.com/NanoMeow/QuickReports/issues/2788
||fundingchoicesmessages.google.com^$3p

24 comments on commit 08958ca

@ryanbr
Copy link
Contributor

@ryanbr ryanbr commented on 08958ca Jan 25, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is causing anti-adblock messages. Can this be reverted? See: https://forums.lanik.us/viewtopic.php?f=62&t=44195&p=152501 Was re-reported again https://community.brave.com/t/message-blockers-on-websites-how-to-remove-it/102494

@okiehsch
Copy link
Contributor

@okiehsch okiehsch commented on 08958ca Jan 25, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a valid filter in my opinion.
You can badfilter it in brave but be aware that you will have to deal with anti adblock messages on many sites if you do, for example.
https://www.richmond.com/
without that filter.
image

And https://www.themanual.com/travel/great-blasket-island-ireland-keeper-job/
image
etc.

The "interfering" message that is caused by the filter is fixed by adding
example.com##+js(nostif, removeChild, 100) or @@||example.com^$generichide.
marca.com is already fixed in EasyListSpanish. I will fix elmundo.es in uBO-filters.

@okiehsch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

478f8ea

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "interfering" message that is caused by the filter is fixed by adding example.com##+js(nostif, removeChild, 100)

Doesn't ##+js(acis, googlefc) work ? Because that's what I suggest everywhere when google funding notices appear.

@okiehsch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't ##+js(acis, googlefc) work ?

No.
image

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is contributor.google.com also blocked ?

@okiehsch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a rhetorical question?
Is it blocked on your end with a default setup?

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's a question but not related to the previous one, it is blocked but with my own blocking filter.

@okiehsch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contributor.google.com is used for different messages - including opt-out messages to comply with GDPR - not only anti-adblock ones, so blocking it completey could lead to site breakage and is out of scope of uBO-filters anyway in my opinion.
It is blocked in the enhanced tracking list.

@uBlock-user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked because I wanted to remove that domain from my list, but I can't unless it's blocked in uBO Filters, guess I will have to keep it then.

so blocking it completey could lead to site breakage

Has breakage occurred anywhere ?

@okiehsch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not blocked, so I don't know but blocking GDPR related stuff has lead to broken videos on numerous occasions.
Note that the breakage only occurs with a EU IP most of the time, so testing is also not straightforward.

@ryanbr
Copy link
Contributor

@ryanbr ryanbr commented on 08958ca Jan 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you block contributor.google.com outright, it'll create the the same Anti-adblock bottom div. We had it in EP and removed it, was just being used as an Adblock check.

@okiehsch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanbr I won't block it and on the issue you raised adding

||fundingchoicesmessages.google.com^$xhr,3p
||fundingchoicesmessages.google.com^$3p,badfilter

won't solve the anti adblock issue.
image

which is presumably why mapx- changed the filter with this commit,
Blocking only
||fundingchoicesmessages.google.com^$xhr,3p
achieves nothing as far as I can see.

@ryanbr
Copy link
Contributor

@ryanbr ryanbr commented on 08958ca Jan 26, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the same thing on foxnews/foxbusiness. I'm refering to the bottom yellow bar, other anti-adblocks won't be stopped.

@okiehsch
Copy link
Contributor

@okiehsch okiehsch commented on 08958ca Jan 26, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the same thing on foxnews/foxbusiness. I'm refering to the bottom yellow bar.

The yellow bar at foxnews/foxbusiness is fixed in uBO-filters.

Without uBO-filters blocking only
||fundingchoicesmessages.google.com^$xhr,3p
will fix the yellow "interference" bar but why are you blocking the xhr requests? I don't see the point.
There is no "Please allow ads" adblock message that would be fixed by blocking those xhr-requests at foxnews/foxbusiness.

To be clear I am not saying that you should not badfilter ||fundingchoicesmessages.google.com^$3p in your brave list.
I am just saying that you then will have to deal with the anti adblock messages I highlighted above on a site by site basis.

@ryanbr
Copy link
Contributor

@ryanbr ryanbr commented on 08958ca Jan 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fundingchoices is basically a anti-adblock google check. If any site deploying it fundingchoices will get anti-adblock message. If the scope is limited to only $xml requests its fine, no warnings given.

2 examples:
https://secure.fanboy.co.nz/gif/elmundo-google-choice.gif

Foxnews (whitelist needed to show the same issues)
https://secure.fanboy.co.nz/gif/fox-google-choice.gif

@okiehsch
Copy link
Contributor

@okiehsch okiehsch commented on 08958ca Jan 26, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fundingchoices is basically a anti-adblock google check.

I agree that on some sites blocking it will result in the yellow bar without any noticable benefit.
On sites that use the hard anti adblock google contributor wall the benefit of blocking it is that it will fix the wall issue and one can continue to use the site without disabling ones blocking extension.

These sites have the anti adblock wall issue, on some a US IP is necessary to reproduce and there will be more.
The sites will need an extra filter in the brave list after the badfilter.

dailyprogress.com,dothaneagle.com,godanriver.com,greensboro.com,heraldcourier.com,hickoryrecord.com,jg-tc.com,journalnow.com,kearneyhub.com,kenoshanews.com,madison.com,magicvalley.com,martinsvillebulletin.com,mcdowellnews.com,morganton.com,newsadvance.com,nonpareilonline.com,nptelegraph.com,nwitimes.com,oanow.com,omaha.com,pressofatlanticcity.com,richmond.com,roanoke.com,scnow.com,snopes.com,starexponent.com,starherald.com,statesville.com,theeagle.com,theindependent.com,themanual.com,trib.com,tulsaworld.com,wacotrib.com,yorknewstimes.com

Blocking only the xhr-requests won't fix that issue.
image

That is why we block all fundingchoices requests and deal with the soft, i.e. one can continue to use the site, yellow "interference" warning and disable that warning on a site by site basis.

@ryanbr
Copy link
Contributor

@ryanbr ryanbr commented on 08958ca Jan 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please @okiehsch pasting the same message as before, I'm only refering to the Bottom Yellow anti-adblock message. See my gif's. My suggestion won't fix other Anti-adblock checks.

Let me re-state:

  1. If you block ||fundingchoicesmessages.google.com^$third-party. You will get a bottom Yellow warning anti-adblock on any site deploying fundingchoices.
  2. If you don't block it, you won't this message. (or just limit it to $xml block only).

This won't fix other anti-adblock messages being deployed.

Can I get some input by @gorhill

@okiehsch
Copy link
Contributor

@okiehsch okiehsch commented on 08958ca Jan 26, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me re-state
If you block ||fundingchoicesmessages.google.com^$third-party. You will get a bottom Yellow warning anti-adblock on any site deploying fundingchoices.
If you don't block it, you won't this message. (or just limit it to $xml block only).

I agree 100% with that statement.

I really don't understand the issue here, just badfilter it if you disagree, I only wanted to highlight that your filter
||fundingchoicesmessages.google.com^$xhr,3p
does not fix the other anti-adblock message on the sites I mentioned, which is the reason I am against changing the current filter in uBO-filters, that's all.

@ryanbr
Copy link
Contributor

@ryanbr ryanbr commented on 08958ca Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is history behind this block. We had this filter in Easyprivacy a while ago, It worked initially (14 Sept) easylist/easylist@44b3c70 without issue. Google decided to use it as a test for adblock scripts (14th Nov): easylist/easylist@a911ebb Which is why it was removed. Seemed pointless to block domain, with its only intention to detect and spit out warning messages.

Maybe related to warnings:
! https://hg.adblockplus.org/easylist/rev/46138acfc93b
||contributor.google.com^*/loader.js$third-party

@okiehsch
Copy link
Contributor

@okiehsch okiehsch commented on 08958ca Jan 27, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seemed pointless to block domain, with its only intention to detect and spit out warning messages.

It is not the only thing that script does, it varies from site to site and it seems from time to time.
I just tested foxbusiness.com one more time and if I allow that script I see

image

I tested the same site yesterday and I did not get that message then.
I tested both times with a US IP.

@ryanbr
Copy link
Contributor

@ryanbr ryanbr commented on 08958ca Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any anti-adblock messages on the foxnews/foxbusiness. (from a US ip, no uBlock filters) Even if I whitelist global.fncstatic.com/static/isa/app/lib/google-funding-choices.js

@gwarser
Copy link
Member

@gwarser gwarser commented on 08958ca Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.reddit.com/r/uBlockOrigin/comments/odbviy/svg_images_doesnt_load_when_ublock_enabled/

@okiehsch
Copy link
Contributor

@okiehsch okiehsch commented on 08958ca Jul 5, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce.
ea0e2dc

Please sign in to comment.