Scriptlets don't work in uBO

[dportvine]

AdguardTeam/AdguardFilters#179220

I can't skip pre-roll with uBO.

Video

Video_2024-05-26_174318.mp4

https://suspilne.media/culture/schedule/tv/

cosmonova-broadcast.tv#%#//scriptlet('trusted-replace-node-text', 'script', 'app.init', '"skip":0', '"skip":-1')
cosmonova-broadcast.tv#%#//scriptlet('trusted-click-element', '#preroll-skip-button', '', '2000')

[garry-ut99]

https://suspilne.media/culture/schedule/tv/

After clicking play button, there is no video anymore, (or maybe geo-locked), only some message appears (same happens with uBlock disabled):

SPOILER

[dportvine]

What i see. Try Ukraine VPN.

Video

Video_2024-05-26_203256.mp4

[garry-ut99]

If you provide a free proxy which works with cosmonova-broadcast.tv, then I can try, otherwise I'm not interested wasting my time in trying 10000 free proxies none of which are working with that site.

[dportvine]

Works with Urban VPN proxy & i used Disable WebRTC.

[garry-ut99]

Ok, works, I did tests and replied at the bottom.

[D4niloMR]

Try:

cosmonova-broadcast.tv##+js(rpnt, script, "skip":0, "skip":-1)
cosmonova-broadcast.tv##+js(trusted-click-element, #preroll-skip-button.enabled, , 2000)

and maybe ||analytics.cosmonova.net^

[Yuki2718]

and maybe ||analytics.cosmonova.net^

easylist/easylist@0cdd73e

[garry-ut99]

dportvine : I can't skip pre-roll with uBO.

AG and uBO trusted-replace-node-text differ in number of required parameters:

• AG requires 4 parameters LINK 1
• uBO requires 3 parameters LINK 2

the second parameter in AG ('app.init' in the current case) needs to be skipped/removed in uBO. (unless your or anybody else's expectations are that uBO should remove it automatically, when enocuntering a filter written in AG syntax, then it could be considered uBO's scriptlet compatibility bug.)

Besides, it's a similiar case like in the previous question: uBlockOrigin/uBlock-issues#2881 (comment)

[gorhill]

it could be considered uBO's scriptlet compatibility bug

uBO's trusted-replace-node-text came out first. That second parameter in AG's version correspond to uBO's vararg condition, pattern.

[garry-ut99]

uBO's trusted-replace-node-text came out first.

Ok, if that means incompatibility is on AG's side, let it be so.
By the way, just providing some info regarding the dates:

• in uBO implemented 21.05.2023 gorhill/uBlock@4187633
• in AG implemented 06.06.2023 AdguardTeam/Scriptlets@e626cf2

That second parameter in AG's version correspond to uBO's vararg condition, pattern.

Yes, I did know about condition, pattern, somehow I just completely forgot about it, in such case I correct myself:
textMatch ('app.init') should not be removed/skipped when converting from AG to uBO, as it corresponds to condition, pattern in uBO, the proper conversion will be:
cosmonova-broadcast.tv##+js(rpnt, script, "skip":0, "skip":-1, condition, app.init)

It seems uBO and AG had different approach regarding that parameter, as in uBO it's as optional, and in AG it's as required, it seems it's the different approach what is the reason of the incompatibility.

[garry-ut99]

02eebbd

Sometimes works (most of time), but sometimes not (currrently tested in Firefox only):

• when does work (in-video ads removed) the both scriptlets are displayed in the logger:
  • the text scriptlet says text replaced
  • the click scriptlet says button clicked
• when doesn't work (and in-video ad appear):
  • there is no rpnt displayed in the logger at all, like it didn't execute
  • the click scriptlet does appear but is waiting for a button and times out like the dom button targeted by it never existed, maybe the button didn't appear because rpnt failed

Besides, in AG doesn't work at all for me, like mentioned in: AdguardTeam/AdguardFilters#179220 (comment)

[D4niloMR]

Can you add that to Annoyance? This is self-promotion.

@dportvine is it always self-promotion? AdGuard added in the regional list, maybe we can add to uBlock filters.

[dportvine]

is it always self-promotion?

Yes, this is one company. Such self-promotion is simply very annoying. You can also add it to uBlock filters

[D4niloMR]

02eebbd