Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exxen.com - AdGuard Base Filter Brakes Website Only with uBlock Origin #11945

Closed
5 of 6 tasks
bkrucarci opened this issue Feb 27, 2022 · 23 comments
Closed
5 of 6 tasks

exxen.com - AdGuard Base Filter Brakes Website Only with uBlock Origin #11945

bkrucarci opened this issue Feb 27, 2022 · 23 comments

Comments

@bkrucarci
Copy link

bkrucarci commented Feb 27, 2022

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

URL(s) where the issue occurs

https://www.exxen.com/tr/watch-serie/ilginc-bazi-olaylar-10-bolum/39139

Describe the issue

You already see my filters. With the same filters enabled on AdGuard extension website works OK.
With the same filters enabled on uBlock Origin, the video player does not play!

I checked the blocked contents one by one to play video and then I discovered that AdGuard base filter rule causes the problem on the video player.

The rule does NOT brake the video player with AdGuard extension.
The rule does brake the video player with uBlock Origin.

Related rule which breaks the video player in AdGuard Base Filter.
exxen.com##+js(nofab)

After I added the fix rule to my filters then video plays
exxen.com#@#+js(nofab)

Screenshot(s)

Screenshot_014542_2022-02-28
Screenshot_014510_2022-02-28

Notes

No response

Configuration

uBlock Origin: 1.41.8
Firefox: 97
filterset (summary): 
  network: 90050
  cosmetic: 137243
  scriptlet: 33540
  html: 632
listset (total-discarded, last updated): 
  removed: 
    easyprivacy: null
    urlhaus-1: null
    plowe-0: null
  added: 
    https://raw.githubusercontent.com/DandelionSprout/adfilt/master/BrowseWebsitesWithoutLoggingIn.txt: 290-0, 6m
    https://raw.githubusercontent.com/DandelionSprout/adfilt/master/Sensitive%20lists/AntiAstrologyList.txt: 366-0, 6m
    https://raw.githubusercontent.com/DandelionSprout/adfilt/master/Sensitive%20lists/AntiPrayerTimesList.txt: 106-0, 6m
    adguard-generic: 62005-4599, 3m
    adguard-spyware: 25699-945, 7m
    adguard-spyware-url: 491-3, 7m
    adguard-annoyance: 50390-1520, 7m
    adguard-social: 15922-20, 7m
    fanboy-thirdparty_social: 69-0, 7m
    ublock-annoyances: 4419-42, 6m
    TUR-0: 8569-78, 7m
  default: 
    user-filters: 0-0, never
    ublock-filters: 30888-44, 5m
    ublock-badware: 3903-3, 5m
    ublock-privacy: 208-0, 5m
    ublock-abuse: 72-0, 5m
    ublock-unbreak: 1729-0, 5m
    easylist: 63978-289, 5m
filterset (user): [empty]
modifiedUserSettings: 
  advancedUserEnabled: true
  uiAccentCustom0: #8080ff
modifiedHiddenSettings: [none]
supportStats: 
  allReadyAfter: 833 ms (selfie)
  maxAssetCacheWait: 869 ms
@iam-py-test
Copy link
Contributor

iam-py-test commented Feb 28, 2022

Issue specific to non-default settings.
Also, an account is required
Probably it breaks only in uBo because there are different filters enabled in uBo than in AG and because AG supports different types of scriptlets
Also, running uBo alongside AdGuard will always cause problems. Pick one (remove the other) and stick with the default settings

  • uBO with default lists/settings

This is not valid. Please read over the checkboxes before checking them, uAssets is only for issues with default config or uBlock Annoyances.

@bkrucarci
Copy link
Author

Issue specific to non-default settings. Also, an account is required Probably it breaks only in uBo because there are different filters enabled in uBo than in AG and because AG supports different types of scriptlets Also, running uBo alongside AdGuard will always cause problems. Pick one (remove the other) and stick with the default settings

  • uBO with default lists/settings

This is not valid. Please read over the checkboxes before checking them, uAssets is only for issues with default config or uBlock Annoyances.

Ok,, thanks. So it is useless for me to reporting these sites. I always use custom settings with uBO.
Anyway, thanks for help.

@iam-py-test
Copy link
Contributor

@bkrucarci the uAssets repo is just for issues with uBo default settings. You can use the Reddit uBlockOrigin area or other GH repos dedicated to general uBo questions/support (i.e. DandelionSprout/adfilt#63)
I do not make the rules here, I am just a person who helps around

@bkrucarci
Copy link
Author

@bkrucarci the uAssets repo is just for issues with uBo default settings. You can use the Reddit uBlockOrigin area or other GH repos dedicated to general uBo questions/support (i.e. DandelionSprout/adfilt#63) I do not make the rules here, I am just a person who helps around

I see you mate. You helped me before 👍🏻 Thanks for being around.
I can solve problems on my own. Just trying to solve this problem for the others users maybe because if I report it to AdGuard, they will reply "Use AdGuard ext. instead?" but problem is different.

@bkrucarci
Copy link
Author

bkrucarci commented Mar 3, 2022

@iam-py-test Hi,
Can we add the rule to uBlock - Unbreak list? The website is one of the most visited streaming platform in Turkey
exxen.com#@#+js(nofab)
I checked uBlock - Unbreak list and you guys added some unbreak rules in this filter to fix Peter Lowe's List fix for example.

AdGuard filter devs said here

As far as I understand, it works fine with AdGuard, but doesn't with uBlock. If so, I would prefer to exclude this rule from filters for uBlock than remove it.

What do you think about it?

@bkrucarci bkrucarci reopened this Mar 3, 2022
@AdamWr
Copy link

AdamWr commented Mar 3, 2022

I suppose, that this issue may be related to this - AdguardTeam/Scriptlets#104
I don't have account to check it, but it looks like that on exxen.com (https://wasset.exxen.com/js/lib/rmp.min.js) options.set/options.get is used.
So, maybe it could be fixed in nofab uBlock script?

@okiehsch
Copy link
Contributor

okiehsch commented Mar 3, 2022

@bkrucarci
If we add exxen.com#@#+js(nofab) you can still use the site without issue?

@bkrucarci
Copy link
Author

@bkrucarci If we add exxen.com#@#+js(nofab) you can still use the site without issue?

When I add this rule the video player works normally. If you add this rule to related uBlock filter it's gonna solve my problem.

@uBlock-user
Copy link
Contributor

We don't add fixes for non-default lists.

@okiehsch
Copy link
Contributor

okiehsch commented Mar 3, 2022

Ok. I asked because usually +js(nofab) has been added to fix some anti adblock message that blocks access to a site.

@uBlock-user Adguard Turkish is a default regional list for users with a turkish locale.
Adguard says they would prefer we add an exception because the problem does not occur for Adguard users.

@okiehsch okiehsch reopened this Mar 3, 2022
@uBlock-user
Copy link
Contributor

uBlock-user commented Mar 3, 2022

@okiehsch is the filter present in AdGuard Turkish or AdGuard Base ?


Adguard Turkish is a default regional list for users with a turkish locale.

That filter is not present in AdGuard Turkish.

@okiehsch
Copy link
Contributor

okiehsch commented Mar 3, 2022

Ups, my bad.
@AdamWr why is it in Adguard Base? It's a turkish site.

@bkrucarci
Copy link
Author

@uBlock-user @okiehsch it's in AdGuard Base filter

@uBlock-user
Copy link
Contributor

Yep, you mentioned AdGuard Base in the issue title too.

@okiehsch
Copy link
Contributor

okiehsch commented Mar 3, 2022

@bkrucarci yes, sorry I got confused.
As @uBlock-user says we don't add filters for issues with non default lists.

@bkrucarci
Copy link
Author

@uBlock-user @okiehsch ,
if @AdamWr move the rule to AdGuard Turkish filter? Then, do you need to fix the problem?

@uBlock-user
Copy link
Contributor

@bkrucarci Add the exception filter to my Filters.

@okiehsch
Copy link
Contributor

okiehsch commented Mar 3, 2022

if @AdamWr move the rule to AdGuard Turkish filter? Then, do you need to fix the problem?

Yes.
Right now the "normal" turkish uBO user has no issues on exxen, that would change if the filter got moved to AdGuard Turkish.

@uBlock-user
Copy link
Contributor

if @AdamWr move the rule

Will he do that ?

@bkrucarci
Copy link
Author

@bkrucarci Add the exception filter to my Filters.

Already did it. I'm trying to solve it without exceptions in my filter :)

if @AdamWr move the rule

Will he do that ?

I hope he can do it, because uBO can be a "tool" for using AdGuard filters without AdGuard extension.
I'm such user.

@AdamWr
Copy link

AdamWr commented Mar 3, 2022

For popular anti-adblock scripts (like blockadblock, fuckadblock, antiblock.org and other similar) we are adding rules to Base filter.
I didn't say that I will not fix it, I just don't want to remove this rule for AdGuard users, because it's still a valid rule. I will just add a "hint" to exclude it from rules for uBlock.

@uBlock-user
Copy link
Contributor

because uBO can be a "tool" for using AdGuard filters

General advise is stick to defaults lists. By enabling non-default lists, you also risk site breakage and then it becomes user's responsibility to tend to such issues like this one.

@bkrucarci
Copy link
Author

@uBlock-user @AdamWr Thank you for your helps. I'll keep the rule in my filters.

AdamWr added a commit to AdguardTeam/AdguardFilters that referenced this issue Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants