Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

money.pl: detection #12214

Comments

@Infiexe
Copy link

Infiexe commented Mar 13, 2022

Prerequisites

  • I read and understood the policy as to what is a valid filter issue
  • I verified that the issue has not already been reported (use this button to find out)
  • I forced an update of my filter lists (how to do this: click "Purge all caches", then click "Update now")
  • I did not remove any of the default filter lists, or I verified that the issue is not caused by removing any of the default lists
  • I did not enable external filter lists, or I verified that the issue still occurs without enabling external filter lists
  • I do not have custom filters/rules, or I verified that the issue still occurs without custom filters/rules
  • I am not using another content blocker along uBO (also mind browser built-in blockers)
  • I did not answer truthfully to all the above checkpoints

URL address of the web page

https://www.money.pl/

Category

detection

Describe the issue

unusable with ublock origin on

Screenshot(s)

Screenshot(s)

obraz

Configuration

uBlock Origin: 1.41.8
Firefox: 98
filterset (summary): 
  network: 81641
  cosmetic: 48862
  scriptlet: 16671
  html: 635
listset (total-discarded, last updated): 
  default: 
    user-filters: 0-0, never
    ublock-filters: 30836-70, 1h.19m
    ublock-badware: 3971-3, 1h.17m
    ublock-privacy: 204-0, 1h.16m
    ublock-abuse: 72-0, 1h.15m
    ublock-unbreak: 1737-0, 1h.14m
    easylist: 64610-619, 1h.13m
    easyprivacy: 26669-570, 1h.12m
    urlhaus-1: 8437-0, 1h.11m
    plowe-0: 3674-2, 6d.20h.54m
    POL-0: 7784-25, 1h.10m
    POL-2: 1276-12, 1d.17h.9m
filterset (user): [empty]
trustedset: 
  added: [array of 6 redacted]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
  allReadyAfter: 146 ms (selfie)
  maxAssetCacheWait: 136 ms
popupPanel: 
  blocked: 40
  blockedDetails: 
    3lift.com: 1
    adform.net: 1
    adnxs.com: 3
    amazon-adsystem.com: 1
    casalemedia.com: 1
    connectad.io: 2
    creativecdn.com: 2
    criteo.com: 1
    criteo.net: 4
    facebook.net: 1
    gemius.pl: 1
    google-analytics.com: 1
    googletagmanager.com: 1
    googletagservices.com: 1
    id5-sync.com: 2
    indexww.com: 1
    openx.net: 2
    pubmatic.com: 3
    rubiconproject.com: 2
    sharethrough.com: 4
    smartadserver.com: 4
    wp.pl: 1
@krystian3w
Copy link
Contributor

WP.pl company update this pop-up in 48 h after commit for uBO but no follow that fast AdamWr fixes added to AdGuard Base.

@ghost
Copy link

ghost commented Mar 13, 2022

WP.pl company update this pop-up in 48 h after commit for uBO but no follow that fast AdamWr fixes added to AdGuard Base.

Wouldn't it be best if this was addressed in a regional list then?

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022

IMO out of scope for Olegwukr aka MajkiIT knowledge about JavaScript also we have gorhill privileges to omit fix WP.pl company due too fastly recover ads/anti-adblock by this company (this was wrote on reddit or github older issue).

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Mar 13, 2022

update ok i get it too but what makes this site different to other sites doing the same like dg?

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022

Money like test diffrent article layouts as A/B test, maybe one have disabled anti-adblock pop-up.

different to other sites doing the same like dg?

have reached master level in debugging their code.

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Mar 13, 2022

Ok redirecting not working.

Seems to be only a overlay which can be removed or does only removing cause breakage?

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022

But overlay-buster can break page and the past we tested :matches-css to hide only that pop-up and fastly overrided to uknown number beetween 0-1 e.g. 0,00203440434px as top: in CSS.

Also pop-up can stop run other javascript at page, so few anti-annoyance filters no longer works (needed is rewrite to support both scenarios if e.g. share buttons back).

Also text are fastly changed by use 0-width characters to avoid use :has-text or :has.

@JobcenterTycoon
Copy link
Contributor

So what about to hide every element after the <body> tag except the legit ones? like

money.pl##body > *:not([style]):not(#WP-cookie-info):not(#app):not(#popover):not(a):not(div > div > div + div > div + div:has-text(Cenimy Twoją prywatność)) (just an example i not deep tested for breakage)

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Mar 13, 2022

my filter leaves the cookie banner untouched it only affect the anti adblock overlay

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022

I suppose fastly paste fake style attrib, invalid values in ID. IMO no deteled bug with frozen objects: AdguardTeam/AdGuardExtra#52 (comment)

@JobcenterTycoon
Copy link
Contributor

Yep, but its possible to do a deeper selection like i did for the cookie banner :not(div > div > div + div > div + div:has-text(Cenimy Twoją prywatność))

I not know do they watch uBO so often after no fix for many month? The p-p-s-s issue got fixed 6 days ago and the filters still working fine

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022

what about

*$script,domain=money.pl,redirect-rule=noopjs
money.pl#@#+js()
||wp.pl^$frame,domain=money.pl
||v.wpimg.pl/*.html$frame
money.pl##:xpath(//*[string-length(@href) > 1600])
money.pl#@#.ads

remaining PH

@krystian3w
Copy link
Contributor

krystian3w commented Mar 13, 2022

May start load iframe from this domain range:

abczdrowie.pl,allani.pl,autocentrum.pl,autokult.pl,dobramama.pl,dobregry.pl,dobreprogramy.pl,domodi.pl,echirurgia.pl,extradom.pl,fotoblogia.pl,gadzetomania.pl,homebook.pl,jejswiat.pl,kafeteria.pl,kafeteria.tv,kardiolo.pl,kazimierzdolny.pl,komorkomania.pl,luxlux.pl,medycyna24.pl,mixer.pl,nerwica.com,nocowanie.pl,o2.pl,open.fm,parenting.pl,pinger.pl,pogodnie.pl,polygamia.pl,pudelek.pl,pudelek.tv,pudelekx.pl,pytamy.pl,samosia.pl,smaczneblogi.pl,smog.pl,snobka.pl,so-magazyn.pl,superauto.pl,testwiedzy.pl,totalmoney.pl,vibez.pl,vpolshchi.pl,wakacje.pl

so maybe better convert to denyallow=

@JobcenterTycoon
Copy link
Contributor

It works but only with disabled regional filter list POL: Oficjalne Polskie Filtry do AdBlocka, uBlocka Origin i AdGuarda

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022

I didn't disable the regional lists, for those => money.pl#@#+js()

@krystian3w
Copy link
Contributor

Maybe it is time send official wake up to MajkiIT/Olegwukr to add some new persons with write premissions to create lists more active than 1 commit at 1-2 weeks.

@JobcenterTycoon
Copy link
Contributor

JobcenterTycoon commented Mar 13, 2022

The cosmetic filter pl##.ads flags -> Anti adblock and ads after accepting the cookie banner

money.pl#@#.ads need to be added too to make the filter working with enabled regional POL: filter list too.

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022

added to the filters above

money.pl##:xpath(//*[string-length(@href) > 1600])

and yes needing
money.pl#@#.ads

no anti adb, no ads, only PH

@JobcenterTycoon
Copy link
Contributor

seems to be working fine for wp.pl and other subsites too

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022

Like for the russian sites (where there is an unofficial list disabled by default but recommended by the maintainers on forum - RU AdList: Counters, fixing nasty / circumventing filters pages), maybe the polish maintainers should maintain an unofficial list too.

@JobcenterTycoon
Copy link
Contributor

Do you mean it will not be fixed in uAssets right now?

@mapx-
Copy link
Contributor

mapx- commented Mar 13, 2022

If I'll add the filters in a list enabled by default they will react quickly I guess.
What do you think @okiehsch ?
We could also create here in uAssets a ... "special" list just for such cases (disabled by default)

@JobcenterTycoon
Copy link
Contributor

@mapx- do you remember the thing i did for the site with the red logo? It can be working for this site too but only cosmetic filtering is possible

@okiehsch
Copy link
Contributor

We could also create here in uAssets a ... "special" list just for such cases (disabled by default)

We already have a "special" not enabled list in uAssets, so I am not against it.
Would it not be good enough to post a working fix in the corresponding issue in cases such as this, i.e. the site counters our filters very quickly.

@mapx-
Copy link
Contributor

mapx- commented Mar 14, 2022

@JobcenterTycoon just add other such filters in the new list

@okiehsch we could include the new list as include in our annoyances list (not enabled by default)

@okiehsch
Copy link
Contributor

okiehsch commented Mar 14, 2022

@okiehsch we could include the new list as include in our annoyances list (not enabled by default)

If we add such fixes to a list it should be in a separate list imo.
Similar to https://github.com/uBlockOrigin/uAssets/blob/master/filters/lan-block.txt

@gorhill what do you think.

@gorhill
Copy link
Member

gorhill commented Mar 14, 2022

Ok, how about "uBlock filters – Quick fixes", disabled by default, update every day if enabled? We would need to keep it as small as possible.

@mapx-
Copy link
Contributor

mapx- commented Mar 14, 2022

renamed quick-fixes.txt

@garry-ut99
Copy link
Contributor

garry-ut99 commented Jan 24, 2024

reddit.com/r/uBlockOrigin/comments/19e3m5w/slight_delay_in_firefox_shaky_webpage

gwarser : Complicated case.

Exactly.

u-RraaLL : ##div:matches-css-after(content:/R.*E.*K.*L.*A.*M.*A/):upward(1) This seems very inefficient.

It is, but it's worth to mention that at the same time it is also very powerful and effective, because it kills so many ads on so many wp domains, by a single shot, because "REKLAMA" text is the only constant thing on WP sites during several years amongs all the other randomized stuff, the text itself is still randomized, but it's bypassed by regex, as far I remember the "REKLAMA" text is forced by Polish law when displaying ads on websites, if not "REKLAMA" text on WP sites then we would need to fallback to adding a big bunch of different filters to fix tons of ads separately. Origin of this filter is over 4 years back: MajkiIT/polish-ads-filter@c3c1427 and it still holds (blocks many ads) over all the years.

tatianalarina1 : Any ideas?

Like said above, this is a great filter and should never be removed, because it's too stable, too powerful and too effective, instead there can be created additional faster/anti-blinking filters where possible, but I don't have an email account on poczta.wp.pl and I'm not sure whether I'm interested in creating one, I'll need to think about it.

garry-ut99 added a commit to garry-ut99/uAssets that referenced this issue Jan 24, 2024
ItsProfessional pushed a commit that referenced this issue Jan 24, 2024
@garry-ut99
Copy link
Contributor

garry-ut99 commented Jan 25, 2024

MajkiIT/polish-ads-filter#22289 and
MajkiIT/polish-ads-filter#22292 and
MajkiIT/polish-ads-filter#22294 have landed,
apart of fixing many other unrelated POL sites, here is change log regarding WP Group:

  • added many domains to many already existing filters
  • added many new filters for many WP sites
  • fixed several breakages
  • this is a significant effort in the fight against WP and keeping pressure on them

@krystian3w
Copy link
Contributor

krystian3w commented Feb 3, 2024

Maybe big leftovers after use xpath with "1600":

https://teleshow.wp.pl/kabareciarz-drwi-z-obajtka-jak-opuscic-fotel-za-milion-6991289445952480a

Note

obraz

IDK how stable are:

wp.pl##li[data-adv]:has(> [data-native-adv=true] > a)

but looks better:

Note

obraz

@krystian3w
Copy link
Contributor

krystian3w commented Feb 5, 2024

Maybe fail by using: ##div:has(> [src^="https://v.wpimg.pl/"]:not([alt]))

obraz

IMO links in "Popular" and "latest" sections are not 3p ads.

obraz -
last two now are empty -

test URL:

https://www.pudelek.pl/19-latka-zmarla-6992110006033376a

JobcenterTycoon added a commit that referenced this issue Feb 5, 2024
@JobcenterTycoon
Copy link
Contributor

@garry-ut99

@garry-ut99
Copy link
Contributor

garry-ut99 commented Feb 6, 2024

Unfortunately, I no longer contribute to POL repository, thus I won't send any PR anymore to POL repository, because I have been disrispected and harassed for no reason recently by two POL main admins + their mate (an admin of a website), 3 psycho-admins ganged-up against me, just because they know each other.

As for the WP Group, I added many good filters in several last PRs, so all ads/placeholders are annihilated now, but some of the filters have turned out to cause breakages and need to be removed :

Someone should make PR for POL repo and remove all the 3 filters, and until this happens, they should be whiltelisted in uAssets temporarily (and by the way: removing these filters will not bring up ads/ad placeholders, because these filters are just additional filters, so no need to worry about it).

@JobcenterTycoon
Copy link
Contributor

Done.

@garry-ut99
Copy link
Contributor

An empty ad placeholder in articles : screenshoot, example link : https://film.wp.pl/oscary-2024-nagi-john-cena-na-scenie-7004635085134624a, can be fixed by adding the domain to already existing filter :

kobieta.wp.pl,wiadomosci.wp.pl##header + [data-alternative-wrapper]:has(> div > div > a > img[src^="https://v.wpimg.pl/"])

JobcenterTycoon added a commit that referenced this issue Mar 11, 2024
@garry-ut99
Copy link
Contributor

www.o2.pl + rozrywka.o2.pl: big empty ad placeholders appear recently: SCREENSHOOT 1
poczta.o2.pl: a big ad: SCREENSHOOT 2
all of them can be fixed by adding the domains (or just o2.pl) to already existing filter:

pogoda.wp.pl,sportowefakty.wp.pl,kafeteria.pl,fitness.wp.pl,smaczneblogi.pl##div[class*=" "]:has(> div:empty):matches-css(z-index: 0):matches-css(position: relative)

Additionally, for better protection, these domains: www.o2.pl + rozrywka.o2.pl (doesn't work for poczta.o2.pl) can be added to another filter as well:

sportowefakty.wp.pl,kafeteria.pl,fitness.wp.pl##div[class*=" "]:has(> div:first-child > div:first-child:empty):matches-css(z-index: 0):matches-css(position: relative)

Or given both above filters are similiar and contain similiar domains, worth to check whether one of them is redundant and whether they can be combined into a single filter.

@garry-ut99
Copy link
Contributor

sportowefakty.wp.pl :

  • in articles some sticky (scrolling with page) ads / placeholders: SCREENSHOOT A, SCREENSHOOT B
    (not sure about an ad labeled as "2" on SCREENSHOOT B as it says it's "promotional partnership")
  • example article: https://sportowefakty.wp.pl/mma/1126978/zaskakujacy-przebieg-walki-denisa-zaleckiego-niejednoglosna-decyzja-sedziow
  • I tried already existing filters which have no wp.pl & sportowefakty.wp.pl domain, but none of them do have effect

JobcenterTycoon added a commit that referenced this issue Jun 12, 2024
@garry-ut99
Copy link
Contributor

Breakage: this filter hides plenty of sections with articles on the page, lets say in total half of the page is hidden:

www.wp.pl###app-content > div > div > div.relative

JobcenterTycoon added a commit that referenced this issue Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment