-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
money.pl: detection #12214
money.pl: detection #12214
Comments
WP.pl company update this pop-up in 48 h after commit for uBO but no follow that fast AdamWr fixes added to AdGuard Base. |
Wouldn't it be best if this was addressed in a regional list then? |
IMO out of scope for Olegwukr aka MajkiIT knowledge about JavaScript also we have gorhill privileges to omit fix WP.pl company due too fastly recover ads/anti-adblock by this company (this was wrote on reddit or github older issue). |
update ok i get it too but what makes this site different to other sites doing the same like dg? |
Money like test diffrent article layouts as A/B test, maybe one have disabled anti-adblock pop-up.
have reached master level in debugging their code. |
Ok redirecting not working. Seems to be only a overlay which can be removed or does only removing cause breakage? |
But Also pop-up can stop run other javascript at page, so few anti-annoyance filters no longer works (needed is rewrite to support both scenarios if e.g. share buttons back). Also text are fastly changed by use 0-width characters to avoid use |
So what about to hide every element after the
|
my filter leaves the cookie banner untouched it only affect the anti adblock overlay |
I suppose fastly paste fake style attrib, invalid values in ID. IMO no deteled bug with frozen objects: AdguardTeam/AdGuardExtra#52 (comment) |
Yep, but its possible to do a deeper selection like i did for the cookie banner I not know do they watch uBO so often after no fix for many month? The |
what about
remaining PH |
May start load iframe from this domain range:
so maybe better convert to |
It works but only with disabled regional filter list |
I didn't disable the regional lists, for those => |
Maybe it is time send official wake up to MajkiIT/Olegwukr to add some new persons with write premissions to create lists more active than 1 commit at 1-2 weeks. |
The cosmetic filter
|
added to the filters above
and yes needing no anti adb, no ads, only PH |
seems to be working fine for |
Like for the russian sites (where there is an unofficial list disabled by default but recommended by the maintainers on forum - RU AdList: Counters, fixing nasty / circumventing filters pages), maybe the polish maintainers should maintain an unofficial list too. |
Do you mean it will not be fixed in uAssets right now? |
If I'll add the filters in a list enabled by default they will react quickly I guess. |
@mapx- do you remember the thing i did for the site with the red logo? It can be working for this site too but only cosmetic filtering is possible |
We already have a "special" not enabled list in uAssets, so I am not against it. |
@JobcenterTycoon just add other such filters in the new list @okiehsch we could include the new list as include in our annoyances list (not enabled by default) |
If we add such fixes to a list it should be in a separate list imo. @gorhill what do you think. |
Ok, how about "uBlock filters – Quick fixes", disabled by default, update every day if enabled? We would need to keep it as small as possible. |
renamed |
Exactly.
It is, but it's worth to mention that at the same time it is also very powerful and effective, because it kills so many ads on so many wp domains, by a single shot, because "REKLAMA" text is the only constant thing on WP sites during several years amongs all the other randomized stuff, the text itself is still randomized, but it's bypassed by regex, as far I remember the "REKLAMA" text is forced by Polish law when displaying ads on websites, if not "REKLAMA" text on WP sites then we would need to fallback to adding a big bunch of different filters to fix tons of ads separately. Origin of this filter is over 4 years back: MajkiIT/polish-ads-filter@c3c1427 and it still holds (blocks many ads) over all the years.
Like said above, this is a great filter and should never be removed, because it's too stable, too powerful and too effective, instead there can be created additional faster/anti-blinking filters where possible, but I don't have an email account on |
MajkiIT/polish-ads-filter#22289 and
|
Ads / ad placeholders everywhere. fix uBlockOrigin#12214, fix MajkiIT/polish-ads-filter#18472, fix MajkiIT/polish-ads-filter#18472 (comment) [4 B + 5]
Ads / ad placeholders everywhere. fix #12214, fix MajkiIT/polish-ads-filter#18472, fix MajkiIT/polish-ads-filter#18472 (comment) [4 B + 5]
Unfortunately, I no longer contribute to POL repository, thus I won't send any PR anymore to POL repository, because I have been disrispected and harassed for no reason recently by two POL main admins + their mate (an admin of a website), 3 psycho-admins ganged-up against me, just because they know each other. As for the WP Group, I added many good filters in several last PRs, so all ads/placeholders are annihilated now, but some of the filters have turned out to cause breakages and need to be removed :
Someone should make PR for POL repo and remove all the 3 filters, and until this happens, they should be whiltelisted in uAssets temporarily (and by the way: removing these filters will not bring up ads/ad placeholders, because these filters are just additional filters, so no need to worry about it). |
Done. |
An empty ad placeholder in articles : screenshoot, example link : uAssets/filters/filters-2023.txt Line 1864 in 9bc1287
|
uAssets/filters/filters-2023.txt Line 1843 in bb9adf9
Additionally, for better protection, these domains: uAssets/filters/filters-2023.txt Line 1842 in 503f084
Or given both above filters are similiar and contain similiar domains, worth to check whether one of them is redundant and whether they can be combined into a single filter. |
|
Breakage: this filter hides plenty of sections with articles on the page, lets say in total half of the page is hidden: uAssets/filters/filters-2023.txt Line 1861 in e817903
|
Prerequisites
URL address of the web page
https://www.money.pl/
Category
detection
Describe the issue
unusable with ublock origin on
Screenshot(s)
Screenshot(s)
Configuration
The text was updated successfully, but these errors were encountered: