Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitter.com - existing filters too narrow #15430

Closed
6 tasks done
corobin opened this issue Oct 27, 2022 · 9 comments
Closed
6 tasks done

twitter.com - existing filters too narrow #15430

corobin opened this issue Oct 27, 2022 · 9 comments

Comments

@corobin
Copy link

corobin commented Oct 27, 2022

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

URL(s) where the issue occurs

https://twitter.com/gorhill

Describe the issue

uBlock filters – Annoyances currently has two filters referring to issue #4987

! https://github.com/uBlockOrigin/uAssets/issues/4987
mobile.twitter.com###layers div[dir="auto"] > span:has-text(/在应用上更好|在應用程式上體驗更好的|better on the app|besser in der App|еще больше возможностей в приложении|mejor en la app|melhor no aplicativo|profiterez mieux de Twitter sur l'application|Twitterアプリをおすすめ/):upward(5)
mobile.twitter.com##div[tabindex="0"]:matches-css(position:fixed):has([href="/signup"])
  1. These two filters only apply to mobile.twitter.com. They should be broadened to also include twitter.com as the same elements appear on the main domain as well, which is now identical to the mobile subdomain on mobile and can be accessed via either domain. Further, the blocking signup popup (second filter) appears on the desktop site too.

  2. An additional filter should be added: twitter.com##html:style(overflow:auto!important) this will allow the page to not be frozen after the popup (blocked by the second filter above) is triggered.

  3. Unrelated to the above, there is also a persistent banner that says "Don’t miss what’s happening". Please see screenshot attached.

Thanks!

Screenshot(s)

twitter-dont-miss-happening

uBlock Origin version

1.44.4

Browser name and version

Firefox 106.0.2

Settings

n/a

Notes

No response

@stephenhawk8054
Copy link
Member

  1. Enable Adguard Annoyances list or add these to My filters for Don’t miss what’s happening
twitter.com##html:style(overflow: auto !important; padding-right: 0 !important; overscroll-behavior-y: auto !important;)
twitter.com###layers > div[class] > div[class] > div[class] > div[class]:has(> div[class] > div[class] > div[class] > div[class] > div[class] > div[class] > a[href="/login"])

@gorhill gorhill closed this as completed Oct 31, 2022
@corobin
Copy link
Author

corobin commented Oct 31, 2022

Sorry to bug you but I saw this was closed but looking at the current version of the annoyance list it looks like #1 and #2 that I described above are not updated in the list yet?

#1 should be pretty easy to update, just removing the mobile subdomain from the two filters, as such:

twitter.com###layers div[dir="auto"] > span:has-text(/在应用上更好|在應用程式上體驗更好的|better on the app|besser in der App|еще больше возможностей в приложении|mejor en la app|melhor no aplicativo|profiterez mieux de Twitter sur l'application|Twitterアプリをおすすめ/):upward(5)
twitter.com##div[tabindex="0"]:matches-css(position:fixed):has([href="/signup"])

#2 it appears that this already exists in the adguard annoyance filter but since uBlock Annoyances is blocking the overlay, I suggest it should also contain this filter as well so scrolling is not frozen:

twitter.com##html:style(overflow: auto !important; padding-right: 0 !important; overscroll-behavior-y: auto !important;)

Thanks again!

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Oct 31, 2022

I can reproduce the overlay a few times if scrolling down, not always appear.

These filters work for me

twitter.com##div[tabindex="0"]:matches-css(position:fixed):has([href="/signup"])
twitter.com##html:style(overflow:auto!important)

but I can't see

twitter.com###layers div[dir="auto"] > span:has-text(/在应用上更好|在應用程式上體驗更好的|better on the app|besser in der App|еще больше возможностей в приложении|mejor en la app|melhor no aplicativo|profiterez mieux de Twitter sur l'application|Twitterアプリをおすすめ/):upward(5)

being activated

stephenhawk8054 added a commit that referenced this issue Nov 1, 2022
@corobin
Copy link
Author

corobin commented Nov 1, 2022

but I can't see
...
being activated

That only appears in mobile. but twitter.com is now identical to mobile.twitter.com on mobile so it does appear on the main domain on mobile too. you can see it too if you use device emulation in developer tools on a desktop browser. thanks again.

@stephenhawk8054
Copy link
Member

Ah ok I misunderstood the issue. You meant the step is accessing https://twitter.com/gorhill on mobile.

stephenhawk8054 added a commit that referenced this issue Nov 1, 2022
@corobin
Copy link
Author

corobin commented Nov 1, 2022

Ah ok I misunderstood the issue. You meant the step is accessing https://twitter.com/gorhill on mobile.

doh! yes, i did not explain it clearly. I think the mobile filter short circuited my mental model earlier. glad we had that cleared up. thank you very much!

@ghost
Copy link

ghost commented Nov 5, 2022

I edited this comment actually, idk if it's to be addressed in uAssets

@ghost
Copy link

ghost commented Oct 20, 2023

After I cleared my filters to fix the youtube a adblock issue, i had to manually block the "what's happening" side panel on twitter, but now it doesn't work on every page. if i click on someone's profile or another page, it comes back. I know this topic was for mobile but I'm on PC with chrome and the latest version of uBO. I replied here rather than start a new topic.

this is the thread that shows up when i custom pick it like i said it doesn't work on all pages.

twitter.com##div.r-1udh08x.r-1ifxtd0.r-rs99b7.r-1phboty.r-1867qdf.r-1d6w8o1.r-x572qd.css-1dbjc4n:nth-of-type(4)

even with all these and a duplicate, it still doesn't work.

twitter.com##div.r-1udh08x.r-1ifxtd0.r-rs99b7.r-1phboty.r-1867qdf.r-1d6w8o1.r-x572qd.css-1dbjc4n:nth-of-type(5)
twitter.com##div.r-1udh08x.r-1ifxtd0.r-rs99b7.r-1phboty.r-1867qdf.r-1d6w8o1.r-x572qd.css-1dbjc4n:nth-of-type(3)
twitter.com##div.r-1udh08x.r-1ifxtd0.r-rs99b7.r-1phboty.r-1867qdf.r-1d6w8o1.r-x572qd.css-1dbjc4n:nth-of-type(4)
twitter.com##div.r-1udh08x.r-1ifxtd0.r-rs99b7.r-1phboty.r-1867qdf.r-1d6w8o1.r-x572qd.css-1dbjc4n:nth-of-type(3)

@gorhill
Copy link
Member

gorhill commented Oct 20, 2023

manually block the "what's happening" side panel on twitter

See https://old.reddit.com/r/uBlockOrigin/wiki/solutions/twitter, look for Sidebar section. Use reddit for such support, I will lock the thread to avoid people from being spuriously notified about a resolved issue.

@uBlockOrigin uBlockOrigin locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants