Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiup.io: ads #19903

Closed
8 of 9 tasks
ave9858 opened this issue Sep 29, 2023 · 38 comments
Closed
8 of 9 tasks

multiup.io: ads #19903

ave9858 opened this issue Sep 29, 2023 · 38 comments

Comments

@ave9858
Copy link

ave9858 commented Sep 29, 2023

Prerequisites

  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.)
  • I forced an update of my filter lists. (Click the "Purge all caches" button while holding the 'Shift' key, then click the "Update now" button.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin (uBO) along with other content blocker extensions.
  • I have verified that the web browser's built-in blocker or DNS blocking (standalone or through a VPN) is not causing the issue.
  • I did not answer truthfully to ALL the above checkpoints.

URL address of the web page

https://multiup.io/en/mirror/7b670e960e2d88a1e586d2235a1395ee/uBlock0_1.52.2.chromium.zip

Category

popups

Description

Sometimes when clicking a link on multiup, I am redirected to a NordVPN ad instead of the file.

Other extensions used

none

Screenshot(s)

Screenshot(s)

image

Configuration

uBlock Origin: 1.52.2
Firefox: 117
filterset (summary):
 network: 104812
 cosmetic: 39693
 scriptlet: 18590
 html: 1053
listset (total-discarded, last-updated):
 default:
  user-filters: 0-0, never
  ublock-filters: 35751-48, 1m
  ublock-badware: 7876-0, 1m
  ublock-privacy: 586-0, 1m
  ublock-unbreak: 2170-2, 1m
  ublock-quick-fixes: 234-89, 1m
  easylist: 71185-711, 1m
  easyprivacy: 33183-717, 1m
  urlhaus-1: 11155-0, 1m
  plowe-0: 3721-1, 1m
filterset (user): [empty]
userSettings: [none]
hiddenSettings: [none]
supportStats:
 allReadyAfter: 2581 ms
 maxAssetCacheWait: 13 ms
popupPanel:
 blocked: 0
 extended:
  ##.text-center.bg-info
  ##.mfp-ready
  ##div.col-md-4:nth-of-type(1):has-text(Usennet)
  ##.panel-featured-success.panel-featured-bottom.panel-featured-t…
  ##div.text-center:has(a[class="btn btn-success"][href^="abp:subs…
  ##+js(replace-node-text, script, /.*createElement.*/, var AG_onL…
  ##+js(abort-current-script, decodeURI, decodeURIComponent)
  ##+js(no-setInterval-if, .submit)
@mapx-
Copy link
Contributor

mapx- commented Sep 29, 2023

test

multiup.io##+js(replace-node-text, script, /.*location\.protocol.*/, var AG_onLoad=function(func){if(document.readyState==="complete"||document.readyState==="interactive")func();else if(document.addEventListener)document.addEventListener("DOMContentLoaded"\,func);else if(document.attachEvent)document.attachEvent("DOMContentLoaded"\,func)}; AG_onLoad(function(){var e=document.querySelectorAll(".panel-footer > form[action] > button[link]")\,b=document.querySelectorAll(".panel-footer > form[action]")\,c=new RegExp(/mega\./);if(e.length===b.length)for(var f\,g=0;g<b.length;g++)f=e[g].getAttribute("link")\,b[g].setAttribute("action"\,f)\,b[g].setAttribute("target"\,"_blank")\,b[g].querySelector("input[name=\"link\"]").remove()\,c.test(f)||b[g].setAttribute("method"\,"GET");const h=a=>{a.preventDefault();var b=a?.currentTarget?.getAttribute("link");b?window.open(b):a.currentTarget.removeEventListener("click"\,h)};var i=document.querySelectorAll("button[link^=\"https://drive.google.com/\"]");i.forEach(a=>{a.addEventListener("click"\,h)})}))

@ave9858
Copy link
Author

ave9858 commented Sep 29, 2023

image

I'm seeing this while loading multiup after adding that filter to "My filters". I don't remember ever seeing that message before with ublock. I also notice multiup takes much longer to load than before, making it hard to test. After the slowdown it seems to work. Removing the filter causes the speed to go back to normal, and the ad returns.

@mapx-
Copy link
Contributor

mapx- commented Sep 29, 2023

eh, FF is slower, did you test in chrome ?

@mapx-
Copy link
Contributor

mapx- commented Sep 29, 2023

22d84ae

@mapx- mapx- closed this as completed Sep 29, 2023
gorhill added a commit to gorhill/uBlock that referenced this issue Sep 29, 2023
@ave9858
Copy link
Author

ave9858 commented Sep 29, 2023

eh, FF is slower, did you test in chrome ?

I tested only in firefox, but I've never seen this issue before and it significantly slows down page load. I'll test the final fix in firefox and brave.

@ghajini
Copy link
Collaborator

ghajini commented Sep 30, 2023

eh, FF is slower, did you test in chrome ?

I tested only in firefox, but I've never seen this issue before and it significantly slows down page load. I'll test the final fix in firefox and brave.

@ave9858 update filters
with current stable build you will see links unlocked like this
image
simply copy link & open in new tab

when ublock origin is updated to new stable build, this will work more adequately as fix has landed in dev build

@ave9858
Copy link
Author

ave9858 commented Sep 30, 2023

Thanks, I can see those links now. Only other issue is the popups quickly created by the site and removed during page load by ublock, but I'm not sure if that can be fixed or not.

@ghajini
Copy link
Collaborator

ghajini commented Sep 30, 2023

Thanks, I can see those links now. Only other issue is the popups quickly created by the site and removed during page load by ublock, but I'm not sure if that can be fixed or not.

just wait for next stable build

@krystian3w
Copy link
Contributor

We do not need use AG_onLoad=function(func) if these fuction do not exist at all.

@krystian3w
Copy link
Contributor

Also maybe these can be unlocked #7897, fyi @dhana-exe

@dimisa-RUAdList

This comment has been minimized.

@mapx-

This comment has been minimized.

@ghajini

This comment has been minimized.

@mapx-

This comment has been minimized.

@mapx-

This comment has been minimized.

@dimisa-RUAdList

This comment has been minimized.

@ghajini

This comment has been minimized.

@mapx-

This comment has been minimized.

@dimisa-RUAdList

This comment has been minimized.

@ghajini

This comment has been minimized.

@dimisa-RUAdList

This comment has been minimized.

@mapx-

This comment has been minimized.

@dimisa-RUAdList

This comment has been minimized.

@ave9858
Copy link
Author

ave9858 commented Nov 30, 2023

I'm seeing redirects through https://multinews.me/produit/nordvpn and https://multinews.me/produit/1fichier-com/ now when clicking links.

@ghajini
Copy link
Collaborator

ghajini commented Nov 30, 2023

can't reproduce,share a link to see that

@ave9858
Copy link
Author

ave9858 commented Nov 30, 2023

Using the link https://multiup.io/en/mirror/7b670e960e2d88a1e586d2235a1395ee/uBlock0_1.52.2.chromium.zip. You might need to change your IP, the redirect isn't consistent and seems to be on a timer for each IP.

@ave9858
Copy link
Author

ave9858 commented Nov 30, 2023

Reproduced again by clicking on a link, using the browser back button, and repeating until I saw a redirect through https://multinews.me/produit/ipvanish. The exact URL seems to change a lot but seems to be always through multinews.me

@ghajini
Copy link
Collaborator

ghajini commented Nov 30, 2023

can't reproduce, make sure

  • you have ubo filters updated with default settings
  • ubo version updated to 1.54
  • other similarly purposed extensions disabled when using ublock origin

@ave9858
Copy link
Author

ave9858 commented Nov 30, 2023

I created a new Firefox profile + new install of uBlock Origin, purged caches and updated, navigated to the URL, disabled firefox tracking protection and was able to reproduce after a few attempts and changing my IP.

Looking at the network requests in dev tools shows that most of the time the browser navigates directly to the file hoster page, but sometimes the browser sends a POST request to https://multiup.io/ajax/add-download-for-link and then https://multinews.me/produit/nordvpn (or similar url), which will at first redirect to the ad page and then the file download page on subsequent requests.

@ghajini
Copy link
Collaborator

ghajini commented Dec 1, 2023

ok i can reproduce now, website restructured now

@ghajini ghajini reopened this Dec 1, 2023
@ghajini ghajini closed this as completed Dec 1, 2023
@ghajini
Copy link
Collaborator

ghajini commented Dec 1, 2023

@ave9858 might be race condition ,update lists

when that happens use

multiup.eu,multiup.io,multiup.org##+js(remove-attr, action, [action*="multinews"], stay)
multiup.eu,multiup.io,multiup.org##+js(ra, class, [class="hidden"], stay)
multiup.eu,multiup.io,multiup.org##+js(ra, type, [type="hidden"], stay)

@ave9858
Copy link
Author

ave9858 commented Dec 1, 2023

With the latest filter updates I'm still sometimes seeing the issue, but its hard to reproduce. With the filters in your comment I haven't seen the issue, but that might be because the issue is not consistently reproducible.

Edit: Most of the time the download button works, but sometimes I see a POST to "https://multiup.io/ajax/add-download-for-link" and the page reloads instead of an ad.

Edit2: Tested without multiup.eu,multiup.io,multiup.org##+js(remove-attr, action, [action*="multinews"], stay) and I see the ad instead of the page reload.

Edit3: I'll try do debug the multiup scriptlet in uBO

@ave9858

This comment was marked as outdated.

@ave9858
Copy link
Author

ave9858 commented Dec 2, 2023

Figured out how to reliable reproduce the error: click the download button icon. The click will be registered to <i class="fa fa-fw fa-download"> instead of the button, so the script won't intercept.
image

ave9858 added a commit to ave9858/uBlock that referenced this issue Dec 3, 2023
@ave9858
Copy link
Author

ave9858 commented Dec 3, 2023

I've uploaded code that should fix the ad redirect when clicking on the icon

@ghajini

This comment has been minimized.

@ave9858
Copy link
Author

ave9858 commented Dec 4, 2023

Another unblocked ad, on a page with no file like https://multiup.io/en/mirror/meowmeowmeow you'll sometimes be redirected to an ad page.
image
image

@ghajini ghajini changed the title multiup.io: redirect to nordvpn multiup.io: Ads Dec 4, 2023
@ItsProfessional ItsProfessional changed the title multiup.io: Ads multiup.io: ads Dec 4, 2023
@ave9858
Copy link
Author

ave9858 commented May 27, 2024

getting the UseNet.nl fake download again, adding multiup.io,multiup.org,multiup.eu##div:has(> .panel-featured-success.panel-featured-bottom.panel-featured-top.panel.text-center [alt="UseNet.nl"]) fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants