Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl.nl: ads #23325

Closed
10 of 11 tasks
RSwar01 opened this issue Apr 16, 2024 · 11 comments
Closed
10 of 11 tasks

rtl.nl: ads #23325

RSwar01 opened this issue Apr 16, 2024 · 11 comments

Comments

@RSwar01
Copy link

RSwar01 commented Apr 16, 2024

Prerequisites

  • This is NOT a YouTube, Facebook, Twitch or a shortener/hosting site report. These sites MUST be reported by clicking their respective links.
  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable additional filter lists, or I have verified that the issue still occurs without enabling additional filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin along with other content blockers.
  • I have verified that the web browser's built-in content blocker/tracking protection, network wide/DNS blocking, or my VPN is not causing the issue.
  • I have verified that other extensions are not causing the issue.
  • If this is about a breakage or detection, I have verified that it is caused by uBlock Origin and isn't a site issue.
  • I did not answer truthfully to ALL the above checkboxes.

URL address of the web page

https://www.rtl.nl/

Category

ads

Description

Empty AD containers left

Other extensions used

none

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin: 1.57.2
Firefox: 124
filterset (summary):
 network: 134060
 cosmetic: 48008
 scriptlet: 19101
 html: 1766
listset (total-discarded, last-updated):
 default:
  user-filters: 14-5, never
  ublock-filters: 37646-108, 3m
  ublock-badware: 8183-0, 3m
  ublock-privacy: 793-1, 3m
  ublock-unbreak: 2305-2, 3m
  ublock-quick-fixes: 140-29, 9m Δ
  easylist: 85971-172, 3m
  easyprivacy: 50766-61, 3m
  urlhaus-1: 12315-5, 3m
  plowe-0: 3739-1162, 3m
  NLD-0: 2773-15, 3m
filterset (user): [array of 14 redacted]
userSettings: [none]
hiddenSettings: [none]
supportStats:
 allReadyAfter: 5247 ms
 maxAssetCacheWait: 87 ms
 cacheBackend: indexedDB
popupPanel:
 blocked: 19
 network:
  rtl.nl: 6
  bitmovin.com: 1
  demdex.net: 2
  dpgmedia.cloud: 3
  googletagmanager.com: 1
  imasdk.googleapis.com: 1
  rackcdn.com: 1
  smartocto.com: 1
  snplow.net: 2
  usabilla.com: 1
@mapx-
Copy link
Contributor

mapx- commented Apr 16, 2024

add

rtl.nl##[data-adslot-variant]

to be included in the regional list: EasyDutch

report at EasyDutch repository: https://github.com/EasyDutch-uBO/EasyDutch/issues

@EchoDev
Copy link

EchoDev commented Apr 25, 2024

@mapx- it looks like EasyDutch hasn't had an update in the last 3 months, maybe add this to uBo list for now?

@mapx-
Copy link
Contributor

mapx- commented Apr 26, 2024

@Yuki2718 could you add the filter to EL ?

@Yuki2718
Copy link
Contributor

Yuki2718 commented Apr 26, 2024

@mapx- Even though reginal site? I'm sure the rest of members disagree. If ED stopped maintenance, we have to switch the list - maybe AG one. I can add if the rule is worth generic, but https://publicwww.com/websites/%22data-adslot-variant%22+depth%3Aall/ => 0 results.

@Yuki2718
Copy link
Contributor

@Nomes77

@EchoDev
Copy link

EchoDev commented Apr 26, 2024

I made a pull request in EasyDutch so hopefully someone will respond soon.

The Dutch list by AG is maintained actively so a switch might be logical.

@EchoDev
Copy link

EchoDev commented May 11, 2024

@Yuki2718 @mapx-

Can we get an update on this? Still no response from EasyDutch maintainers, maybe consider switching to a new list in uBo since more and more Dutch sites are showing ads or breaking

@Yuki2718
Copy link
Contributor

We will discuss internally.

@Yuki2718
Copy link
Contributor

We replaced our Dutch list to AdGuard Dutch: gorhill/uBlock@f1f63c9

@ikheetjeff
Copy link

Good improvement. However, this change makes reading articles less pleasant. Because the right advertisement column completely disappears, the text shifts partially to the right. See screenshots.

With ads:
afbeelding

With this cosmetic filter:
afbeelding

I would like to suggest leaving the left advertisement column empty but still visible. This way, the reading experience is not ruined. Screenshot:

afbeelding

I couldn’t quite find if this is possible, but it should concern this piece of HTML:

<div data-adslot-variant="halfpage1" data-adslot-ready="false" data-adslot-error="true" data-adslot-duration="0ms" class="css-f4tggb"><div id="halfpage1"></div></div>

Yuki2718 added a commit to AdguardTeam/AdguardFilters that referenced this issue Jun 14, 2024
@Yuki2718
Copy link
Contributor

@ikheetjeff Fixed, update will be avail once the change make it into CDN and then distributed by next update process. Remember you can now directly report to https://github.com/AdguardTeam/AdguardFilters/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants