Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pocketnow.com problem #278

Closed
okiehsch opened this issue Jan 24, 2017 · 14 comments
Closed

pocketnow.com problem #278

okiehsch opened this issue Jan 24, 2017 · 14 comments

Comments

@okiehsch
Copy link
Contributor

okiehsch commented Jan 24, 2017

URL(s) where the issue occurs

http://pocketnow.com/2017/01/24/vertu-constellation-luxury-performance-smartphone-specs
Warning: Some gross Revcontent ads.

Describe the issue

pocketnow.com pulls ads through first party iframes

Versions

  • Browser/version: Chrome 55
  • uBlock Origin version: 1.10.4

Settings

  • default

Notes

The filter pocketnow.com##script:inject(abort-on-property-read.js, inIframe)
should solve the issue, the problem is it does only after I reload the site.
If I add the filter and then go to
http://pocketnow.com/2017/01/24/vertu-constellation-luxury-performance-smartphone-specs
I will see ads and the console shows
pock

If I now reload the page the ads are gone as expected and the console is empty.
pock2

Edit: If I don't add the filter reloading the site still produces ads and the console shows
pocks

@ghost
Copy link

ghost commented Jan 24, 2017

This hides the ads at least:

pocketnow.com##A[href^="/wp-content/embed-ad-content/"]
pocketnow.com###recommended + *
pocketnow.com##CENTER
||chameleonx.net^

Maybe add a warning that some of the ads are quite gross (the ###recommended + * ones).

@gorhill
Copy link
Member

gorhill commented Jan 25, 2017

I will see ads and the console shows

I don't see this on my side, and no apparent ads. That contentscript.js warning usually occur when one restarts uBO while a page is already opened.

@gorhill
Copy link
Member

gorhill commented Jan 25, 2017

Strike that, I did get the content script error, and some ads also. Will investigate as time allow.

@gorhill
Copy link
Member

gorhill commented Jan 25, 2017

How about:

pocketnow.com##script:inject(setTimeout-defuser.js, /_0x[0-9a-z]|ad-block-test/)

@okiehsch
Copy link
Contributor Author

Well now I can't see any ads or the content script error.
Looking at the source code the whole inline script that pulled the ads yesterday
has been removed.

@okiehsch
Copy link
Contributor Author

okiehsch commented Jan 25, 2017

The same inline script is now present at geektime.co.il.
geektime.co.il##script:inject(abort-on-property-read.js, inIframe) again does not work
consistently so maybe my scriptlet is faulty.

Console if it works and you don't see ads.
geek

Console if it does not work and you do see ads.
geek1

@gorhill
Copy link
Member

gorhill commented Jan 25, 2017

does not work
consistently

Does it work better if commenting out the 3 lines of code at https://github.com/gorhill/uBlock/blob/8c3da95d650001a61eefcd301aa9e415151bd7f3/platform/chromium/vapi-client.js#L53

Seems to be the case on my side.

@okiehsch
Copy link
Contributor Author

okiehsch commented Jan 25, 2017

With a modified vapi-client.js
sss
hope that's what you meant.

It seems to be working more consistently but after randomly clicking through about
half a dozen articles I could reproduce the Uncaught TypeError with the accompanying
ads once again.

@gorhill
Copy link
Member

gorhill commented Jan 25, 2017

I could reproduce the Uncaught TypeError once again

I think this one is an issue with abort-on-property-read.js -- I think there is a flawed test in there about how it tries to detect whether the property was already trapped by uBO. I believe the issue could be reproduced by merely removing then re-adding an iframe in the DOM.

The contentType stuff, I could maybe revise to no longer abort content script execution, but rather just ensure no style tags are inserted in the document -- which were the issues for that piece of code.

okiehsch added a commit that referenced this issue Jan 29, 2017
okiehsch added a commit that referenced this issue Jan 31, 2017
@zum348
Copy link

zum348 commented Feb 7, 2017

same company from geektime.co.il, can you fix them too? looks like Hebrew list can fix the ads there. I've tested adGuard too

@zum348
Copy link

zum348 commented Feb 27, 2017

any news about this? @okiehsch @gorhill ?

@IsraeliAdblocker
Copy link

just wanted to know if there is a fix for this one?

@terrorist96
Copy link
Contributor

The site has an "ad manager" at the bottom right. That can be used to turn off the ads:
image

@okiehsch
Copy link
Contributor Author

fyi @ryanbr pocketnow.com##div > div > table:last-child breaks search.
It hides all search results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants