Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cooking.nytimes.com #3708

Closed
pepablock opened this issue Oct 14, 2018 · 4 comments
Closed

cooking.nytimes.com #3708

pepablock opened this issue Oct 14, 2018 · 4 comments

Comments

@pepablock
Copy link

List the website(s) you're having issues:

https://cooking.nytimes.com/recipes/1018016-pot-roast

What happens?

cant print recipes (blank page) and log in button doesnt work.

List Subscriptions you're using:

default
Adguard’s Annoyance
Fanboy’s Cookiemonster List​

Your settings

  • OS/version: MacOS High Sierra 10.13.6
  • Browser/version: Firefox 62.0.3 (64-bit)
  • Adblock Extension/version: uBlock Origin 1.17.0

Other details:

@ZaphodBeebblebrox
Copy link
Contributor

The filter cooking.nytimes.com##[class^="nytc---modal-window"] causes the problem. For now, I am removing it as it causes site breakage, but removing it makes it so people who do not login cannot access the recipe. If possible, we need a solution that blocks the initial modal but still lets people log when they click the login button.

ZaphodBeebblebrox added a commit that referenced this issue Oct 14, 2018
Just commenting out the filter for now, we need a better solution for this site.
@THEtomaso
Copy link

Just be careful not to block the cookie popup.
If there are any videos at those cooking pages, people might not be able to watch them, unless the cookie consent has been accepted!
Other forms of breakage might also occur.

I've reported this issue to ryanbr here:
ryanbr/fanboy-adblock#483
He added an exception rule for this domain a couple of days ago.
..but unfortunately, there's still one problem rule in his filters which hasn't been dealt with yet!

PS:
Like with so many other examples of these GDPR issues, this one also seems to be location dependent.

@THEtomaso
Copy link

I blocked all the modals, to get to what lies beneath..
Even when the cookie consent is blocked, I'm happy to report that all of the videos that I found seems to play just fine! :)
But of course, you can never be sure when it comes to this stuff, as there might be regional differences involved.

@pepablock
Copy link
Author

It was working flawlessly, but for some reason the filters for this specific page/recipe aren't working.
https://cooking.nytimes.com/recipes/1787-new-orleans-barbecue-shrimp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants