Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

damoh videos ads #6541

Closed
JobcenterTycoon opened this issue Nov 10, 2019 · 118 comments
Closed

damoh videos ads #6541

JobcenterTycoon opened this issue Nov 10, 2019 · 118 comments

Comments

@JobcenterTycoon
Copy link
Contributor

URL(s) where the issue occurs

https://web.de/magazine/wissen/natur-umwelt/insektenschwund-deutschland-stille-sterben-insekten-34145488
https://www.gmx.net/magazine/wissen/natur-umwelt/gift-kegelschnecke-schmerztherapie-helfen-34164788
https://www.gmx.at/magazine/gesundheit/kinder-leiden-haeufig-kopfschmerzen-34166518

Describe the issue

Video get blocked

Screenshot(s)

Unbenannt

Versions

  • Browser/version: Firefox 70.0.1
  • uBlock Origin version: v1.23.0

Settings

Settings.txt

Notes

@JobcenterTycoon
Copy link
Contributor Author

Video ads on https://www.golem.de/

golem.de##+js(json-prune, enabled, testhide) will fix that

@okiehsch
Copy link
Contributor

4440a10

@JobcenterTycoon
Copy link
Contributor Author

video ads are back again

@mapx-
Copy link
Contributor

mapx- commented Nov 21, 2019

test
*$media,redirect=noopmp3-0.1s,domain=web.de|gmx.net|gmx.at,3p
or
*$media,redirect=noopmp3-0.1s,domain=web.de|gmx.net|gmx.at

@JobcenterTycoon
Copy link
Contributor Author

doesnt work

@lain566
Copy link
Contributor

lain566 commented Nov 21, 2019

@JobcenterTycoon These filters should work for you.

gmx.*,web.de#@#+js(json-prune, enabled, testhide)
gmx.*,web.de##+js(json-prune, enabled, force_disabled)

@JobcenterTycoon
Copy link
Contributor Author

JobcenterTycoon commented Nov 21, 2019

Yes it works, thank you.
Here a list with more sites that are use the same ad system (tested):

t-online.de##+js(json-prune, enabled, force_disabled)
winfuture.de##+js(json-prune, enabled, force_disabled)
golem.de##+js(json-prune, enabled, force_disabled)
giga.de##+js(json-prune, enabled, force_disabled)

lain566 added a commit that referenced this issue Nov 21, 2019
@JobcenterTycoon
Copy link
Contributor Author

JobcenterTycoon commented Nov 27, 2019

Video Ads are back again on web.de, gmx.net, golem.de

@JobcenterTycoon
Copy link
Contributor Author

Video ads on focus.de

@okiehsch
Copy link
Contributor

okiehsch commented Nov 27, 2019

I can't reproduce with Chromium or Firefox using a german IP.
Example links:

https://www.gmx.net/magazine/panorama/australische-buschfeuer-rettet-koala-flammen-34196752
https://video.golem.de/games/23813/razer-blade-stealth-13-test.html

@okiehsch
Copy link
Contributor

I can reproduce video ads at focus.de.
focus.de##+js(json-prune, enabled, force_disabled)
fixes the issue on my end.
Example link:

https://www.focus.de/wissen/mensch/deutschland-die-suche-nach-toten-soldaten_id_11399140.html

okiehsch added a commit that referenced this issue Nov 27, 2019
@JobcenterTycoon
Copy link
Contributor Author

I get only ads in firefox. The first video have no ads but when i switch to another one i get video ads

@okiehsch
Copy link
Contributor

I can't reproduce. @lain566 can you reproduce?

@JobcenterTycoon does the filter for focus.de work on your end?

@JobcenterTycoon
Copy link
Contributor Author

yes

@JobcenterTycoon
Copy link
Contributor Author

Ok now it works and i get less video ads on all sites, after a few more tests i know its only a rare chance to get Video ads (100% chance without filter, 10% with filter), so you can ignore this

@lain566
Copy link
Contributor

lain566 commented Nov 28, 2019

It's strange for me, I could reproduce ads, but now I don't.
for example, I could reproduce ads on these sites, now the player is broken for me with Firefox

https://www.kino.de/film/captain-marvel-2019/
https://www.spieletipps.de/artikel/9902/1/

@okiehsch
Copy link
Contributor

I can reproduce ads on both sites.

kino.de,spieletipps.de##+js(json-prune, enabled, force_disabled)

works on my end.

okiehsch added a commit that referenced this issue Nov 28, 2019
@lain566
Copy link
Contributor

lain566 commented Nov 28, 2019

@okiehsch Yes, that fixed the player for me
Can you reproduce pre roll ads on this site?
https://www.videogameszone.de/Bless-Spiel-19102/News/mmorpg-steam-geld-zurueck-1332270/

@okiehsch
Copy link
Contributor

Yes, same filter works for me.
videogameszone.de##+js(json-prune, enabled, force_disabled)

okiehsch added a commit that referenced this issue Nov 28, 2019
@lain566
Copy link
Contributor

lain566 commented Nov 28, 2019

@okiehsch Can you check these sites?

https://www.pcgameshardware.de/Borderlands-3-Spiel-54615/Videos/Trailer-DLC-Moxxis-Ueberfall-Handsome-Jackpot-1337576/
https://www.pcgames.de/Star-Wars-Episode-9-Film-259018/News/Neuer-Werbespot-zeigt-weitere-Szenen-aus-dem-Film-1337606/
https://www.gamesaktuell.de/Alien-Isolation-Spiel-2938/News/nintendo-switch-release-horror-1337624/
https://www.buffed.de/World-of-Warcraft-Classic-Spiel-42973/News/PvP-Schlachtfelder-und-Elementar-Invasionen-im-Dezember-1337528/

I can't reproduce pre roll ads on videogameszone.de
the video stops for a few seconds, but then the playback of the video continues normal

@okiehsch
Copy link
Contributor

I can only reproduce pre roll ads on gamesaktuell.de. The rest has the same "issue" you described.
"the video stops for a few seconds, but then the playback of the video continues normal"

okiehsch added a commit that referenced this issue Nov 28, 2019
@lain566
Copy link
Contributor

lain566 commented Nov 28, 2019

Before I could reproduce ads from all those sites that I mentioned #6541 (comment)
but I didn't add a solution, because I couldn't reproduce ads anymore

@okiehsch
Copy link
Contributor

okiehsch commented Nov 28, 2019

Before I could reproduce ads from all those sites that I mentioned #6541 (comment)
but I didn't add a solution, because I couldn't reproduce ads anymore

I assume the solution is the same filter ##+js(json-prune, enabled, force_disabled)?
Adding it does fix the "video stops for a few seconds" issue, so if you want to add it for all sites that have this minor issue. 👍
Probably something is wrong on their end and the ads will reappear soon enough.

@lain566
Copy link
Contributor

lain566 commented Nov 28, 2019

When I could reproduce ads, this filter ##+js(json-prune, enabled, force_disabled) didn't work for me, especially on this site #6541 (comment) and kino.de and now it seems to work.

I can add ##+js(json-prune, enabled, force_disabled) I will add it at night.

@JobcenterTycoon
Copy link
Contributor Author

Video ads are back on giga

@mapx-
Copy link
Contributor

mapx- commented Jun 2, 2022

does this work

||js.stroeermediabrands.de/metaTag$script,domain=giga.de,redirect=noopjs

@JobcenterTycoon
Copy link
Contributor Author

JobcenterTycoon commented Jun 2, 2022

No a few times the ad still pass

@JobcenterTycoon
Copy link
Contributor Author

JobcenterTycoon commented Jun 2, 2022

@mapx- does this work

||js.stroeermediabrands.de/metaTag$script,domain=giga.de,redirect=noopjs
||damoh.giga.de^$script,1p,redirect=noopjs
giga.de#@#+js(set-constant, CustomEvent, noopFunc)

For me the ad player blinks and disappear after a second so no ad get played with these filter

@mapx-
Copy link
Contributor

mapx- commented Jun 2, 2022

no .. I get alpenmilch werbung after 4-5 tests

JobcenterTycoon added a commit that referenced this issue Jun 2, 2022
@JobcenterTycoon
Copy link
Contributor Author

Pretty sure they rotate. At the beginning i get a media query with the ad and after a few reloads i get the damoh.giga.de script which can be blocked with the filter i mentioned without breakage

@JobcenterTycoon
Copy link
Contributor Author

@okiehsch can you take a look on the damoh stuff on giga.de? Im unable to find a fix. Example: https://www.giga.de/video/partner-gefunden-e-autos-von-sony-kommen-giga-insights/

@okiehsch
Copy link
Contributor

okiehsch commented Sep 5, 2022

giga.de##+js(no-xhr-if, stroeermediabrands)
gets rid of the ads on my end but there is still some time until the video starts after clicking play.

@okiehsch
Copy link
Contributor

okiehsch commented Sep 5, 2022

Strike that now the ads still play....

@JobcenterTycoon
Copy link
Contributor Author

So there is no fix?

@okiehsch
Copy link
Contributor

okiehsch commented Sep 5, 2022

Don't know, I can't find one without breaking the player.

@JobcenterTycoon
Copy link
Contributor Author

So a new damoh-defuser.js is needed because the old one is outdated and not getting used anymore @gorhill

@okiehsch
Copy link
Contributor

okiehsch commented Sep 5, 2022

A german IP is needed to reproduce.

@gorhill
Copy link
Member

gorhill commented Sep 5, 2022

This works?

giga.de##+js(json-prune, ad_fallback)

@okiehsch
Copy link
Contributor

okiehsch commented Sep 6, 2022

It works sometimes but not consistently on my end.
Test with the "Top Videos" section on the homepage, you have to scroll down a little bit.

JobcenterTycoon added a commit that referenced this issue Sep 6, 2022
@JobcenterTycoon
Copy link
Contributor Author

Works fine for me

@okiehsch
Copy link
Contributor

okiehsch commented Sep 6, 2022

Does the real video start immediately on your end or do you see a black screen first?

@okiehsch
Copy link
Contributor

okiehsch commented Sep 6, 2022

With Firefox
image

@JobcenterTycoon
Copy link
Contributor Author

JobcenterTycoon commented Sep 6, 2022

I see a black screen first, tested on Firefox mulitply times.

@okiehsch
Copy link
Contributor

okiehsch commented Sep 6, 2022

Interesting, that's what I see most of the time but at your example link
https://www.giga.de/video/partner-gefunden-e-autos-von-sony-kommen-giga-insights/
I get the disney ad in my screenshot every time.

Well, the filter is still a massive improvement.

@JobcenterTycoon
Copy link
Contributor Author

JobcenterTycoon commented Sep 6, 2022

Without the filter i get this

screenshot Unbenannt

First they ask what ad i want and when i select none it plays a random one after 10 seconds. With the filter i have one second a blank screen and after this the real video plays

What i know is that they change the behavior when the user often visit the site/reload many times. I test every time with a clear browser

@JobcenterTycoon
Copy link
Contributor Author

JobcenterTycoon commented Sep 7, 2022

@okiehsch @gorhill

giga.de##+js(json-prune, ad_fallback) doesn’t work anymore. When i read the old comments json-prune never works for a longer time #6541 (comment) #6541 (comment)

I checked a few other sites it seems to be only a problem on giga, on all other sites the ads are still blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants