Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook ads getting through #722

Closed
terrorist96 opened this issue Sep 28, 2017 · 8 comments
Closed

Facebook ads getting through #722

terrorist96 opened this issue Sep 28, 2017 · 8 comments

Comments

@terrorist96
Copy link
Contributor

URL(s) where the issue occurs

facebook.com

Describe the issue

uBO previously always blocked FB ads. Seeing them again for the first time today.

Screenshot(s)

image

Versions

  • Browser/version: Chrome/60
  • uBlock Origin version: 1.14.8

Settings

Default

Notes

Could be connected with ABP's recent change? https://adblockplus.org/blog/consumers-again-declare-independence-from-relentless-facebook-ads

@gorhill
Copy link
Member

gorhill commented Sep 28, 2017

I added support in 1.14.11rc7 for :-abp-has() and :-abp-contains() now used by EasyList. Can you see if these ads are taken care of by that version of uBO + an up to date EasyList?

@terrorist96
Copy link
Contributor Author

I prefer to stay on the stable build so I'll wait til you push out the next update. :)

@okiehsch
Copy link
Contributor

okiehsch commented Sep 28, 2017

He meant for you to install 1.14.11rc7, so you can test if the issue is fixed, after that you can remove
1.14.11rc7 and use the stable build.
I can't test, because I do not have a Facebook account.

@terrorist96
Copy link
Contributor Author

Ok, I installed the test version and can confirm Facebook ads are blocked. Thanks!

@smed79
Copy link
Contributor

smed79 commented Sep 28, 2017

I prefer to stay on the stable build

You can use a portable version of a web browser or create 2nd profile for testing.

@gorhill
Copy link
Member

gorhill commented Sep 29, 2017

Will remove the added filters once 1.14.12 is out and widespread.

@gotitbro
Copy link

@smed79 In the comments of the ABP blogpost Ben mentions this

EasyList(s). As for update regularity, it’s now at 48 hours

Wasn't it always 48 hours?

@smed79
Copy link
Contributor

smed79 commented Sep 30, 2017

Wasn't it always 48 hours?

The update interval up to the list maintainer.
I remember it was 4 days before but they have changed to 2 days probably because of those sites that use a revolving adservers.

e.g

gorhill added a commit that referenced this issue Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants