Update twitter: https://github.com/uBlockOrigin/uAssets/issues/20792 #20813

D4niloMR · 2023-11-22T04:06:49Z

#20792 (comment)

fix flickering/ads in opened images

D4niloMR · 2023-11-22T04:08:43Z

The only account I have that show ads for me is paywalled now, I can't test more. But from what I tested it's working fine.

Yuki2718 · 2023-11-22T05:03:10Z

But why :remove()? Don't use it unless necessary. On my end it doesn't cover all what were covered by ##[data-testid="primaryColumn"] [data-testid="cellInnerDiv"]:has([data-testid="top-impression-pixel"]).

D4niloMR · 2023-11-22T05:08:16Z

But why :remove()?

This is what prevented #20792 (comment) on my end

Yuki2718 · 2023-11-22T08:28:20Z

This is what prevented #20792 (comment) on my end

Okay, but can you restore the original rule as I'm not sure if the new rule covers all?

D4niloMR · 2023-11-22T12:48:46Z

This works to you? removing [data-testid="cellInnerDiv"] causes breakage to me.
twitter.com##[data-testid="primaryColumn"] [data-testid="cellInnerDiv"] > div:has([data-testid="top-impression-pixel"]):remove()

It should work, maybe the [aria-label^="Timeline:"] is in another language to you?

Yuki2718 · 2023-11-22T13:04:06Z

Yes, aria-label is language-dependent. The rule seems to work.

Yuki2718 · 2023-11-22T13:10:44Z

Thanks

D4niloMR · 2023-11-22T13:12:07Z

Ok, maybe it still has ads in opened images though, but I can't test #20813 (comment)

e.g.:
https://twitter.com/gorhill/status/996016461943574528/photo/1

DaisukeDaisuke · 2023-11-22T23:42:35Z

maybe it still has ads in opened images though

Ads next to the image will still be displayed
In my opinion AdGuard – Ads removes this, so I don't think it's anything to worry about

open image

open Troubleshooting Information

uBlock Origin: 1.53.0
Chromium: 119
filterset (summary):
 network: 154605
 cosmetic: 122649
 scriptlet: 26970
 html: 0
listset (total-discarded, last-updated):
 removed:
  user-filters: null
  urlhaus-1: null
 added:
  adguard-social: 22021-34, 5m
  adguard-spyware: 72599-174, 5m
  adguard-spyware-url: 1329-5, 5m
  block-lan: 55-0, 5m
  fanboy-cookiemonster: 48997-225, 5m
  ublock-annoyances: 5887-57, 4m
  ublock-quick-fixes: 206-73, 4m
 default:
  JPN-1: 13797-5, 5m
  easylist: 75640-81, 5m
  easyprivacy: 32912-16327, 5m
  plowe-0: 3719-1171, 4m
  ublock-badware: 7479-147, 4m
  ublock-filters: 35700-235, 4m
  ublock-privacy: 735-228, 4m
  ublock-unbreak: 2154-87, 4m
filterset (user): [array of 1414 redacted]
trustedset:
 added: [array of 10 redacted]
switchRuleset:
 added: [array of 19 redacted]
userSettings:
 largeMediaSize: 1
hiddenSettings: [none]
supportStats:
 allReadyAfter: 2048 ms (selfie)
 maxAssetCacheWait: 573 ms
popupPanel:
 blocked: 12
 network:
  twitter.com: 9
  ads-twitter.com: 2
  google-analytics.com: 1
 extended:
  ##div[data-testid="trend"]:has(path[d$="10H8.996V8h7v7z"])
  ##[data-testid="trend"]:has-text(/Promoted|Gesponsert|Promociona…
  ##[data-testid="primaryColumn"] [data-testid="cellInnerDiv"] > d…
  ##html:style(overflow:auto!important)
  ##+js(trusted-set-cookie, d_prefs, MjoxLGNvbnNlbnRfdmVyc2lvbjoyL…

D4niloMR · 2023-11-23T00:15:29Z

so I don't think it's anything to worry about

AdGuard – Ads is not enabled by default.

And maybe just twitter.com##[data-testid="cellInnerDiv"] > div:has([data-testid="top-impression-pixel"]) fix this. But as I mentioned earlier, I can't test properly because the only account I have(that has ads) it's paywalled.

Edit: this filter from AdGuard doesn't even use procedural filters: twitter.com##div[data-testid="cellInnerDiv"] > div > div[class] > div[class][data-testid="placementTracking"]

DaisukeDaisuke · 2023-11-23T00:19:36Z

And maybe just twitter.com##[data-testid="cellInnerDiv"] > div:has([data-testid="top-impression-pixel"])

When I added the filter I received to My Filters, it was fixed

open image

D4niloMR · 2023-11-23T00:22:36Z

When I added the filter I received to My Filters, it was fixed

Test if it has flickering please

DaisukeDaisuke · 2023-11-23T00:23:42Z

Do I need to disable my current uasset solution when testing?

DaisukeDaisuke · 2023-11-23T00:26:31Z

I've disabled everything, but no ads are displayed and flickering occurs
There was also a blank space

open image

D4niloMR · 2023-11-23T00:30:12Z

There was also a blank space

Ok, so the :remove() seems necessary.

https://github.com/easylist/easylist/blob/edcb694e2ad52ad178b30b305d697b7ab079927c/easylist/easylist_specific_hide.txt#L4835

EasyList updated the filter, it's working?

DaisukeDaisuke · 2023-11-23T00:35:53Z

It does not work.
I either added one line of the EasyList filter I received to my filters or subscribed to the latest EasyList.

open image

D4niloMR · 2023-11-23T00:42:28Z

Well, so I can think in 2 filters:

twitter.com##[data-testid="cellInnerDiv"] > div:has([data-testid="top-impression-pixel"]):remove()

From AdGuard:
~~twitter.com##div[data-testid="cellInnerDiv"] > div > div[class] > div[class][data-testid="placementTracking"]:remove()~~

DaisukeDaisuke · 2023-11-23T00:49:59Z

twitter.com##[data-testid="cellInnerDiv"] > div:has([data-testid="top-impression-pixel"]):remove()

No ads, no flickering and white space, no ads next to images

twitter.com##div[data-testid="cellInnerDiv"] > div > div[class] > div[class][data-testid="placementTracking"]:remove()

Tweet corruption has occurred
Something went wrong. Try reloading.

open image

D4niloMR · 2023-11-23T00:58:13Z

twitter.com##div[data-testid="cellInnerDiv"] > div > div[class] > div[class][data-testid="placementTracking"]:remove()

Tweet corruption has occurred Something went wrong. Try reloading.

Strange, the other one is removing the div even higher than that filter and no issue.

Btw, since I can't test it, I won't create a PR. Anyone who can test and make sure that the first filter works without breakage is free to do it. (Or anybody who can make a better solution)

Don't do duplicate PR/issue.

stephenhawk8054 · 2023-11-23T05:47:57Z

@Yuki2718 So, does twitter.com##div[data-testid="cellInnerDiv"] > div > div[class] > div[class][data-testid="placementTracking"] work on your side?

D4niloMR · 2023-11-23T06:28:21Z

@stephenhawk8054

Those two filters are still relevant?
https://github.com/uBlockOrigin/uAssets/blob/master/filters/filters.txt#L3879#L3880

stephenhawk8054 · 2023-11-23T06:29:50Z

I don't use Twitter so I'm not sure

Yuki2718 · 2023-11-23T09:47:27Z

My account still doesn't get the new ad. But as AG added the rule and some people say it worked, I'll add the rule to EL and Quick. Does the rule replace twitter.com#?#[data-testid="primaryColumn"] [data-testid="cellInnerDiv"]:-abp-has([data-testid="top-impression-pixel"])?

Yuki2718 · 2023-11-23T10:24:13Z

The rule I mentioned above is just an areas of twitter.com##[data-testid="primaryColumn"] [data-testid="cellInnerDiv"]:has([data-testid="top-impression-pixel"]) in #20792 (comment)

Yuki2718 · 2023-11-23T10:47:03Z

@DaisukeDaisuke I wonder if twitter.com##div[data-testid="cellInnerDiv"] > div > div[class] > div[class][data-testid="placementTracking"] completely covers what were covered by twitter.com##[data-testid="primaryColumn"] [data-testid="cellInnerDiv"]:has([data-testid="top-impression-pixel"]). To test this, add

twitter.com#@?#[data-testid="primaryColumn"] [data-testid="cellInnerDiv"]:-abp-has([data-testid="top-impression-pixel"])
twitter.com#@#[data-testid="cellInnerDiv"] > div:has([data-testid="top-impression-pixel"]):remove()

to My filters and ignore the flickering issue. All I want to know is if no ads will be displayed.

Yuki2718 · 2023-11-23T10:49:28Z

I guess the flickering occurs only on the primaryColumn so limiting remove() to primaryColumn is not bad, unless twitter.com##div[data-testid="cellInnerDiv"] > div > div[class] > div[class][data-testid="placementTracking"]:remove() works fine, which was reportedly not.

DaisukeDaisuke · 2023-11-23T11:20:58Z

Sorry for the delay.
I added the following filter to My Filters and tested it after making sure that My Filters was checked

twitter.com#@?#[data-testid="primaryColumn"] [data-testid="cellInnerDiv"]:-abp-has([data-testid="top-impression-pixel"])
twitter.com#@#[data-testid="cellInnerDiv"] > div:has([data-testid="top-impression-pixel"]):remove()

All filters have been disabled: Ads will still be displayed

open Troubleshooting Information

uBlock Origin: 1.53.0
Chromium: 119
filterset (summary):
 network: 117
 cosmetic: 1250
 scriptlet: 8
 html: 0
listset (total-discarded, last-updated):
 removed:
  JPN-1: null
  easylist: null
  easyprivacy: null
  plowe-0: null
  ublock-badware: null
  ublock-filters: null
  ublock-privacy: null
  ublock-quick-fixes: null
  ublock-unbreak: null
  urlhaus-1: null
 default:
  user-filters: 1391-16, never
filterset (user): [array of 1396 redacted]
trustedset:
 added: [array of 10 redacted]
switchRuleset:
 added: [array of 19 redacted]
userSettings:
 largeMediaSize: 1
hiddenSettings: [none]
supportStats:
 allReadyAfter: 4949 ms
 maxAssetCacheWait: 67 ms
popupPanel:
 blocked: 0

open image

Only MyFilter and uAsset are enabled: no ads are displayed

open Troubleshooting Information

uBlock Origin: 1.53.0
Chromium: 119
filterset (summary):
 network: 15995
 cosmetic: 12316
 scriptlet: 19155
 html: 0
listset (total-discarded, last-updated):
 removed:
  JPN-1: null
  easylist: null
  easyprivacy: null
  plowe-0: null
  urlhaus-1: null
 default:
  user-filters: 1391-16, never
  ublock-badware: 7479-10, 5m
  ublock-filters: 35672-47, 5m
  ublock-privacy: 735-0, 5m
  ublock-quick-fixes: 197-72, 5m
  ublock-unbreak: 2151-2, 5m
filterset (user): [array of 1396 redacted]
trustedset:
 added: [array of 10 redacted]
switchRuleset:
 added: [array of 19 redacted]
userSettings:
 largeMediaSize: 1
hiddenSettings: [none]
supportStats:
 allReadyAfter: 4949 ms
 maxAssetCacheWait: 67 ms
popupPanel:
 blocked: 1
 network:
  google-analytics.com: 1
 extended:
  ##div[data-testid="cellInnerDiv"] > div > div[class] > div[class…
  ##[data-testid="trend"]:has-text(/Promoted|Gesponsert|Promociona…
  ##[data-testid="primaryColumn"] [data-testid="cellInnerDiv"] > d…

open image

Only "My filters" and "Adguard - ads" are enabled: no ads are displayed

open Troubleshooting Information

uBlock Origin: 1.53.0
Chromium: 119
filterset (summary):
 network: 20320
 cosmetic: 42840
 scriptlet: 18046
 html: 0
listset (total-discarded, last-updated):
 removed:
  JPN-1: null
  easylist: null
  easyprivacy: null
  plowe-0: null
  ublock-badware: null
  ublock-filters: null
  ublock-privacy: null
  ublock-quick-fixes: null
  ublock-unbreak: null
  urlhaus-1: null
 added:
  adguard-generic: 80313-480, never
 default:
  user-filters: 1391-16, never
filterset (user): [array of 1396 redacted]
trustedset:
 added: [array of 10 redacted]
switchRuleset:
 added: [array of 19 redacted]
userSettings:
 largeMediaSize: 1
hiddenSettings: [none]
supportStats:
 allReadyAfter: 4949 ms
 maxAssetCacheWait: 67 ms
popupPanel:
 blocked: 0
 extended:
  ##div[data-testid="cellInnerDiv"]:has(> div article[data-testid=…

open image

Only "My Filters" and EasyList" are enabled: Ads will be displayed

open Troubleshooting Information

uBlock Origin: 1.53.0
Chromium: 119
filterset (summary):
 network: 42747
 cosmetic: 30801
 scriptlet: 8
 html: 0
listset (total-discarded, last-updated):
 removed:
  JPN-1: null
  easyprivacy: null
  plowe-0: null
  ublock-badware: null
  ublock-filters: null
  ublock-privacy: null
  ublock-quick-fixes: null
  ublock-unbreak: null
  urlhaus-1: null
 default:
  user-filters: 1391-16, never
  easylist: 72196-15, never
filterset (user): [array of 1396 redacted]
trustedset:
 added: [array of 10 redacted]
switchRuleset:
 added: [array of 19 redacted]
userSettings:
 largeMediaSize: 1
hiddenSettings: [none]
supportStats:
 allReadyAfter: 4949 ms
 maxAssetCacheWait: 67 ms
popupPanel:
 blocked: 1
 network:
  ads-twitter.com: 1
 extended:
  ##div[data-testid="trend"]:has(path[d$="10H8.996V8h7v7z"])

open image

"My Filters", "uAsset", " Easy List" and "Adguard - ads" are enabled: no ads are displayed

open Troubleshooting Information

uBlock Origin: 1.53.0
Chromium: 119
filterset (summary):
 network: 91389
 cosmetic: 45120
 scriptlet: 19155
 html: 0
listset (total-discarded, last-updated):
 removed:
  JPN-1: null
  plowe-0: null
  urlhaus-1: null
 default:
  user-filters: 1391-16, never
  easylist: 75644-16, 2m
  easyprivacy: 32972-64, 2m
  ublock-badware: 7479-137, 2m
  ublock-filters: 35672-159, 2m
  ublock-privacy: 735-4, 2m
  ublock-quick-fixes: 198-72, 2m
  ublock-unbreak: 2151-32, 2m
filterset (user): [array of 1396 redacted]
trustedset:
 added: [array of 10 redacted]
switchRuleset:
 added: [array of 19 redacted]
userSettings:
 largeMediaSize: 1
hiddenSettings: [none]
supportStats:
 allReadyAfter: 4949 ms
 maxAssetCacheWait: 67 ms
popupPanel:
 blocked: 6
 network:
  twitter.com: 4
  ads-twitter.com: 1
  google-analytics.com: 1
 extended:
  ##div[data-testid="trend"]:has(path[d$="10H8.996V8h7v7z"])
  ##[data-testid="trend"]:has-text(/Promoted|Gesponsert|Promociona…
  ##[data-testid="primaryColumn"] [data-testid="cellInnerDiv"] > d…

open image

I deleted the post because there was a misunderstanding
This exclusion filter seems to only affect EasyList

Yuki2718 · 2023-11-23T12:12:55Z

Probably the latest EL is not yet available.

Only MyFilter and uAsset are enabled: no ads are displayed

Given this, I assume twitter.com##[data-testid="primaryColumn"] [data-testid="cellInnerDiv"]:has([data-testid="top-impression-pixel"]) can now be removed.

Yuki2718 · 2023-11-23T12:17:36Z

Done easylist/easylist@4cc5168 thanks for your cooperation.

DaisukeDaisuke · 2023-11-23T12:26:07Z

Thanks for the fix

The "uBlock filters – Quick fixes" I currently have is as follows, and no ads are displayed even if I use exclusion rules.

open Troubleshooting Information

uBlock Origin: 1.53.0
Chromium: 119
filterset (summary):
 network: 15994
 cosmetic: 12324
 scriptlet: 19155
 html: 0
listset (total-discarded, last-updated):
 removed:
  JPN-1: null
  easylist: null
  easyprivacy: null
  plowe-0: null
  urlhaus-1: null
 default:
  user-filters: 1390-16, never
  ublock-badware: 7479-10, now
  ublock-filters: 35679-47, now
  ublock-privacy: 735-0, now
  ublock-quick-fixes: 199-73, now
  ublock-unbreak: 2151-2, now
filterset (user): [array of 1395 redacted]
trustedset:
 added: [array of 10 redacted]
switchRuleset:
 added: [array of 19 redacted]
userSettings:
 largeMediaSize: 1
hiddenSettings: [none]
supportStats:
 allReadyAfter: 4265 ms
 maxAssetCacheWait: 55 ms
popupPanel:
 blocked: 1
 network:
  google-analytics.com: 1
 extended:
  ##[data-testid="trend"]:has-text(/Promoted|Gesponsert|Promociona…
  ##[data-testid="primaryColumn"] [data-testid="cellInnerDiv"] > d…

Yuki2718 · 2023-11-23T12:28:51Z

Yes, but we will keep the rule for the aforementioned flickering issue.

uBlock-user · 2023-11-23T14:26:12Z

Ok, maybe it still has ads in opened images though, but I can't test #20813 (comment)

e.g.: https://twitter.com/gorhill/status/996016461943574528/photo/1

Yes, I see ad on url ending with /photo/1, need to add -- twitter.com##div[class][data-testid="placementTracking"]:has(div[class][data-testid$="-impression-pixel"])

@Yuki2718

Yuki2718 · 2023-11-23T14:30:57Z

@uBlock-user So ##div[data-testid="cellInnerDiv"] > div > div[class] > div[class][data-testid="placementTracking"] doesn't match?

uBlock-user · 2023-11-23T14:32:36Z

Didn't test. The current filters do not work on pages ending with /photo/1 that I know for a fact.

Yuki2718 · 2023-11-23T14:37:09Z

I added the rule 5 hours ago f91aa32 BTW I wonder why nobody uses [data-testid="tweet"]. Shouldn't ##article[data-testid="tweet"]:has([data-testid="top-impression-pixel"]):remove() cover all?

uBlock-user · 2023-11-23T15:01:35Z

I added the rule 5 hours ago f91aa32

Doesn't apply on pages url ending with /photo/1

Shouldn't ##article[data-testid="tweet"]:has([data-testid="top-impression-pixel"]):remove() cover all?

No, it won't. There are 4 types of ads, see below --

Yours only covers one type, while mine covers all 4.

Yuki2718 · 2023-11-23T15:06:58Z

Okay, so changing to ##article[data-testid="tweet"]:has([data-testid$="-impression-pixel"]):remove() as you originally suggested makes it to work?

uBlock-user · 2023-11-23T15:17:37Z

I suggested twitter.com##div[class][data-testid="placementTracking"]:has(div[class][data-testid$="-impression-pixel"]), I haven't tested ##article[data-testid="tweet"]:has([data-testid$="-impression-pixel"]):remove() but if it works and doesn't break TL, then you may add it.

Yuki2718 · 2023-11-23T15:33:22Z

c3ae3a9

D4niloMR added 2 commits November 22, 2023 01:02

update

217a97f

fix flickering/ads in opened images

Update filters-2023.txt

d9597fd

D4niloMR added 2 commits November 22, 2023 10:09

Update filters-2023.txt

5ec1f96

Update quick-fixes.txt

2ec2308

Yuki2718 merged commit ef2a714 into uBlockOrigin:master Nov 22, 2023

D4niloMR deleted the patch-1 branch November 22, 2023 13:18

This comment was marked as off-topic.

Sign in to view

Yuki2718 added a commit that referenced this pull request Nov 23, 2023

address #20813 (comment)

a534905

Yuki2718 added a commit to easylist/easylist that referenced this pull request Nov 23, 2023

M: Address uBlockOrigin/uAssets#20813 (comment)

6d32dce

Update twitter: https://github.com/uBlockOrigin/uAssets/issues/20792 #20813

Update twitter: https://github.com/uBlockOrigin/uAssets/issues/20792 #20813

Conversation

D4niloMR commented Nov 22, 2023

D4niloMR commented Nov 22, 2023

Yuki2718 commented Nov 22, 2023 • edited

D4niloMR commented Nov 22, 2023 • edited

Yuki2718 commented Nov 22, 2023

D4niloMR commented Nov 22, 2023

Yuki2718 commented Nov 22, 2023 • edited

Yuki2718 commented Nov 22, 2023

D4niloMR commented Nov 22, 2023 • edited

DaisukeDaisuke commented Nov 22, 2023

D4niloMR commented Nov 23, 2023 • edited

DaisukeDaisuke commented Nov 23, 2023 • edited

D4niloMR commented Nov 23, 2023

DaisukeDaisuke commented Nov 23, 2023

DaisukeDaisuke commented Nov 23, 2023 • edited

D4niloMR commented Nov 23, 2023

DaisukeDaisuke commented Nov 23, 2023

D4niloMR commented Nov 23, 2023 • edited

DaisukeDaisuke commented Nov 23, 2023

D4niloMR commented Nov 23, 2023 • edited

stephenhawk8054 commented Nov 23, 2023

D4niloMR commented Nov 23, 2023

stephenhawk8054 commented Nov 23, 2023

Yuki2718 commented Nov 23, 2023 • edited

This comment was marked as off-topic.

Yuki2718 commented Nov 23, 2023

Yuki2718 commented Nov 23, 2023

Yuki2718 commented Nov 23, 2023

DaisukeDaisuke commented Nov 23, 2023 • edited

Yuki2718 commented Nov 23, 2023

Yuki2718 commented Nov 23, 2023

DaisukeDaisuke commented Nov 23, 2023

Yuki2718 commented Nov 23, 2023

uBlock-user commented Nov 23, 2023 • edited

Yuki2718 commented Nov 23, 2023

uBlock-user commented Nov 23, 2023

Yuki2718 commented Nov 23, 2023

uBlock-user commented Nov 23, 2023

Yuki2718 commented Nov 23, 2023

uBlock-user commented Nov 23, 2023

Yuki2718 commented Nov 23, 2023

Yuki2718 commented Nov 22, 2023 •

edited

D4niloMR commented Nov 22, 2023 •

edited

Yuki2718 commented Nov 22, 2023 •

edited

D4niloMR commented Nov 22, 2023 •

edited

D4niloMR commented Nov 23, 2023 •

edited

DaisukeDaisuke commented Nov 23, 2023 •

edited

DaisukeDaisuke commented Nov 23, 2023 •

edited

D4niloMR commented Nov 23, 2023 •

edited

D4niloMR commented Nov 23, 2023 •

edited

Yuki2718 commented Nov 23, 2023 •

edited

DaisukeDaisuke commented Nov 23, 2023 •

edited

uBlock-user commented Nov 23, 2023 •

edited