-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove-attr does not always work #1445
Comments
Attribute is removed correctly and then new is created with |
I can't find an element matching |
Loos to me this work better if the goal is to prevent fixed position:
|
Removed by Ruadlist. |
Duh sorry, I couldn't find it because |
Yes, that's the issue, also it wouldn't work with |
The rule To see the Previously, Add |
I will add support for mutation observer in |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Related issue: - uBlockOrigin/uBlock-issues#1445 A third (optional) argument has been added to `remove-attr` scriptlet, which can be one or more space-separated tokens dictating the behavior of the scriptlet: `stay`: This tells the scriplet to stay and act on DOM changes, whiĺe the default behavior is to act only once when the document becomes interactive. `complete`: This tells the scriplet to start acting only when the document is complete, i.e. once all secondary resources have been loaded, while the default is to start acting when the document is interactive -- which is earlier than when the document is complete. Example: ...##+js(remove-attr, class, .j-mini-player, stay)
@dimisa-RUAdList use a third argument to indicate to the
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Indeed, in version 1.32.5b8, the old rule |
Related issue: - uBlockOrigin/uBlock-issues#1445 A third (optional) argument has been added to `remove-attr` scriptlet, which can be one or more space-separated tokens dictating the behavior of the scriptlet: `stay`: This tells the scriplet to stay and act on DOM changes, whiĺe the default behavior is to act only once when the document becomes interactive. `complete`: This tells the scriplet to start acting only when the document is complete, i.e. once all secondary resources have been loaded, while the default is to start acting when the document is interactive -- which is earlier than when the document is complete. Example: ...##+js(remove-attr, class, .j-mini-player, stay) Related commits: - gorhill/uBlock@0f330c7 - gorhill/uBlock@5fa8739 Co-authored-by: Raymond Hill <rhill@raymondhill.net>
I think I found another case. Latest Google Chrome, Firefox, uBlock Origin 1.34.1rc0 default + RU AdList, Counters
If you refresh the page, then everything works as it should. |
This may need use
If you must support uBO older than 1.33.0 try: userResourcesLocation https://raw.githubusercontent.com/gorhill/uBlock/master/assets/resources/scriptlets.js uBO for Firefox legacy "preQuantum" (older than 1.16.4.28) maybe needed is build legacy file with older syntax for
If somebody still base on version older than 1.16.4.28 gorhill/uBlock-for-firefox-legacy@bba2397#diff-e6f727d342440f308271bdcac31b1830a345a5b30d13ae0349be72de85d97751 |
2 cases possibly related: and in the images on
The issue happens only in Chromium based browsers. I see that with |
@D4niloMR try |
Didn't work |
Yes, this is a known issue, discussed elsewhere I can't remember. The procedural cosmetic filters execute in the isolated world, and it seems with Chromium changing |
Discussed here : |
Example:
https://news.rambler.ru/conflicts/45563172-smi-politsiya-ottesnila-protestuyuschih-so-stupeney-kapitoliya/
When scrolling down the strings, the rule
rambler.ru##+js(remove-attr, class, .j-mini-player__video)
should fix the player in a static position, but for some reason this does not happen. In version 1.31.2, this problem is absent and the rule works fine.Config
Google Chrome 87.0.4280.88
Firefox 84.0.2
uBlock Origin v1.32.5b7 default + RU AdList, Counters
The text was updated successfully, but these errors were encountered: