-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code exception in contentscript.js (vAPI.setTimeout) when opening Chrome last session tabs that are partly cached #167
Comments
What was the URL (as asked in the template) associated with that dev console? |
OK I can reproduce with @uBlock-user screenshot, which shows a page from |
I will just post the STR here.
|
Looks like a Chromium issue to me. The exception occurs at this line. Yet this line can't possibly be reached if |
Indeed, I cannot reproduce on Nightly. |
Actually, investigating further I find that this line is being executed when I launch the browser -- so correction, that seems to be a uBO issue. I need to keep investigating why this happens. |
While investigating #164, I find that the issue was also present with Firefox:
|
Did it appear in the console ? I didn't see that when I tried to reproduce twice. |
I can't remember what I did for the error to be reported, I was really focused on investigating #164. Now I am unable to find steps to reproduce for Firefox. But given this is the same exact line, I can say that Firefox suffered the same issue. |
I guess this still haven't landed in stable version. The exception still happens and I see now 1 additional exception in
gorhill/uBlock@dc430f1 probably expected to fix it too. Actually seems |
No not yet.
Also that will happen if you have |
@gorhill I am experiencing similar errors on all URLs, using Chrome Canary Version 71.0.3556.0 on macOS 10.13.6 (17G65). Would you like me to open a separate issue? |
What version of uBO are you using? |
uBO version 1.16.18 |
The fix has not been released in a stable release yet, it's in the dev build. |
just did some basic tests with dev build and problem appears to be fixed. @gorhill thank you for the prompt response and your work on uBO 👍 |
version: 1.16.21.101 @gorhill It doesn't work if the details' privacy mode switch is on. |
I don't know what that means. Please opened a new issue with proper steps to reproduce if you think there is an issue. |
Of course you are allowed, otherwise you wouldn't be able to comment like you are doing now. As said, I need steps to reproduce, I can't reproduce error message with a private window. Please open a new issue with all the required details in the template. |
Well I wasn't yesterday. It was limited to the contributors. |
You are confusing https://github.com/gorhill/uBlock/issues with here -- here is to file issues, the other is reserved to contributors -- as explained in the top opened issue. |
I am running the latest uBlock Origin on latest stable Chrome, Win10.
I have noticed this issue for a while - when opening Chrome with last tabs session and some of the tabs url server is down, Chrome shows partly cached page (cached HTML, failing on all external files, JS, CSS, etc.) and console shows exception coming from chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/js/contentscript.js
fails in
where
vAPI
suddenly is undefined.The text was updated successfully, but these errors were encountered: