Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open Logger. Element picker/zapper does not switch tabs. (FF Mobile) #168

Closed
7 of 8 tasks
nyanpasu64 opened this issue Aug 14, 2018 · 19 comments
Closed
7 of 8 tasks
Labels
bug Something isn't working Firefox-Android specific to Android platform fixed issue has been addressed

Comments

@nyanpasu64
Copy link

nyanpasu64 commented Aug 14, 2018

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

When I open the uBlock "popup" button, the "element zapper and picker" buttons do not switch back to the page. The logger button is useless because it does not open a logger tab. The options button works fine.

A specific URL where the issue occurs

https://github.com/uBlockOrigin/uBlock-issues/issues/new

Steps to Reproduce

  1. Press the Firefpx dropdown menu, click uBlock Origin (#)
  2. On the new tab, click Lightning, Eyedropper, or Logger

Expected behavior:

typing is painful on mobile. considering Github does not show searching on the mobile site. I switched to the desktop site to search for duplicates, reported an indie on desire site, and now i suffer an unusable auto zoom out.

it works

Actual behavior:

see above

Your environment

  • uBlock Origin version: 1.16.16
  • Browser Name and version: Firefox Mobile 61.0.2
  • Operating System and version: Android 7.0
@gorhill
Copy link
Member

gorhill commented Aug 14, 2018

Was this for the tab already present when you launched the browser? There is a known issue with the first tab, you need to close it and create a new tab. Then all should work fine from there on.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1410749.

@uBlock-user uBlock-user added the Firefox-Android specific to Android platform label Aug 14, 2018
@gwarser
Copy link

gwarser commented Aug 14, 2018

Duplicate of gorhill/uBlock#3148

@gwarser gwarser marked this as a duplicate of gorhill/uBlock#3148 Aug 14, 2018
@gwarser
Copy link

gwarser commented Aug 14, 2018

This is new:

The logger button is useless because it does not open a logger tab.

Cannot reproduce. Edit: on my beta profile with uBO dev.

@gwarser
Copy link

gwarser commented Aug 14, 2018

Fresh profile of Firefox 61.0.2

Element picker is working when I switch tabs manually - nothing changed here.
Logger stopped working completely - no new tab, so no way to switch to it.

@gwarser
Copy link

gwarser commented Aug 14, 2018

When clicking Logger and Element picker buttons in popup:

00:29:20.614 Skrypty nie mogą zamykać okien, których nie otworzyły vapi-common.js:161:8
00:29:20.661 [Show/hide message details.] chrome.windows is undefined vapi-background.js:494
wrapper
moz-extension://c54f7323-0559-44b8-b0f4-d089dd9b569c/js/vapi-background.js:494:13
vAPI.tabs.open/<
moz-extension://c54f7323-0559-44b8-b0f4-d089dd9b569c/js/vapi-background.js:540:13
apply self-hosted:4549:5 applySafeWithoutClone
resource://gre/modules/ExtensionCommon.jsm:18:272
wrapPromise/<
resource://gre/modules/ExtensionCommon.jsm:38:256

Skrypty nie mogą zamykać okien, których nie otworzyły -> Scripts can not close windows that they have not opened

screenshot_20180815_002950

@gwarser
Copy link

gwarser commented Aug 14, 2018

Switching dom.allow_scripts_to_close_windows in about:config fixes this partially. Popup closes and Element picker can be used, but logger tab did not appear.

chrome.windows is undefined - this still appears in logger.

I'm sorry for spamming :)

@gorhill
Copy link
Member

gorhill commented Aug 14, 2018

How do you create a new profile with Firefox for Android?

@gorhill
Copy link
Member

gorhill commented Aug 14, 2018

Well apparently it's complicated. Anyways, Firefox for Android does not support the browser.windows API, so that would be the issue (https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/windows#Browser_compatibility).

gorhill added a commit to gorhill/uBlock that referenced this issue Aug 14, 2018
@gwarser
Copy link

gwarser commented Aug 14, 2018

How do you create a new profile with Firefox for Android?

I use beta daily, so I tested on fresh stable.

@gwarser
Copy link

gwarser commented Aug 14, 2018

@gorhill do you think window.open('','_self').close(); can be reverted in vapi-common.js to auto-close popup?

@gorhill
Copy link
Member

gorhill commented Aug 14, 2018

I rather not remove this one for now, it's just a warning at this point, I don't see it happening with Firefox stable (desktop).

@gorhill
Copy link
Member

gorhill commented Aug 14, 2018

Ugh.. maybe I misunderstood? This is about the warning in your screenshot above?

@gwarser
Copy link

gwarser commented Aug 14, 2018

Picker does not close popup on Android - no matter on which tab i use it. Logger button works fine - handled differently?

@gorhill
Copy link
Member

gorhill commented Aug 15, 2018

Picker does not close popup on Android

That's news to me, I am pretty sure it used too work. Maybe just forcing the target tab to be active after the picker has been injected would work.

@gwarser
Copy link

gwarser commented Aug 15, 2018

Yes, Popup "tab" disappears when I switch to the "page tab" manually. Problem is - it did not do this just after click on the button.

@nyanpasu64
Copy link
Author

@gorhill You can use Island to create a "work profile" aka sandboxed Firefox.

@gwarser
Copy link

gwarser commented Aug 15, 2018

Thank you, 1.16.17b6 fixed it. Picker still not switches to page when run on first page after Firefox start, but works for other tabs. I assume this is still this Android quirk from gorhill/uBlock#3148

@gwarser gwarser added the fixed issue has been addressed label Aug 15, 2018
@gwarser

This comment has been minimized.

@nyanpasu64
Copy link
Author

Thanks for the quick response time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Firefox-Android specific to Android platform fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants