-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anilibria.tv: breakage #2002
Comments
Update your browser, test disabling all other extensions |
@mapx- I've tried with an old browser (chrome 70) and I don't see any problem. @JAKill02 you have 130 user filters. Try without them. Go to the "Filter lists" tab and uncheck "My filters", click "Apply changes". Reload the website. If it's fixed, re-enable "My filters" and check them one by one. |
@gorhill The problem is observed in Chromium-versions 1.41.2 - 1.41.7b1 downloaded from here: https://github.com/gorhill/uBlock/releases and also in version 1.41.7.0 downloaded from here: |
From what I see so far, |
WTF? I was able to repro so I started bisecting lower and lower versions and then it stopped around 1.18 and I cannot reproduce anymore. |
This looks like this might be a lengthy investigation -- for now maybe just use |
@gwarser Are you using a new uBO install for each bisect to be sure the selfie is not being used every time? |
Ok, it breaks again after copy-pasting the URL from above message into new Chrome tab. Previously I did modified the filter in My filters by removing, saving and adding back characters and saving again, then force-reloading the tab. I have it broken in 1.20.0 right now. |
In fact, to fix the break, I had to edit the rule against disposable adservers, removing |
1.18 was fine, 1.19 - fine, back to 1.20.0 and it's fine ;D |
But I didn't use RUAdList. Furthermore, when I add tests to PSL library, all passes:
So I have no clue what is going on. |
Cannot reproduce if I clean browsing data and install fresh uBO. But updating all lists in fresh 1.41.5.2 install broke it. Something between 1.20 and 1.30? Hmmm, broken, not updating, malware lists (and "Online Malicious URL Blocklist" after assets update) prevent this from happening? After removing them, it's reproducible in 1.26.1b1. v1.22.5b4. v1.21.7b4. v1.20.0. Seems fine on v1.18.0 |
Introduced in gorhill/uBlock@4da3403 |
All tests pass with the bundled PSL. When I replace the bundled list with the latest one from PSL dot org, the two tests fail. |
|
I think the flaw in the code is that it's not ready to deal with related PSL entries which are spread throughout the list. |
Ok I found the issue. It's very unlikely to be triggered, but it can happen, and it did happen eventually as shown here. |
Related issue: - uBlockOrigin/uBlock-issues#2002 The code was testing only the LSB of a 32-bit integer to detect whether the current rule was a wildcard (`*`), while it had to compare against the whole 32-bit integer. The breakage occurred when the LSB of an offset to the character buffer happened to match the ASCII code of `*` (42, 0x2A). (An offset is used when a label is longer than 4 characters)
Related issue: - uBlockOrigin/uBlock-issues#2002 (comment) The code was testing only the LSB of a 32-bit integer to detect whether the current rule was a wildcard (`*`), while it had to compare against the whole 32-bit integer. The breakage occurred when the LSB of an offset to the character buffer happened to match the ASCII code of `*` (42, 0x2A). (An offset is used when a label is longer than 4 characters)
Related issue: - uBlockOrigin/uBlock-issues#2002 The code was testing only the LSB of a 32-bit integer to detect whether the current rule was a wildcard (`*`), while it had to compare against the whole 32-bit integer. The breakage occurred when the LSB of an offset to the character buffer happened to match the ASCII code of `*` (42, 0x2A). (An offset is used when a label is longer than 4 characters)
Prerequisites
URL address of the web page
https://www.anilibria.tv/release/platinum-end.html
Category
breakage
Describe the issue
completely breaks the appearance of the page.
Screenshot(s)
Screenshot(s)
Configuration
The text was updated successfully, but these errors were encountered: