Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element picker generate no match suggestion of filter to dom tree #2360

Closed
8 tasks done
krystian3w opened this issue Nov 13, 2022 · 1 comment
Closed
8 tasks done
Labels
bug Something isn't working fixed issue has been addressed

Comments

@krystian3w
Copy link

krystian3w commented Nov 13, 2022

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For any support, questions or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Element picker suggest no working filter (e.g. omit <a> from dom tree) on cosmetic list, also by sliders.

A specific URL where the issue occurs.

https://pl.wikipedia.org/wiki/Plik:Flag_of_Poland_(normative).svg

(this is HTML5 not real SVG direct url)

Steps to Reproduce

  1. open page

  2. try block Polish flag

  3. form suggested list click on someting very similar to "##[src="//upload.wikimedia.org/wikipedia/commons/thumb/e/e9/Flag_of_Poland_%28normative%29.svg/800px-Flag_of_Poland_%28normative%29.svg.png"]"

  4. filter no works due have invalid relations:

    ! invalid
    ###file > [src]
    !
    ! correct should be:
    ###file > a > [src]
    ! or
    ###file [src]

Expected behavior

Generated filter compatible to save by "Create"

Actual behavior

Generated filter incompatible to save by "Create"

screenshot
obraz

uBO version

1.45.3b0

Browser name and version

Firefox 107b9

Operating System and version

Windows 11

@gorhill
Copy link
Member

gorhill commented Nov 13, 2022

Regression from gorhill/uBlock@feaa338#diff-1d458db50255dc41294f582831b2dd40eb14ac9e636ba1a8e94b7163982a1e18.

There were so many changes in that commit that I accidentally committed at the same time changes which were not meant to be part of that commit, these were experimental changes to the picker.

@gwarser gwarser added the bug Something isn't working label Nov 13, 2022
gorhill added a commit to gorhill/uBlock that referenced this issue Nov 13, 2022
@gwarser gwarser added the fixed issue has been addressed label Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants