Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank uBO Thunderbird for macOS pane in versions after uBlock0_1.48.5b5.thunderbird.xpi #2591

Closed
5 tasks done
onePW opened this issue Apr 11, 2023 · 16 comments
Closed
5 tasks done
Labels
bug Something isn't working fixed issue has been addressed Thunderbird specific to Thunderbird

Comments

@onePW
Copy link

onePW commented Apr 11, 2023

Prerequisites

  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • using a new, unmodified browser profile.

Description

Updating the Thunderbird extension to any version beyond uBlock0_1.48.5b5.thunderbird.xpi results in a blank uBO GUI.

MacBookPro18,1 (Apple M1 Pro)
macOS Ventura 13.3.1
Mozilla Thunderbird 102.9.1

A specific URL where the issue occurs.

https://github.com/gorhill/uBlock/releases/download/1.48.5b7/uBlock0_1.48.5b7.thunderbird.xpi

Steps to Reproduce

  1. Mozilla's Thunderbird extension uBlock0_1.48.5b9.thunderbird.xpi has been installed from the official repository.
  2. Thunderbird has been quitted, followed by a normal relaunch.
  3. uBlock Origin has just been clicked in the attached .png file.

Expected behavior

uBO's GUI should open as in the attached:
Screenshot 2023-04-10 at 18 46 20

Actual behavior

Extension uBlock0_1.48.5b5.thunderbird.xpi has been removed and extension uBlock0_1.48.5b9.thunderbird.xpi has been installed:
Screenshot 2023-04-10 at 19 07 42

Configuration

macOS Ventura 13.3.1 has been started normally. Thunderbird 102.9.1 has been launched normally.

@onePW
Copy link
Author

onePW commented Apr 11, 2023

Question: If an EtreCheckPro 6.8.1 report file is attached, will the public have access?

@gorhill
Copy link
Member

gorhill commented Apr 11, 2023

Yes, this a public issue tracker.

@gorhill
Copy link
Member

gorhill commented Apr 11, 2023

I don't have Thunderbird 102 or MacOS, but I can't reproduce with Thunderbird 91 / Linux / uBO 1.48.5b9.

@gwarser gwarser added unable to reproduce cannot reproduce the issue Thunderbird specific to Thunderbird labels Apr 11, 2023
@gwarser
Copy link

gwarser commented Apr 11, 2023

Works fine for me in 102.9.1 (64-bit) on Linux.

@onePW
Copy link
Author

onePW commented Apr 11, 2023

Thunderbird 102.9.1 .pkg (from Mozilla's repository) was used to reinstall.
The issue first arose when the update was made to uBlock0_1.48.5b6.thunderbird.xpi. The issue is absent/resolved if a fallback is made back to uBlock0_1.48.5b5.thunderbird.xpi. Is any log written that might capture the failure state? What may I do to assist further?

@krystian3w
Copy link

krystian3w commented Apr 11, 2023

I tried manually update to 7 or 9:

https://github.com/gorhill/uBlock/releases/download/1.48.5b7/uBlock0_1.48.5b7.thunderbird.xpi
https://github.com/gorhill/uBlock/releases/download/1.48.5b9/uBlock0_1.48.5b9.thunderbird.xpi

and on both I reproduced blank pop-up on Windows 7 with TB 102:

image

TB 91 IMO lost emergency support at all (the solution is not to use a GNU/Linux package that some fan of a particular distribution maintains (like backport updates carried on TB 102 to 91) - until it extends support to compile versions for macOS and Windows 10.), TB 102 will lose it around the release of 117 Firefox (29 Agust - 1 September 2023).

@krystian3w
Copy link

krystian3w commented Apr 11, 2023

Apparently, the bug console complains about the alarms API (perhaps there is none for TB):

TypeError: browser.alarms is undefined vapi-background.js:148:1

gorhill/uBlock@bec6cad

But fine with standard Gecko (for Firefox) WebExtension.

@gwarser
Copy link

gwarser commented Apr 11, 2023

Why it works fine on Linux???

@gorhill
Copy link
Member

gorhill commented Apr 11, 2023

I upgraded my Thunderbird to latest 102.9.1 (with some pain points), and I can't reproduce an issue on my side. I do see that alarms does not appear to be supported as per https://webextension-api.thunderbird.net/en/latest/#firefox-webextension-apis-supported-by-thunderbird, but then I see no issue so far on my side.


In any case, I will check if alarms exists first and fallback onto something else if not.

@gwarser
Copy link

gwarser commented Apr 11, 2023

Seems fixed.

@gorhill
Copy link
Member

gorhill commented Apr 11, 2023

The reference link I posted above does not list alarms but then I just realize I didn't declare alarms in the manifest, maybe that is the actual issue...

@gwarser
Copy link

gwarser commented Apr 11, 2023

Yes, b9 works in debug mode if I put alarms in permissions.

gorhill added a commit to gorhill/uBlock that referenced this issue Apr 11, 2023
Relates issue:
- uBlockOrigin/uBlock-issues#2591

THe issue was simply that I had forgotten to add the `alarms`
permission to the manifest.
@gorhill
Copy link
Member

gorhill commented Apr 11, 2023

I wasn't able to test using "Load Temporary Add-on...", loading the result of ./tools/make-thunderbird fails for some reasons, Any idea?

@onePW
Copy link
Author

onePW commented Apr 12, 2023

Good news! Between today's release of Mozilla's Thunderbird 102.10.0 stable and uBlock0_1.48.5b10.thunderbird.xpi, uBO's GUI opens with normal behavior!

I am thankful to who or what has resolved this issue.

@gwarser
Copy link

gwarser commented Apr 12, 2023

@gorhill I did use the xpi, because I already had it in VM. Will try the source in a moment...
It works on Linux. Did you select the manifest when loading? Chrome requires folder, Firefox the manifest file.
In Win11 works too.
Build from master gorhill/uBlock@464119a

@krystian3w
Copy link

krystian3w commented Apr 12, 2023

The solution is not the 102.10.0 update, a snapshot from 102.9.1 with uBo 1.48.5b10 (The solution is a minor correction that went into the add-on's code):

image
Web filtering was not working during the outage.

In the test, I suggest you rename the iframe to detect cosmetic filtering (it looks like EasyList has removed the deprecated filters/baits).

image
optionally this can be addressed in filters-2023.txt

@gwarser gwarser added bug Something isn't working fixed issue has been addressed labels Apr 12, 2023
@gwarser gwarser closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed Thunderbird specific to Thunderbird
Projects
None yet
Development

No branches or pull requests

4 participants