Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:style for pseudo-classes and pseudo-elements are not displayed in the logger #2624

Closed
8 tasks done
dimisa-RUAdList opened this issue Apr 29, 2023 · 15 comments
Closed
8 tasks done
Labels
bug Something isn't working fixed issue has been addressed

Comments

@dimisa-RUAdList
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

:style for pseudo-classes and pseudo-elements are not displayed in the logger

A specific URL where the issue occurs.

https://software-on.com/

Steps to Reproduce

  1. Activate uBlock filters - Annoyances
  2. Open https://software-on.com/
  3. Open logger

Expected behavior

The logger should record the triggering of the rule: *::selection:style(background-color:#338FFF!important)

Actual behavior

The logger does not record the triggering of the rule: *::selection:style(background-color:#338FFF!important)

By the way, if you add an exception: software-on.com#@#*::selection:style(background-color:#338FFF!important) - then the logger will display it.

P.S. Very strange, but it seems that links to /dashboard.html#support.html do not work in version 1.49.3b2

uBO version

1.49.3b2

Browser name and version

Firefox 112.0.2

Operating System and version

Windows 7

@gwarser
Copy link

gwarser commented Apr 29, 2023

The filter is from uBlock filters – Annoyances?

P.S. Very strange, but it seems that links to /dashboard.html#support.html do not work in version 1.49.3b2

What do you mean?


Did it ever worked? Probably caused by inability to querySelector pseudoclasses.

@dimisa-RUAdList
Copy link
Author

Video

uBO support link

@gwarser
Copy link

gwarser commented Apr 29, 2023

This works fine on my side.

@dimisa-RUAdList
Copy link
Author

I found the reason why links to /dashboard.html#support.html become inactive. This happens if at least one default filter is disabled, for example: Peter Lowe’s Ad and tracking server list. Version 1.49.2 does not have this problem.

@gorhill
Copy link
Member

gorhill commented Apr 29, 2023

This was fixed yesterday with #2619 (comment)

@dimisa-RUAdList
Copy link
Author

I checked earlier versions, and indeed, styles for pseudo-elements in the logger are not registered there either.

@gorhill
Copy link
Member

gorhill commented Apr 29, 2023

I still think this needs investigating what can be done.

@gorhill gorhill reopened this Apr 29, 2023
@gwarser gwarser added the something to address something to address label Apr 29, 2023
gorhill added a commit to gorhill/uBlock that referenced this issue Apr 29, 2023
@gwarser gwarser added bug Something isn't working fixed issue has been addressed and removed something to address something to address labels Apr 30, 2023
@gwarser gwarser closed this as completed Apr 30, 2023
@dimisa-RUAdList
Copy link
Author

After the changes made in the logger, style hits were no longer registered, but this is observed only in certain cases.

For example: https://sportkp.ru/figurnoe-katanie/nid364185_au351auauau_cr351crcrcr_tuktamysheva-ispolnila-svoy-koronnyy-pryzhok-na-shou-v-kazakhstane-video

With the filter RU AdList must be registered: ##.l-wrapper > div[style^="position: absolute;"][style*="width: 30px;"][style*="height: 30px;"][style*="bottom: 13px;"][style*="left: 10px;"]:style(opacity: unset !important)

@gwarser
Copy link

gwarser commented May 2, 2023

I see no such element in dev tools.

Play button in the player which load with delay. (also search box in Fx devtools is too aggressive with hints)

@gwarser gwarser reopened this May 2, 2023
@dimisa-RUAdList
Copy link
Author

There is a simpler example: https://www.fontanka.ru/2023/02/23/72085622/

@gorhill
Copy link
Member

gorhill commented May 2, 2023

Deleted my previous comment, I was looking at .l-wrapper itself instead of .l-wrapper > div.

So I simply used document.querySelector('.l-wrapper > div[style^="position: absolute;"][style*="width: 30px;"][style*="height: 30px;"][style*="bottom: 13px;"][style*="left: 10px;"]'); in the dev console, and it returns null, so nothing is matching.


I don't get hits with 1.49.2, so it's just the webpage which changed?

@dimisa-RUAdList
Copy link
Author

You can add an exception: #@#.l-wrapper > div[style^="position: absolute;"][style*="width: 30px;"][style*="height: 30px;"][style*="bottom: 13px;"][style*="left: 10px;"]:style(opacity: unset !important) - and then the play button will disappear and will be visible only when you hover over the player window.

@gorhill
Copy link
Member

gorhill commented May 2, 2023

Ok I see, it's in one of the about:blank frame. I don't think it's related to the changes here though, 1.49.2 has the same issue, which is that uBO finds no match because the style property changes on mouse hover.

@dimisa-RUAdList
Copy link
Author

I rolled back to version 1.40.8 step by step and still do not see this rule in the registration logger. Maybe it was never shown there?

@gorhill
Copy link
Member

gorhill commented May 8, 2023

The original issue is fixed, the other reported issue is completely unrelated, so closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants