Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk.com: nuisance (href-sanitizer) #2678

Closed
8 of 9 tasks
NotErix1 opened this issue May 30, 2023 · 12 comments
Closed
8 of 9 tasks

vk.com: nuisance (href-sanitizer) #2678

NotErix1 opened this issue May 30, 2023 · 12 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@NotErix1
Copy link

NotErix1 commented May 30, 2023

Prerequisites

  • I read and understand the policy about what is a valid filter issue.
  • I verified that this issue is not a duplicate. (Use this button to find out.)
  • I forced an update of my filter lists. (Click the "Purge all caches" button while holding the 'Shift' key, then click the "Update now" button.)
  • I did not remove any of the default filter lists, or I have verified that the issue was not caused by removing any of the default lists.
  • I did not enable external filter lists, or I have verified that the issue still occurs without enabling external filter lists.
  • I do not have custom filters/rules, or I have verified that the issue still occurs without custom filters/rules.
  • I am not using uBlock Origin (uBO) along with other content blocker extensions.
  • I have verified that the web browser's built-in blocker or DNS blocking (standalone or through a VPN) is not causing the issue.
  • I did not answer truthfully to ALL the above checkpoints.

URL address of the web page

https://vk.com/wall-22781583_4044901

Category

nuisance

Description

Attached link to dtf website not opening when uBlock is enabled

Screenshot(s)

Screenshot(s)

Configuration

uBlock Origin: 1.49.2
Chromium: 113
filterset (summary): 
 network: 111105
 cosmetic: 61350
 scriptlet: 22240
 html: 0
listset (total-discarded, last-updated): 
 added: 
  ublock-annoyances: 5084-10, 7m
 default: 
  user-filters: 11-3, never
  RUS-0: 39539-10, 1d.19h.14m
  easylist: 66390-71, 3d.23h.53m
  easyprivacy: 31788-158, 1d.21h.16m
  plowe-0: 3735-949, 9d.16h.19m
  ublock-abuse: 70-1, 5d.20h.1m
  ublock-badware: 7156-129, 2d.23h.22m
  ublock-filters: 33250-136, 2d.23h.21m
  ublock-privacy: 382-75, 5d.20h
  ublock-quick-fixes: 324-25, 6m
  ublock-unbreak: 2017-35, 2d.23h.20m
  urlhaus-1: 6713-0, 19h.54m
filterset (user): [array of 11 redacted]
trustedset: 
 added: [array of 1013 redacted]
 removed: 
  edge-scheme
switchRuleset: 
 added: [array of 26 redacted]
modifiedUserSettings: [none]
modifiedHiddenSettings: [none]
supportStats: 
 allReadyAfter: 202 ms (selfie)
 maxAssetCacheWait: 89 ms
popupPanel: 
 blocked: 8
 network: 
  vk.com: 1
  mail.ru: 3
  tns-counter.ru: 2
  vk-portal.net: 2
 cosmetic: 
  ###ads_left
  ###system_msg
  #@#div[id$=\"notifiers_wrap\"]
@NotErix1
Copy link
Author

UPD: Проблема вызвана «RUS: RU AdList»

@mapx-
Copy link

mapx- commented May 30, 2023

read:
https://github.com/easylist/ruadlist/wiki/RU-Adlist-links

@dimisa-RUAdList

@stephenhawk8054
Copy link
Member

Looks like it's related to this filter in Ru Adlist?

vk.com##+js(href-sanitizer, a[href^="/away.php?to="][title], [title])

The link in the post changes to other links.

@dimisa-RUAdList
Copy link

@gorhill
It seems that the scriptlet does not fulfill this condition:

  • The text content of the element is a valid https-based URL

https://github.com/gorhill/uBlock/wiki/Resources-Library#href-sanitizerjs-

Temporary fix: easylist/ruadlist@aefe8db

@mapx- mapx- transferred this issue from uBlockOrigin/uAssets May 30, 2023
@mapx- mapx- reopened this May 30, 2023
gorhill added a commit to gorhill/uBlock that referenced this issue May 30, 2023
@gorhill
Copy link
Member

gorhill commented May 30, 2023

I have added a capability to href-sanitizer, which seemed trivial enough to implement. If the second argument, source, starts with ?, the scriptlet will look up the value of the search parameter which name is what comes after the ?. So in the current case, the following scriptlet would skip the redirection:

vk.com##+js(href-sanitizer, a[href^="/away.php?to="][title], ?to)

dimisa-RUAdList pushed a commit to easylist/ruadlist that referenced this issue May 30, 2023
@dimisa-RUAdList
Copy link

In my opinion, everything is great!

@MasterKia

This comment was marked as resolved.

@uBlock-user
Copy link
Contributor

@MasterKia hamtamovie.im##+js(href-sanitizer, a[href^="https://hamtamovie.im/dl/?url="][href], ?url)

@uBlock-user uBlock-user added enhancement New feature or request fixed issue has been addressed labels Jun 2, 2023
@MasterKia
Copy link
Member

MasterKia commented Jun 2, 2023

@uBlock-user You solved mozilla.org's problem too:
mozilla.org##+js(href-sanitizer, a[href^="https://app.adjust.com/"][href*="?redirect="], ?redirect)

https://www.mozilla.org/en-US/firefox/browsers/mobile/android/

@MasterKia MasterKia changed the title vk.com: nuisance vk.com: nuisance (href-sanitizer) Oct 5, 2023
@MasterKia
Copy link
Member

MasterKia commented Oct 5, 2023

Can this be fixed?

https://www.howtogeek.com/android-browsers-that-support-extensions/#firefox

https://www.anrdoezrs.net/links/3607085/type/dlg/sid/UUhtgUeUpU2000184/https://play.google.com/store/apps/details?id=org.mozilla.firefox

Screenshot(s)

2023-10-05_125928
2023-10-05_125944

uBlock Origin: 1.52.2
Chromium: 117
filterset (summary):
 network: 123656
 cosmetic: 106250
 scriptlet: 26465
 html: 0
listset (total-discarded, last-updated):
 added:
  fanboy-cookiemonster: 48478-229, now
  ublock-annoyances: 5507-59, now
  ublock-cookies-easylist: 319-319, now
 default:
  user-filters: 1-0, never
  RUS-0: 39958-9, now
  easylist: 71545-40, now
  easyprivacy: 33209-154, now
  plowe-0: 3720-1067, now
  ublock-badware: 7138-133, now
  ublock-filters: 34935-185, now
  ublock-privacy: 557-7, now
  ublock-quick-fixes: 156-20, now
  ublock-unbreak: 2133-35, now
  urlhaus-1: 11125-0, now
filterset (user): [array of 1 redacted]
userSettings:
 advancedUserEnabled: true
 contextMenuEnabled: false
 showIconBadge: false
hiddenSettings:
 filterAuthorMode: true
 popupPanelHeightMode: 1
supportStats:
 allReadyAfter: 894 ms (selfie)
 maxAssetCacheWait: 521 ms
popupPanel:
 blocked: 16
 network:
  howtogeek.com: 2
  ad.gt: 1
  adlightning.com: 1
  adsninja.ca: 2
  amazon-adsystem.com: 1
  google-analytics.com: 1
  google.com: 1
  googlesyndication.com: 1
  googletagmanager.com: 1
  googletagservices.com: 1
  imasdk.googleapis.com: 1
  privacymanager.io: 2
  unpkg.com: 1
 extended:
  ##[id^="div-gpt-ad"]:not([style^="width: 1px; height: 1px; posit…
  ##div[id^="div-gpt-"]:not([style^="width: 1px; height: 1px; posi…
  ##.adsninja-ad-zone
  ##.ad-current
  ##.ad-zone-container
  ##.ad-zone:not(.textads)
  #@#[id^="div-gpt-ad"]
  #@#div[id^="div-gpt-"]
  #@#.ad-zone
  ##+js(remove-node-text, script, /typeof [a-z]\.cmd\.unshift/, co…
  ##+js(trusted-set-cookie, SOCS, CAESHAgBEhJnd3NfMjAyMzA2MTItMF9S…
  ##+js(set-constant, rwt, noopFunc)

Originally posted by @dportvine in uBlockOrigin/uAssets#19543 (comment)

@MasterKia MasterKia reopened this Oct 5, 2023
@gorhill
Copy link
Member

gorhill commented Oct 5, 2023

This is straying too far away from safe rewriting of the URL, and to keep overloading this scriptlet with new approaches to deal with is not the way to go.

@gorhill gorhill closed this as completed Oct 5, 2023
iam-py-test added a commit to iam-py-test/iam-py-test.github.io that referenced this issue Oct 5, 2023
@MasterKia
Copy link
Member

Another example similar to #2678 (comment):

https://addons.mozilla.org/en-US/firefox/addon/chatgpt-for-google/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search

The homepage and support site links have click trackers:

https://prod.outgoing.prod.webservices.mozgcp.net/v1/[...]/https%3A//chatgpt4google.com

https://prod.outgoing.prod.webservices.mozgcp.net/v1/[...]/https%3A//chatgpt4google.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

7 participants