Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance 'googlesyndication_adsbygoogle.js' redirection resource #2773

Closed
8 tasks done
piquark6046 opened this issue Aug 10, 2023 · 7 comments
Closed
8 tasks done

Enhance 'googlesyndication_adsbygoogle.js' redirection resource #2773

piquark6046 opened this issue Aug 10, 2023 · 7 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@piquark6046
Copy link
Member

piquark6046 commented Aug 10, 2023 •
edited

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Screenshot from 2023-08-10 16-51-08

They checks that google-adsense or googlesyndication exists in XMLHttpRequest.prototype.responseText via jQuery.ajax.done.

A specific URL where the issue occurs.

https://aagag.com/issue/?idx=1275471

Steps to Reproduce

Pleas visit the website.
If you use List-KR filters list or uAssets filters lists:

@@||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js$xhr,from=aagag.com,badfilter

Expected behavior

Return AdGuard's googlesyndication-adsbygoogle-like redirection resource.

Actual behavior

The returned redirection resource is not much like the real thing.

uBO version

1.51.0

Browser name and version

Mozilla Firefox Developer Edition 117.0b5

Operating System and version

Ubuntu 23.04
@piquark6046 piquark6046 changed the title Enhance Enhance 'googlesyndication_adsbygoogle.js' redirection resource Aug 10, 2023
@gorhill
Copy link
Member

gorhill commented Aug 10, 2023

The website seems to work fine with or without the exception filter. What am I suppose to see?

@piquark6046
Copy link
Member Author

piquark6046 commented Aug 10, 2023 •
edited

@gorhill Please test this URL with a Chromium-based web browser.
If you apply a googlesyndication_adsbygoogle.js redirection filter and disable the exception filter, you will see the anti-adblock on aagag.com.

@gorhill
Copy link
Member

gorhill commented Aug 10, 2023

It's what I am seeing when navigating to https://aagag.com/issue/?idx=1275703:

Screenshot

Screenshot

@piquark6046
Copy link
Member Author

I meant #comment.icomment.

Screenshot

image

gorhill added a commit to gorhill/uBlock that referenced this issue Aug 10, 2023
@gorhill
Add commented keywords to googlesyndication_adsbygoogle.js scriptlet
7bcc340 
Related issue:
uBlockOrigin/uBlock-issues#2773
@gwarser gwarser added the enhancement New feature or request label Aug 11, 2023
@gwarser
Copy link

gwarser commented Aug 11, 2023

Did not help?

@piquark6046
Copy link
Member Author

I think that resolving this issue with commented keywords will not help if they try to access its properties or use regexp.

@gorhill
Copy link
Member

gorhill commented Aug 11, 2023 •
edited

If we have actual cases where this does not work, will address these, until then no need to try to solve speculated issues because in the end there is always a way to get around anyways so nothing will ever be good enough if we imagine what can be done to work around.

gorhill added a commit to gorhill/uBlock that referenced this issue Aug 14, 2023
@gorhill
Imrpove no-xhr-if scriptlet
bf591d9 
Related issue:
uBlockOrigin/uBlock-issues#2773

The `randomize` paramater introduced in 418087de9c
is now named `directive`, and beside the `true` value which is meant
to respond with a random 10-character string, it can now take the
following value:

  war:[web_accessible_resource name]

In order to mock the XHR response with a web accessible resource. For
example:

  piquark6046.github.io##+js(no-xhr-if, adsbygoogle.js, war:googlesyndication_adsbygoogle.js)

Will cause the XHR performed by the webpage to resolve to the content
of `/web_accessible_resources/googlesyndication_adsbygoogle.js`.

Should the resource not exist, the empty string will be returned.
@uBlock-user uBlock-user added the fixed issue has been addressed label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gorhill @gwarser @uBlock-user @piquark6046