Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBo redirects file:/// urls to http://file-scheme on reload #2774

Closed
8 tasks done
iam-py-test opened this issue Aug 10, 2023 · 1 comment
Closed
8 tasks done

uBo redirects file:/// urls to http://file-scheme on reload #2774

iam-py-test opened this issue Aug 10, 2023 · 1 comment
Labels
bug Something isn't working fixed issue has been addressed

Comments

@iam-py-test
Copy link
Contributor

iam-py-test commented Aug 10, 2023

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Whenever you change any of the per-site-switches other than the no-popups one, disable/enable uBo via the power button, or click to block/noop something in the dynamic filtering from the popup, uBo asks to reload the page (this makes sense).
However, if I do that on a local file (file:///), and let uBo reload it, I end up at http://file-scheme/.
Calling the browser's tabs.reload function does not cause this problem, so I assume this is uBo-specific.
Looking into uBo's code, it seems the problem is with uBo setting popupData.pageURL to http://file-scheme/, as that is what is sent in the reloadTab message from the popup:
image

A specific URL where the issue occurs.

N/A, as it is a local file

Steps to Reproduce

  1. Create a HTML file and open it in the browser with uBo OR go to any file:/// URL (i.e. file:///C:/ on Windows, maybe file:///bin on GNU/Linux)
  2. Change any of the per-site-switches which require a reload
  3. Let uBo reload the page
  4. Notice that end up on http://file-scheme/

Expected behavior

The page is reloaded

Actual behavior

The user is redirected to http://file-scheme/
The reload button in the logger seems unaffected.

uBO version

uBlock Origin 1.51.0 (but can reproduce on the latest beta)

Browser name and version

Mozilla Firefox 116.0.2 (64-bit)

Operating System and version

Windows 10 Home 22H2

@uBlock-user uBlock-user added the Firefox specific to Firefox label Aug 10, 2023
gorhill added a commit to gorhill/uBlock that referenced this issue Aug 10, 2023
@gorhill gorhill removed the Firefox specific to Firefox label Aug 10, 2023
@gwarser gwarser added the bug Something isn't working label Aug 10, 2023
@iam-py-test
Copy link
Contributor Author

iam-py-test commented Aug 10, 2023

1.51.1b14 appears to fix the issue for me.
Thanks

@uBlock-user uBlock-user added the fixed issue has been addressed label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants