Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken page saving (ctrl-s) #3176

Closed
9 tasks done
anedroid opened this issue Mar 19, 2024 · 4 comments
Closed
9 tasks done

Broken page saving (ctrl-s) #3176

anedroid opened this issue Mar 19, 2024 · 4 comments
Labels
external issue involving an external factor Firefox specific to Firefox

Comments

@anedroid
Copy link

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

While page saving downloads all the required resourced, URLs doesn't get changed to point to local file, as browser does by default.

A specific URL where the issue occurs.

https://mermaid.js.org/syntax/flowchart.html

Steps to Reproduce

  1. Open a page
  2. Press ctrl-s
  3. Choose "complete webpage"
  4. Open the downloaded file

Expected behavior

You should see how the page was looking like at the moment of saving.

Actual behavior

Opened page lack styles, fonts, some images, etc.

uBO version

1.56.0

Browser name and version

Firefox 123.0.1

Operating System and version

Fedora Linux 39 (Cinnamon) x86_64

@gorhill
Copy link
Member

gorhill commented Mar 19, 2024

Unable to reproduce using default settings/lists.

@gorhill gorhill added the unable to reproduce cannot reproduce the issue label Mar 19, 2024
@gwarser
Copy link
Member

gwarser commented Mar 19, 2024

+0
/script.tagged-events.outbound-links.js
--
mermaid.js.org
0,3
get
script
https://p.mermaid.live/js/script.tagged-events.outbound-links.js

Duplicate of #986 ?


Page looks fine on my side. @anedroid share your troubleshooting info from that page (click the chat button in uBO popup, then in new window "Troubleshooting Information" on the bottom).

@gwarser
Copy link
Member

gwarser commented Mar 19, 2024

Ah! Page is broken when you retry, because then only main html is saved (that's why it succeeds). Firefox bug.

@gorhill
Copy link
Member

gorhill commented Mar 19, 2024

when you retry

I can reproduce after clicking the retry button.

I can also reproduce similar issue of improper saving without uBO, after setting Firefox Enhanced Tracking Protection to Strict for this webpage: https://resobscura.substack.com/p/he-spoke-of-computers-with-some-awe. Seems to work at first, but an error is reported and clicking the retry button causes an improperly saved webpage.

Closing as a browser issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1445211.

@gorhill gorhill closed this as completed Mar 19, 2024
@MasterKia MasterKia added external issue involving an external factor Firefox specific to Firefox and removed unable to reproduce cannot reproduce the issue labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external issue involving an external factor Firefox specific to Firefox
Projects
None yet
Development

No branches or pull requests

4 participants