Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox indicates that the webpages download failed. #986

Closed
8 tasks done
S3ndG opened this issue Apr 11, 2020 · 4 comments
Closed
8 tasks done

Firefox indicates that the webpages download failed. #986

S3ndG opened this issue Apr 11, 2020 · 4 comments
Labels
external issue involving an external factor Firefox specific to Firefox

Comments

@S3ndG
Copy link

S3ndG commented Apr 11, 2020

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

When I try to save a FULL webpage (with the pictures, not just the html part) with some blocked stuff inside, Firefox tells me that the download failed. Which is wrong.

A specific URL where the issue occurs

https://www.freenews.fr/freenews-edition-nationale-299/une-collecte-organisee-pour-fabriquer-des-visieres-de-protection-en-3d-par-nos-makers-et-pour-les-soignants

Steps to Reproduce

  1. Go to that webpage.
  2. Do Ctrl+S, select FULL webpage
  3. Click on Save

Expected behavior:

The download icon of firefox should be blue and indicates that the download succeded.

Actual behavior:

The download icon shows an orange circle and says it failed.

Your environment

  • uBlock Origin version: 1.26.0
  • Browser Name and version: firefox 75.0 64 bits
  • Operating System and version: windows 10 64 bits
@uBlock-user uBlock-user added Firefox specific to Firefox something to address something to address labels Apr 11, 2020
@gwarser
Copy link
Member

gwarser commented Apr 11, 2020

Expected behavior:

The download icon of firefox should be blue and indicates that the download succeded.

Everything what is blocked is blocked, everything allowed is allowed?

I that case it's not uBO issue, but Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1445211

@uBlock-user uBlock-user added external issue involving an external factor and removed something to address something to address labels Apr 11, 2020
@gorhill gorhill closed this as completed Apr 15, 2020
@gwarser
Copy link
Member

gwarser commented Apr 16, 2020

@gorhill, from bug 1445211#c41:

We won't know the (internal equivalent of the) parentFrameId here, at least for now. It's possible the refactor in bug 1576188 will help with that though.

Something specific that would help? [What would help uBO to correctly whitelist.]

@gorhill
Copy link
Member

gorhill commented Apr 16, 2020

I don't see an issue, when I disable uBO on https://www.freenews.fr/, "Save As..." works without error on my side. uBO uses the documentUrl property when tabId is -1. I don't see parentFrameId being used in uBO when tabId is -1.

@gorhill
Copy link
Member

gorhill commented Apr 16, 2020

And to be sure, I put breakpoints in code paths where uBO cancels network requests or change response headers and none were taken when I saved the document after I disabled uBO on that site. So I can't reproduce the error reported by the user , except when I do not disable uBO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external issue involving an external factor Firefox specific to Firefox
Projects
None yet
Development

No branches or pull requests

4 participants