Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element Picker Appearance Delayed #393

Closed
6 of 8 tasks
yourduskquibbles opened this issue Jan 23, 2019 · 6 comments
Closed
6 of 8 tasks

Element Picker Appearance Delayed #393

yourduskquibbles opened this issue Jan 23, 2019 · 6 comments
Labels
bug Something isn't working fixed issue has been addressed

Comments

@yourduskquibbles
Copy link

yourduskquibbles commented Jan 23, 2019 •
edited

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

The element picker takes about 5-10 seconds before appearing on https://newstorycharity.org/careers/pm/

I'm not sure if this is a bug with uBO or the site intentionally crippling the element picker somehow but I think it is a bug since I tried disabling JS on the site via uBO (Step 2 below) and picker still doesn't appear immediately.

A specific URL where the issue occurs

https://newstorycharity.org/careers/pm/

Steps to Reproduce

  1. Navigate to https://newstorycharity.org/careers/pm/
  2. (Optional step) Disable site javascript in uBO and reload https://newstorycharity.org/careers/pm/
  3. Enter element picker mode
  4. Notice background screen turns gray like element picker should be possible but can't choose any elements on page for ~10 seconds.

Expected behavior:

Element picker appears immediately

Actual behavior:

Element picker doesn't appear for a few seconds. The behavior happens in both firefox and chrome for me, but below gif is taken in chrome with only uBO with default filter lists & uBlock Origin Extra installed.

elementpicker

Your environment

  • uBlock Origin version: uBlock Origin 1.17.7rc3 with default settings & filter lists
  • Browser Name and version: Chrome Version 72.0.3626.64 (Official Build) beta (64-bit) & Firefox 64.0.2 (64-bit)
  • Operating System and version: Windows 10 64 bit
@uBlock-user
Copy link
Contributor

Can't reproduce.

@uBlock-user uBlock-user added the unable to reproduce cannot reproduce the issue label Jan 23, 2019
@gorhill
Copy link
Member

gorhill commented Jan 23, 2019

Sorry, I can reproduce, using the picker from the popup panel. I originally tried with the context menu.

@gorhill gorhill removed the unable to reproduce cannot reproduce the issue label Jan 23, 2019
@gorhill
Copy link
Member

gorhill commented Jan 23, 2019

The site modifies uBO's own pointer-events style:

a

@uBlock-user
Copy link
Contributor

uBlock-user commented Jan 23, 2019 •
edited

site modifies uBO's own pointer-events style:

Wasn't that fixed recently when another site made changes to pointer-events ?

gorhill added a commit to gorhill/uBlock that referenced this issue Jan 23, 2019
@gorhill
Ensure pointer-events style is set to auto at element picker launch
b214ec1 
Related issue:
- uBlockOrigin/uBlock-issues#393
@gorhill
Copy link
Member

gorhill commented Jan 23, 2019

Similar but not exactly the same: #380

@uBlock-user uBlock-user added bug Something isn't working fixed issue has been addressed and removed bug Something isn't working labels Jan 24, 2019
@krystian3w
Copy link

krystian3w commented Jan 24, 2019 •
edited

Another - site with filter grayscale on <html> element.

https://bugzilla.mozilla.org/show_bug.cgi?id=1426919

html {
   filter: grayscale(1)
}

When bug all fixed position elements (and also element picker after indicated element and try again point the item down after scrolling through one screen of text).

@uBlock-user uBlock-user added the bug Something isn't working label May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gorhill @uBlock-user @yourduskquibbles @krystian3w