Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse search string as plaintext to avoid doubling \ #658

Closed
7 of 8 tasks
mikhaelkh opened this issue Jul 5, 2019 · 2 comments
Closed
7 of 8 tasks

Parse search string as plaintext to avoid doubling \ #658

mikhaelkh opened this issue Jul 5, 2019 · 2 comments
Labels
bug Something isn't working external issue involving an external factor fixed issue has been addressed

Comments

@mikhaelkh
Copy link

mikhaelkh commented Jul 5, 2019

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Filters that contains \ (e.g. google.*###center_col > #\5f Emc in uBlock FIlters) can't be found w\o replacing \ with \\ in search field.

Steps to Reproduce

  1. Open uBlock filters in Dashboard
  2. Search google.*###center_col > #\5f Emc - 0 matches
  3. Search google.*###center_col > #\\5f Emc - 1 match, line 16

Your environment

  • uBlock Origin version: 1.20.3b4
  • Browser Name and version: Chromium 75.0.3770.100 x64
  • Operating System and version: Windows 10 v1607 x64
@uBlock-user uBlock-user added the bug Something isn't working label Jul 6, 2019
@gorhill
Copy link
Member

gorhill commented Jul 7, 2019

Related: codemirror/codemirror5#5428

@gorhill
Copy link
Member

gorhill commented Jul 7, 2019

Related commit: codemirror/codemirror5@eb0ef20. Reading through the related issue, I am not too sure I understand why this was designed to way it is. In any case since I have borrowed and modified content of CodeMirror's search.js, I can fix on uBO's side without having to ask for a change on CodeMirror's side.

gorhill added a commit to gorhill/uBlock that referenced this issue Jul 7, 2019
@uBlock-user uBlock-user added the external issue involving an external factor label Jul 7, 2019
@uBlock-user uBlock-user added the fixed issue has been addressed label Jul 7, 2019
gorhill added a commit to gorhill/uBlock that referenced this issue Jul 11, 2019
hawkeye116477 pushed a commit to hawkeye116477/uBlock-for-firefox-legacy that referenced this issue Dec 21, 2020
hawkeye116477 pushed a commit to hawkeye116477/uBlock-for-firefox-legacy that referenced this issue Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external issue involving an external factor fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants