Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default filter list for RU locale #749

Closed
8 tasks done
ameshkov opened this issue Oct 9, 2019 · 7 comments
Closed
8 tasks done

Default filter list for RU locale #749

ameshkov opened this issue Oct 9, 2019 · 7 comments
Labels
fixed issue has been addressed

Comments

@ameshkov
Copy link

ameshkov commented Oct 9, 2019

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Currently, uBlock Origin enables two different filter lists for users with "RU" locale: AdGuard Russian filter and RU AdList.

The problem is that these are two independent and not really compatible filter lists. Having both of them enabled leads to random issues. For instance, it often happens on websites that do heavy circumvention, and the reason is different incompatible approaches to handle such issues.

Proposed solution: there should be just one default "RU" filter list in uBlock Origin. IMO, it should be RU AdList, @dimisa-RUAdList does a great job of making it compatible with uBlock Origin.

I was asked to report this issue by the maintainers of these filter lists (@dimisa-RUAdList and @Alex-302), and they both agree on the proposed solution.

Your environment

  • uBlock Origin version: v1.22.4
  • Browser Name and version: any
  • Operating System and version: any
@dimisa-RUAdList
Copy link

I would also add a warning about possible conflicts, for those cases when users activate these two filters manually.

@uBlock-user uBlock-user added something to address something to address filterlist a filter list issue labels Oct 9, 2019
@gorhill
Copy link
Member

gorhill commented Oct 9, 2019

Proposed solution: there should be just one default "RU" filter list in uBlock Origin. IMO, it should be RU AdList, @dimisa-RUAdList does a great job of making it compatible with uBlock Origin.

Ok, but then I guess this means I will remove AdGuard Russian from the stock filter lists since enabling it is likely to cause issues -- there is no infrastructure in uBO to warn users that a specific filter list is incompatible with a currently selected one. (AdGuard was added at a time when RU AdList wasn't using uBO-specific syntax).

@gorhill
Copy link
Member

gorhill commented Oct 9, 2019

@dimisa-RUAdList
Is RU AdList still hosted only at https://easylist-downloads.adblockplus.org/advblock+cssfixes.txt or is there a more independent server from where it can be downloaded? If the list contains uBO-specific filters, this means ABP could decide to no longer host it at any time.

@dimisa-RUAdList
Copy link

@gorhill
I do not think that this will ever happen. RU AdList Fixes is officially recommended by ABP/AB for those cases when the capabilities of these extensions are not enough. The current state of affairs is extremely beneficial for ABP/AB. As the functionality of these extensions expands, they get relevant solutions that have been created over the years. Actually, this is already happening, for example with rules like abp-has and abort- *. And the use of RU AdList Fixes in uBlock Origin allows you to maintain relevance in the best way.

@lainverse
Copy link

lainverse commented Oct 11, 2019

@gorhill
Technicaly we can make a mirror right here on github, but I don't know would github keep serving it in case of hundreds of thousands requests a day. Do you host any subscriptions here or use some different hosting?

@gorhill
Copy link
Member

gorhill commented Oct 11, 2019

Filters are served from here, I have no idea whether this is close to be considered an issue by GitHub. I think I need to prepare something in case it does become an issue. I am fine to keep downloading RUAdList from easylist-downloads.adblockplus.org if it's RUAdList's home server.

gorhill added a commit to gorhill/uBlock that referenced this issue Oct 11, 2019
As per feedback from maintainers, AdGuard Russian
and RU AdList are incompatible and web site breakage
can occur when both are used together.

Related issue:
- uBlockOrigin/uBlock-issues#749
@gwarser
Copy link

gwarser commented Oct 11, 2019

Updated after Shift-Purge.


This should be Shift+Ctrl+Purge, so correction: updated after purge.

@gwarser gwarser closed this as completed Oct 11, 2019
@gwarser gwarser added fixed issue has been addressed and removed something to address something to address labels Oct 11, 2019
@uBlock-user uBlock-user removed the filterlist a filter list issue label Dec 13, 2019
JustOff pushed a commit to JustOff/uBlock that referenced this issue Jan 2, 2020
As per feedback from maintainers, AdGuard Russian
and RU AdList are incompatible and web site breakage
can occur when both are used together.

Related issue:
- uBlockOrigin/uBlock-issues#749
gorhill added a commit to gorhill/uBlock that referenced this issue Jan 2, 2020
* adress DandelionSprout/adfilt#7 (comment) (#3754)

* Add more languages for list selection at install/reset time

Related issue:
- uBlockOrigin/uBlock-issues#501

Also, the handling of 3-letter language codes has been fixed.

* Forgot to add `lij` re. uBlockOrigin/uBlock-issues#501

* Cater to legacy javascript engines

* Fix uBlockOrigin/uBlock-issues#531

* Fix NanoMeow/QuickReports#1091

* Removed seemingly abandoned "DNK: Schacks" list

Related discussion:
- DandelionSprout/adfilt#7 (comment)

* Remove "RUS: AdGuard Russian" from stock filter list

As per feedback from maintainers, AdGuard Russian
and RU AdList are incompatible and web site breakage
can occur when both are used together.

Related issue:
- uBlockOrigin/uBlock-issues#749

* Rename "Fanboy Cookie" to "EasyList Cookie" + update list link

Related issue:
- uBlockOrigin/uBlock-issues#804

Co-authored-by: okiehsch <okiehsch@users.noreply.github.com>
Co-authored-by: Raymond Hill <gorhill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

6 participants