-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default filter list for RU locale #749
Comments
I would also add a warning about possible conflicts, for those cases when users activate these two filters manually. |
Ok, but then I guess this means I will remove AdGuard Russian from the stock filter lists since enabling it is likely to cause issues -- there is no infrastructure in uBO to warn users that a specific filter list is incompatible with a currently selected one. (AdGuard was added at a time when RU AdList wasn't using uBO-specific syntax). |
@dimisa-RUAdList |
@gorhill |
@gorhill |
Filters are served from here, I have no idea whether this is close to be considered an issue by GitHub. I think I need to prepare something in case it does become an issue. I am fine to keep downloading RUAdList from |
As per feedback from maintainers, AdGuard Russian and RU AdList are incompatible and web site breakage can occur when both are used together. Related issue: - uBlockOrigin/uBlock-issues#749
Updated after Shift-Purge. This should be Shift+Ctrl+Purge, so correction: updated after purge. |
As per feedback from maintainers, AdGuard Russian and RU AdList are incompatible and web site breakage can occur when both are used together. Related issue: - uBlockOrigin/uBlock-issues#749
* adress DandelionSprout/adfilt#7 (comment) (#3754) * Add more languages for list selection at install/reset time Related issue: - uBlockOrigin/uBlock-issues#501 Also, the handling of 3-letter language codes has been fixed. * Forgot to add `lij` re. uBlockOrigin/uBlock-issues#501 * Cater to legacy javascript engines * Fix uBlockOrigin/uBlock-issues#531 * Fix NanoMeow/QuickReports#1091 * Removed seemingly abandoned "DNK: Schacks" list Related discussion: - DandelionSprout/adfilt#7 (comment) * Remove "RUS: AdGuard Russian" from stock filter list As per feedback from maintainers, AdGuard Russian and RU AdList are incompatible and web site breakage can occur when both are used together. Related issue: - uBlockOrigin/uBlock-issues#749 * Rename "Fanboy Cookie" to "EasyList Cookie" + update list link Related issue: - uBlockOrigin/uBlock-issues#804 Co-authored-by: okiehsch <okiehsch@users.noreply.github.com> Co-authored-by: Raymond Hill <gorhill@users.noreply.github.com>
Prerequisites
Description
Currently, uBlock Origin enables two different filter lists for users with "RU" locale:
AdGuard Russian filter
andRU AdList
.The problem is that these are two independent and not really compatible filter lists. Having both of them enabled leads to random issues. For instance, it often happens on websites that do heavy circumvention, and the reason is different incompatible approaches to handle such issues.
Proposed solution: there should be just one default "RU" filter list in uBlock Origin. IMO, it should be RU AdList, @dimisa-RUAdList does a great job of making it compatible with uBlock Origin.
I was asked to report this issue by the maintainers of these filter lists (@dimisa-RUAdList and @Alex-302), and they both agree on the proposed solution.
Your environment
The text was updated successfully, but these errors were encountered: