Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't control specificity in element picker with Firefox for Android #851

Closed
7 of 8 tasks
Yuki2718 opened this issue Jan 11, 2020 · 1 comment
Closed
7 of 8 tasks
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@Yuki2718
Copy link

Yuki2718 commented Jan 11, 2020

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

On PC I can easily switch selector on the Picker by holding Ctrl (usually id to class). But on mobile there's no Ctrl unless you plug keyboard on (or some IME may have Ctrl). Even worse, more often than not those alternative selector (class names) are not fully visible on mobile as seen in SS attached. As a result, I'm forced to view the page source if it works or use DOM inspector just to change selector. This inconvenience can be solved e.g. if Ctrl-click text on the Picker is clickable and after clicking it every entry is chosen w/ Ctrl by default. I guess this change meets the guideline expressed in
gorhill/uBlock#1890 (comment)
except for "majority of user" part, but I have no idea about e.g. javascript code.

SS

A specific URL where the issue occurs

https://github.com/gorhill/uBlock/issues

Steps to Reproduce

  1. Launch the Picker on Firefox for Android and choose any element which has id and class as selector.
  2. You can't switch the selector.

Expected behavior:

Noted above.

Actual behavior:

Noted above.

Your environment

  • uBlock Origin version: 1.24.2
  • Browser Name and version: Firefox for Android 68.4.1
  • Operating System and version: Android 10
@uBlock-user uBlock-user added Firefox-Android specific to Android platform something to address something to address labels Jan 11, 2020
gorhill added a commit to gorhill/uBlock that referenced this issue Sep 9, 2020
Related issue:
- uBlockOrigin/uBlock-issues#851

The ctrl key is no longer used to adjust specificity of
a candidate filter.

A new widget has been added to adjust the specificity of
a candidate filter to various level. The widget will be
visible as long as the candidate filter matches one entry
in the list of suggested candidate cosmetic filters.
@gorhill gorhill changed the title Make Ctrl-click text on Picker clickable Can't control specificity in element picker with Firefox for Android Sep 9, 2020
@uBlock-user uBlock-user added enhancement New feature or request fixed issue has been addressed and removed Firefox-Android specific to Android platform something to address something to address labels Sep 10, 2020
@uBlockOrigin uBlockOrigin deleted a comment from prateekrastogi Sep 10, 2020
@Yuki2718
Copy link
Author

Much appreciated!

gorhill added a commit to gorhill/uBlock that referenced this issue Sep 12, 2020
gorhill added a commit to gorhill/uBlock that referenced this issue Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants
@uBlock-user @Yuki2718 and others