Skip to content
This repository has been archived by the owner on Feb 26, 2022. It is now read-only.

fix: #30 #33

Closed
wants to merge 1 commit into from
Closed

fix: #30 #33

wants to merge 1 commit into from

Conversation

idseefeld
Copy link
Contributor

uComponents URL picker not working after Umbraco 6.2.4 to 6.2.5 upgrade.
issue #30
I have also tested version 6.1.3 and OuterXml instead of InnerXml is alos fine for this version.

uComponents URL picker not working after Umbraco 6.2.4 to 6.2.5 upgrade.
issue #30
@leekelleher
Copy link
Contributor

Thanks @idseefeld - I really need to schedule in a v6.0.1 patch release for this.

I need to review a couple of the other changes in PR #31 that @darylteo provided, (again, I'd left this open for far too long!)

@leekelleher leekelleher self-assigned this Jun 15, 2015
@darylteo
Copy link
Contributor

I took my solution from the umbraco forums. This fix seems much cleaner lol, if it passes the tests, I say dump mine and go for this one.

Edit: oh mine also has the javascript changes to work with MVC 4.0.0.1 (possibly). I seem to have been the only one with that issue though.

@ProNotion
Copy link

This solution worked perfectly for me and resolved the issue in 6.2.5. Thanks, hopefully it will make it into an updated version on Nuget soon as I still have quite a few sites running on 6.2.5 that sooner or later will run into this.

@leekelleher
Copy link
Contributor

Thanks to @ProNotion's comment, this came back on my radar. (I'd been more focused on my other - newer - Umbraco packages)

@idseefeld I've manually merged in your commit (a66c2e9), (as our branching structure had gone awry). Thanks also to @darylteo for PR #31!

The fix is part of the v6.1.0 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants