Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-webkit-deflate-frame #1157

Closed
ghost opened this issue Jan 4, 2021 · 2 comments
Closed

x-webkit-deflate-frame #1157

ghost opened this issue Jan 4, 2021 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 4, 2021

Apparently Safari still don't follow the standard regarding compression. Adding an alias för their variant will solve this issue

@ghost
Copy link
Author

ghost commented Jan 11, 2021

x-webkit-deflate-frame is a vendor prefix to deflate-frame which is not the same as permessage-deflate but very close. The only thing that differs is the negotiation of sliding windows.

By supporting this, the exact details of permessage-deflate parameters should be hidden better in a module and only expose the general idea to the rest of the code.

This is one example of how websockets/ws is overcomplicating things by exposing complicated parameters to the end user, while we take the path of having simple-to-use compressors. Things should be simple to understand for end-users and work everywhere.

@ghost ghost added the v18 label Jan 11, 2021
@ghost ghost closed this as completed Jan 11, 2021
@ghost
Copy link
Author

ghost commented Feb 19, 2021

It's not actually an alias, it has different negotiation rules. But yes Safari still use this and we have to support Safari

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

0 participants