tune z offset + fix in logging bug when no 3D model available

uPesy · Jun 25, 2022 · 6325431 · 6325431
1 parent 885a8ce
commit 6325431
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/easyeda2kicad/__main__.py b/easyeda2kicad/__main__.py
@@ -332,14 +332,15 @@ def main(argv: List[str] = sys.argv[1:]) -> int:
             ).output
         )
         exporter.export(lib_path=arguments["output"])
-        filename = f"{exporter.output.name}.wrl"
-        lib_path = f"{arguments['output']}.3dshapes"
-
-        logging.info(
-            f"Created 3D model for ID: {component_id}\n"
-            f"       3D model name: {exporter.output.name}\n"
-            f"       3D model path: {os.path.join(lib_path, filename)}"
-        )
+        if exporter.output:
+            filename = f"{exporter.output.name}.wrl"
+            lib_path = f"{arguments['output']}.3dshapes"
+
+            logging.info(
+                f"Created 3D model for ID: {component_id}\n"
+                f"       3D model name: {exporter.output.name}\n"
+                f"       3D model path: {os.path.join(lib_path, filename)}"
+            )
 
         # logging.info(f"3D model: {os.path.join(lib_path, filename)}")
 

diff --git a/easyeda2kicad/kicad/export_kicad_footprint.py b/easyeda2kicad/kicad/export_kicad_footprint.py
@@ -198,8 +198,8 @@ def generate_kicad_footprint(self) -> None:
         if self.input.model_3d is not None:
             self.input.model_3d.convert_to_mm()
 
-            if self.input.model_3d.translation.z != 0:
-                self.input.model_3d.translation.z -= 1
+            # if self.input.model_3d.translation.z != 0:
+            #     self.input.model_3d.translation.z -= 1
             print(self.input.bbox)
             ki_3d_model_info = Ki3dModel(
                 name=self.input.model_3d.name,