Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Commit

Permalink
fix: id static content div with fname rather than nodeId (#876)
Browse files Browse the repository at this point in the history
* fix: id static content div with fname rather than nodeId

In practice nodeId is always (often?) -1
  • Loading branch information
apetro committed Mar 7, 2019
1 parent 38cc076 commit 53c7ce6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ and this project adheres to

## [Unreleased][]

No changes so far
* Generate static content div identifier by fname rather than by
not-reliably-unique nodeId #876

## [9.0.0][] - 2019-02-26

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</div>
<frame-page ng-if="loaded" app-title="{{ portlet.title }}" app-icon="{{ portlet.faIcon }}" page-title="{{ portlet.title }}" app-fname="portlet.fname" app-show-add-to-home="true">
<md-card>
<div ng-bind-html="::portlet.exclusiveContent" class="up-portlet-content-wrapper" id="content-{{ ::portlet.nodeId }}"></div>
<div ng-bind-html="::portlet.exclusiveContent" class="up-portlet-content-wrapper" id="content-{{ ::portlet.fname }}"></div>
</md-card>
</frame-page>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</div>
<frame-page ng-if="loaded" app-title="{{ portlet.title }}" app-icon="{{ portlet.faIcon }}" page-title="{{ portlet.title }}" app-fname="portlet.fname" app-show-add-to-home="true">
<md-card>
<div ng-bind-html="::portlet.staticContent" class="up-portlet-content-wrapper" id="content-{{ ::portlet.nodeId }}"></div>
<div ng-bind-html="::portlet.staticContent" class="up-portlet-content-wrapper" id="content-{{ ::portlet.fname}}"></div>
</md-card>
</frame-page>
</div>

0 comments on commit 53c7ce6

Please sign in to comment.