fix(search): gracefully handle more directory search failure modaliti…

…es (#825)

When directory search fails for e.g. bad directory search URL config,
fail with user-facing message and console log message, and stop the loading indicator.

Removes `$scope.wiscDirectoryError`

`wiscDirectoryErrorMessage` *is* the flag that there's an error, we don't need a separate `wiscDirectoryError` to have to keep in compatible state with the message.

CHANGELOG.md

@@ -14,6 +14,9 @@ and this project adheres to
 
 ### Fixed
 
++ Gracefully handle case where directory search JSON URL is bad, as is the case
+  in naive localhost demo against stub data (#825)
+
 ## [8.2.0][] - 2018-06-22
 
 ### Changed

web/src/main/webapp/my-app/search/controllers.js

@@ -119,15 +119,24 @@ define([
                   results.errors[1] &&
                   results.errors[1].error_msg) {
                 if (results.errors[0].code == 4) {
+                  $log.warn(
+                    'Too many directory results for term ' + $scope.searchTerm);
                   $scope.wiscDirectoryTooManyResults = true;
+                } else {
+                  $log.warn(
+                    'Directory search error [' + results.errors[1].error_msg +
+                    '] on term ' + $scope.searchTerm);
                 }
+
                 $scope.wiscDirectoryErrorMessage= results.errors[1].error_msg;
               }
             }
             return results;
           }).catch(function() {
+            $log.warn('Directory search error on term ' + $scope.searchTerm);
             $scope.wiscDirectoryLoading = false;
-            $scope.wiscDirectoryError = true;
+            $scope.wiscDirectoryErrorMessage =
+              'Error. Unable to search the directory.';
           }
         );
       };

web/src/main/webapp/my-app/search/partials/directory-results.html

@@ -24,11 +24,22 @@ <h4 class="md-subhead">
 </h4>
 
 <div layout="row" layout-align="center center">
-  <loading-gif data-object="wiscDirectoryResults" data-empty="wiscDirectoryResultsEmpty"></loading-gif>
+  <loading-gif
+    ng-show="wiscDirectoryLoading"
+    data-object="wiscDirectoryResults"
+    data-empty="wiscDirectoryResultsEmpty"></loading-gif>
 </div>
 <div ng-show="wiscDirectoryResultsEmpty && !wiscDirectoryTooManyResults" class='no-result'>
   No directory results.
 </div>
+
+<div ng-if="wiscDirectoryErrorMessage"
+  layout="row" layout-align="center center">
+  <p>
+    {{wiscDirectoryErrorMessage}}
+  </p>
+</div>
+
 <div class="result" ng-repeat="item in wiscDirectoryResults | limitTo:wiscDirectoryResultLimit">
   <h4>{{item.fullName}}</h4>
   <p ng-if="item.formalName">Also known as {{item.formalName}}</p>
@@ -62,7 +73,4 @@ <h4>{{item.fullName}}</h4>
   <p ng-if="wiscDirectoryResultCount>wiscDirectoryResultLimit">
     <a href="" ng-click="showAllDirectoryResults()">See all {{wiscDirectoryResultCount}} directory results</a>
   </p>
-  <p ng-if="wiscDirectoryErrorMessage">
-    {{wiscDirectoryErrorMessage}}
-  </p>
 </div>