fix portlet-icon support for iconUrl custom SVG icons

App directory details page header uses portlet-icon to render app directory entry icon. This fixes support for custom iconUrl by correctly sourcing the data from the layoutObject in the portlet entry rather than incorrectly trying to source it from the surface. Cf. the structure of the data in the example app directory entry JSONs.

CHANGELOG.md

@@ -8,7 +8,10 @@ and this project adheres to
 
 ## unreleased
 
-No changes yet.
++ fix `portlet-icon` directive to support `iconUrl`
+  (the now preferred URL-to-an-SVG-file way of referencing icons).
+  so that app directory details pages show the entry icon rather than defaulting
+  to showing a star icon.
 
 ## 10.2.2 - 2020-04-14
 

web/src/main/webapp/my-app/layout/partials/portlet-icon.html

@@ -19,7 +19,7 @@
 
 -->
 <md-icon ng-if="portlet.mdIcon">{{ portlet.mdIcon }}</md-icon>
-<img ng-if="!portlet.mdIcon && !portlet.faIcon && portlet.iconUrl" ng-src="{{portlet.iconUrl}}" alt="App icon">
+<img style="width:24px; height:24px;" ng-if="!portlet.mdIcon && !portlet.faIcon && portlet.layoutObject && portlet.layoutObject.iconUrl" ng-src="{{portlet.layoutObject.iconUrl}}" alt="App icon">
 <i ng-if="!portlet.mdIcon && portlet.faIcon && portlet.faIcon.indexOf('fa-')===0" class="fa {{::portlet.faIcon}}"></i>
 <i ng-if="!portlet.mdIcon && portlet.faIcon && portlet.faIcon.indexOf('fa-')!==0" class="{{::portlet.faIcon}}"></i>
-<i ng-if="!portlet.mdIcon && !portlet.faIcon && !portlet.iconUrl" class="fa fa-star"></i>
+<i ng-if="!portlet.mdIcon && !portlet.faIcon && (!portlet.layoutObject.iconUrl || !portlet.layoutObject.iconUrl )" class="fa fa-star"></i>