This repository has been archived by the owner on May 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27
Show app directory search results the user can BROWSE but not SUBSCRIBE #844
Open
apetro
wants to merge
11
commits into
master
Choose a base branch
from
fix-badge-count
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 13, 2018
-
feat: display app dir search results on which user only has BROWSE perm
They had been counted in search results badge count. Show them last so that badge count and displayed items match and to honor the intention of granting BROWSE without SUBSCRIBE.
Configuration menu - View commit details
-
Copy full SHA for 6add007 - Browse repository at this point
Copy the full SHA 6add007View commit details -
Configuration menu - View commit details
-
Copy full SHA for 317f374 - Browse repository at this point
Copy the full SHA 317f374View commit details -
feat: repurpose mock Box app dir entry as BROWSE-not-SUBSCRIBE example
This mock app directory entry now serves as an example of an item with canAdd set to false.
Configuration menu - View commit details
-
Copy full SHA for c112556 - Browse repository at this point
Copy the full SHA c112556View commit details -
fix: suppress launch URL when user lacks permission to launch
Retain launch URL in not-logged-in case since user might be able to log in to gain privileges to really launch the item, and getLaunchURL( app, true) generates a URL suitable for not-logged-in-users to try to log in to gain access.
Configuration menu - View commit details
-
Copy full SHA for 766613d - Browse repository at this point
Copy the full SHA 766613dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48fcaf3 - Browse repository at this point
Copy the full SHA 48fcaf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91f244c - Browse repository at this point
Copy the full SHA 91f244cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a6c78b - Browse repository at this point
Copy the full SHA 9a6c78bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f914b0 - Browse repository at this point
Copy the full SHA 8f914b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cb8730 - Browse repository at this point
Copy the full SHA 4cb8730View commit details
Commits on Jul 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 02df2e0 - Browse repository at this point
Copy the full SHA 02df2e0View commit details
Commits on Aug 1, 2018
-
Configuration menu - View commit details
-
Copy full SHA for adc2f7a - Browse repository at this point
Copy the full SHA adc2f7aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.