UP-4964: Fix configuration of BranchingRenderingPipeline on uP5 #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipelineTerminatorTest.java, FocusedOnOnePortletPredicateTest.java, and ProfileFNamePredicateTest.java into the uPortal-rendering module (where they belong)
…figuration.java (XML to Java style)
… java.util.function.Predicate (Java 8 native)
…chPoint to make it easier to configure these (existing) capabilities in the uP5 way
…ingPipelineConfiguration
|
AppVeyor is failing due to unrelated issue from https://issues.jasig.org/browse/UP-4965 |
| private IPortalRenderingPipeline alternatePipe; | ||
|
|
||
| public void setOrder(int order) { | ||
| this.order = order; |
There was a problem hiding this comment.
❓ what happens if two branch points have the same order?
There was a problem hiding this comment.
One of them (randomly selected) will be processed first. IMHO that's fine. The alternative would be detecting the circumstance and throwing an exception.
There was a problem hiding this comment.
Perhaps logging a warning is a good middle ground.
…ain SemVer; check for multiple RenderingPipelineBranchPoint with the same 'order' value and throw an exception in case of collision
…ing features impacted by this fix
drewwills
changed the title
|
I removed the |
ChristianMurphy
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jasig.org/browse/UP-4964
Checklist
Description of change
The configuration patterns we adopted for uP5 are a big improvement. Nevertheless, some uPortal capabilities are not yet manageable in the uP5 way. One such capability is uPortal Rendering Pipeline customization based on branching. This PR aims to address this bug -- to make it possible to configure branching pipeline settings properly in uPortal-start.
I intend to add documentation for these features before removing the
[WIP]tag.