UP-5005: AdHocGroupTester uses GroupService.SearchMethod.CONTAINS wh… #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n it should use GroupService.SearchMethod.DISCRETE
ChristianMurphy
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…en it should use GroupService.SearchMethod.DISCRETE
https://issues.jasig.org/browse/UP-5005
Checklist
Description of change
The AdHocGroupTester is a PAGS tester that evaluates membership in the associated group based on your membership/non-membership in another group.
To perform these tests, it (necessarily) obtains a reference to this other group through the Groups API. They way it does so is bugged: it searches for a group that CONTAINS a string (in its name), when it should search for a group that IS a string.
Consider: 'graduate students' vs. 'undergraduate students'