Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(UP-5006): check initialFilter value is a valid category. #1147

Merged
merged 1 commit into from Mar 14, 2018

Conversation

bjagg
Copy link
Member

@bjagg bjagg commented Mar 14, 2018

Checklist
Description of change

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

? null
: categoryList
.stream()
.parallel()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work is minimal against a final variable, so no concerns of runaway threads. Good point, though.

@ChristianMurphy ChristianMurphy added this to the 5.1.0 milestone Mar 14, 2018
@ChristianMurphy ChristianMurphy merged commit 36e2f56 into uPortal-Project:master Mar 14, 2018
@bjagg bjagg deleted the UP-5006_marketplace branch June 26, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants